From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1E9lc7-0008GJ-5v
	for mharc-grub-devel@gnu.org; Mon, 29 Aug 2005 11:31:59 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1E9lc5-0008FF-6O
	for grub-devel@gnu.org; Mon, 29 Aug 2005 11:31:57 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1E9lc2-0008Cg-22
	for grub-devel@gnu.org; Mon, 29 Aug 2005 11:31:55 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1E9lc1-0008C6-Ny
	for grub-devel@gnu.org; Mon, 29 Aug 2005 11:31:53 -0400
Received: from [145.74.66.11] (helo=mail-cn.han.nl)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1E9la7-0004IU-1o
	for grub-devel@gnu.org; Mon, 29 Aug 2005 11:29:55 -0400
Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6])
	by mail-cn.han.nl (Postfix) with ESMTP id E227E833B
	for <grub-devel@gnu.org>; Mon, 29 Aug 2005 17:27:37 +0200 (CEST)
Received: from mail-cn.han.nl ([145.74.66.11])
	by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new,
	port 10024) with ESMTP id 21125-08 for <grub-devel@gnu.org>;
	Mon, 29 Aug 2005 17:27:34 +0200 (CEST)
Received: from mail1.han.nl (mail1.han.nl [145.74.103.11])
	by mail-cn.han.nl (Postfix) with ESMTP id 83F3188B7
	for <grub-devel@gnu.org>; Mon, 29 Aug 2005 17:27:34 +0200 (CEST)
Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129])
	by mail1.han.nl (Postfix) with ESMTP id 4F9B6C048
	for <grub-devel@gnu.org>; Mon, 29 Aug 2005 17:27:34 +0200 (CEST)
Mail-Copies-To: metgerards@student.han.nl
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <87r7cg73hs.fsf@student.han.nl>
	<200508281437.19326.okuji@enbug.org>
From: Marco Gerards <metgerards@student.han.nl>
Date: Mon, 29 Aug 2005 17:27:34 +0200
In-Reply-To: <200508281437.19326.okuji@enbug.org> (Yoshinori K. Okuji's
	message of "Sun, 28 Aug 2005 14:37:19 +0200")
Message-ID: <87hdd8pxuh.fsf@student.han.nl>
User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl
Subject: Re: Completion for arguments
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Aug 2005 15:31:57 -0000

"Yoshinori K. Okuji" <okuji@enbug.org> writes:

> On Saturday 27 August 2005 00:11, Marco Gerards wrote:
>> +  /* Add the short arguments.  */
>> +  for (option = cmd->options; option->doc; option++)
>> +    {
>> +      if (!option->shortarg)
>> +	continue;
>
> This should be:
>
>   if (! grub_isgraph (option->shortarg))
>     continue;
>
> because we sometimes want to specify non-graph short arguments for 
> convenience.

You are right, I will fix this next time when I commit a patch.

Thanks,
Marco