From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Dt92U-0001Mr-MG for mharc-grub-devel@gnu.org; Thu, 14 Jul 2005 15:06:33 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Dt92O-0001Ih-7z for grub-devel@gnu.org; Thu, 14 Jul 2005 15:06:24 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Dt92G-0001CQ-Ep for grub-devel@gnu.org; Thu, 14 Jul 2005 15:06:20 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dt92F-0001Bi-Bv for grub-devel@gnu.org; Thu, 14 Jul 2005 15:06:15 -0400 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Dt96S-0002qS-Ve for grub-devel@gnu.org; Thu, 14 Jul 2005 15:10:37 -0400 Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6]) by mail-cn.han.nl (Postfix) with ESMTP id 45127895F for ; Thu, 14 Jul 2005 21:02:13 +0200 (CEST) Received: from mail-cn.han.nl ([145.74.66.11]) by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new, port 10024) with ESMTP id 23649-10 for ; Thu, 14 Jul 2005 20:08:52 +0200 (CEST) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 7901E8999 for ; Thu, 14 Jul 2005 21:02:10 +0200 (CEST) Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id 0C7B8C045 for ; Thu, 14 Jul 2005 21:02:10 +0200 (CEST) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <42D6B0CB.9070208@nic.fi> From: Marco Gerards Date: Thu, 14 Jul 2005 21:02:13 +0200 In-Reply-To: <42D6B0CB.9070208@nic.fi> ( =?iso-8859-1?q?Vesa_J=E4=E4skel=E4inen's_message_of?= "Thu, 14 Jul 2005 21:36:59 +0300") Message-ID: <87hdex6wju.fsf@student.han.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl Subject: Re: [PATCH] Kernel support for VESA Bios Extension X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jul 2005 19:06:26 -0000 Vesa J=E4=E4skel=E4inen writes: Hi, Thanks a lot for your work. I am looking forwards to the VESA console! > Here is attached a patch that adds VBE support to kernel and include > file to make it easier to use it. There is diff for both i386-pc.rmk > and i386-pc.mk. Latter could be removed and let build process to > generate it again, but I think that .mk file is present in CVS so I > left both there. Please always include the changed to *.rmk in the patches. You don't have to supply *.mk because those files are generated and make the patch just harder to read. > I will make separate patch for the frame buffer console after this is > first committed. (And I need to make some cleanups there first) Ok. > I would like to hear comments about the patch. I tried to implement > most commonly needed functions, so you can't do everything with > this. As I didn't need to use every function in my frame buffer > console test, some things might not work. But I tried to make my best > to proof read every function. Can you please make sure you are using the GCS for coding style? Please have a look at the other sourcecode and the GCS (GNU Coding Standards) first: http://www.gnu.org/prep/standards/ It is important for us to have a single and consistent coding style. If you have questions about either GRUB or the coding style you are of course free to ask. Thanks, Marco