From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1ClaAR-0004jP-Fb for mharc-grub-devel@gnu.org; Mon, 03 Jan 2005 16:55:11 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1ClaAP-0004ie-Gj for grub-devel@gnu.org; Mon, 03 Jan 2005 16:55:09 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1ClaAM-0004hL-95 for grub-devel@gnu.org; Mon, 03 Jan 2005 16:55:06 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1ClaAM-0004hA-3s for grub-devel@gnu.org; Mon, 03 Jan 2005 16:55:06 -0500 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1ClZyu-0005vG-VW for grub-devel@gnu.org; Mon, 03 Jan 2005 16:43:17 -0500 Received: from vscan-ca.han.nl (mars.han.nl [145.74.129.116]) by mail-cn.han.nl (Postfix) with ESMTP id 76B8D9A12 for ; Mon, 3 Jan 2005 22:43:16 +0100 (CET) Received: from mail-cn.han.nl ([145.74.66.51]) by vscan-ca.han.nl (mars.han.nl [145.74.129.116]) (amavisd-new, port 10024) with LMTP id 04671-02-65 for ; Mon, 3 Jan 2005 22:43:13 +0100 (CET) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 7FF259319 for ; Mon, 3 Jan 2005 22:43:13 +0100 (CET) Received: from marco.marco-g.com (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id 464AEC04B for ; Mon, 3 Jan 2005 22:43:13 +0100 (CET) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <20050103182344.GA30549@miracle> From: Marco Gerards Date: Mon, 03 Jan 2005 21:42:42 +0000 In-Reply-To: <20050103182344.GA30549@miracle> (Hollis Blanchard's message of "Mon, 3 Jan 2005 12:23:44 -0600") Message-ID: <87hdly2nql.fsf@marco.marco-g.com> User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-ca.han.nl Subject: Re: suspend command patch X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jan 2005 21:55:10 -0000 Hollis Blanchard writes: > Now that module support is within reach, this patch implements the Open > Firmware "enter" command, which allows us to get back to the interactive > OF prompt after loading a client program (GRUB). Nice! > As discussed previously, the GRUB command name is "suspend", and the > file is in a new commands/ieee1275 directory, as it should work on all > Open Firmware architectures. Before this can be checked in, I want to wait until Okuji agrees with this directory layout. > I have successfully tested this on my G3. The briQ seems to have an > unfortunate bug: "enter" works, but running "go" to resume GRUB results > in GRUB being re-entered from its entry point. I wonder if this bug > still affects later Codegen releases (i.e the Pegasos)... > I can test this and I will let you know. > +static grub_err_t > +grub_cmd_suspend (struct grub_arg_list *state, int argc, char **args) > +{ > + (void)state; > + (void)argc; > + (void)args; Better use an attribute for this. > + grub_printf("Run 'go' to resume GRUB.\n"); > + grub_ieee1275_enter(); Can you add a space before the ()? Thanks, Marco