From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix NR_KEYS off-by-one error
Date: Sat, 17 Jul 2004 02:18:56 +0900 [thread overview]
Message-ID: <87hds7lvjz.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <20040716164435.GA8078@ucw.cz>
Vojtech Pavlik <vojtech@suse.cz> writes:
> On Sat, Jul 17, 2004 at 01:35:59AM +0900, OGAWA Hirofumi wrote:
> > KDGKBENT ioctl can use 256 entries (0-255), but it was defined as
> > key_map[NR_KEYS] (NR_KEYS == 255). The code seems also thinking it's 256.
> >
> > key_map[0] = U(K_ALLOCATED);
> > for (j = 1; j < NR_KEYS; j++)
> > key_map[j] = U(K_HOLE);
>
> The patch below might cause problems, though, because some apps may (in
> old versions are) using a char variable to index up to NR_KEYS, which
> leads to an endless loop.
Maybe. But isn't it just bug of apps?
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2004-07-16 17:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-16 16:35 [PATCH] Fix NR_KEYS off-by-one error OGAWA Hirofumi
2004-07-16 16:44 ` Vojtech Pavlik
2004-07-16 17:18 ` OGAWA Hirofumi [this message]
2004-07-16 20:15 ` Andries Brouwer
2004-07-17 6:23 ` OGAWA Hirofumi
2004-07-26 22:43 ` Andrew Morton
2004-07-27 13:46 ` Vojtech Pavlik
2004-07-27 16:37 ` OGAWA Hirofumi
2004-07-27 17:54 ` Vojtech Pavlik
2004-07-27 18:35 ` OGAWA Hirofumi
2004-07-28 11:51 ` Andries Brouwer
2004-07-28 16:46 ` OGAWA Hirofumi
2004-07-28 20:42 ` Paul Jackson
2004-07-29 4:10 ` OGAWA Hirofumi
2004-07-29 6:15 ` Paul Jackson
2004-07-29 9:24 ` OGAWA Hirofumi
2004-07-29 9:49 ` Paul Jackson
2004-07-29 23:24 ` Andrew Morton
2004-07-29 23:51 ` Paul Jackson
2004-07-30 1:25 ` OGAWA Hirofumi
2004-07-30 7:27 ` Paul Jackson
2004-07-30 8:07 ` Vojtech Pavlik
2004-07-30 8:41 ` Andries Brouwer
2004-07-30 8:51 ` Vojtech Pavlik
2004-07-30 9:03 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hds7lvjz.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.