From: Christer Weinigel <christer@weinigel.se>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk, chris@qwirx.com
Subject: wingel@nano-system.com
Date: 22 Nov 2002 02:21:27 +0100 [thread overview]
Message-ID: <87heeav1pk.fsf@zoo.weinigel.se> (raw)
[-- Attachment #1: Type: text/plain, Size: 188 bytes --]
Hi,
Chris Wilson found and fixed a few bugs in the failure paths of the
scx200_wdt driver that I'm the maintainer for. Could you please apply
this patch that fixes these.
/Christer
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: scx200_wdt.patch --]
[-- Type: text/x-patch, Size: 793 bytes --]
--- linux-2.5.47/drivers/char/scx200_wdt.c Mon Nov 11 03:28:26 2002
+++ linux-2.5.47-chris/drivers/char/scx200_wdt.c Sun Nov 17 19:27:32 2002
@@ -240,23 +240,28 @@
}
scx200_wdt_update_margin();
scx200_wdt_disable();
sema_init(&open_semaphore, 1);
r = misc_register(&scx200_wdt_miscdev);
- if (r)
+ if (r) {
+ release_region(SCx200_CB_BASE + SCx200_WDT_OFFSET,
+ SCx200_WDT_SIZE);
return r;
+ }
r = register_reboot_notifier(&scx200_wdt_notifier);
if (r) {
printk(KERN_ERR NAME ": unable to register reboot notifier");
misc_deregister(&scx200_wdt_miscdev);
+ release_region(SCx200_CB_BASE + SCx200_WDT_OFFSET,
+ SCx200_WDT_SIZE);
return r;
}
return 0;
}
static void __exit scx200_wdt_cleanup(void)
{
[-- Attachment #3: Type: text/plain, Size: 205 bytes --]
--
"Just how much can I get away with and still go to heaven?"
Freelance consultant specializing in device driver programming for Linux
Christer Weinigel <christer@weinigel.se> http://www.weinigel.se
reply other threads:[~2002-11-22 1:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87heeav1pk.fsf@zoo.weinigel.se \
--to=christer@weinigel.se \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=chris@qwirx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.