All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zlatko Calusic <Zlatko.Calusic@CARNet.hr>
To: "Eric W. Biederman" <ebiederm+eric@npwt.net>
Cc: linux-mm@kvack.org
Subject: Re: Comments on shmfs-0.1.010
Date: 18 Jul 1998 14:59:02 +0200	[thread overview]
Message-ID: <87hg0ffh7t.fsf@atlas.CARNet.hr> (raw)
In-Reply-To: ebiederm+eric@npwt.net's message of "17 Jul 1998 19:50:32 -0500"

ebiederm+eric@npwt.net (Eric W. Biederman) writes:

> >>>>> "ZC" == Zlatko Calusic <Zlatko.Calusic@CARNet.hr> writes:
> 
> ZC> Hi!
> ZC> Today, I finally found some time to play with shmfs and I must admit
> ZC> that I'm astonished with the results!
> 
> ZC> After some trouble with patching (lots of conflicts which had to be
> ZC> resolved manually), to my complete surprise, shmfs proved to be quite
> ZC> stable and reliable.
> 
> ZC> I found these messages in logs (after every boot):
> 
> ZC> swap_after_unlock_page: lock already cleared
> ZC> Adding Swap: 128988k swap-space (priority 0)
> ZC> swap_after_unlock_page: lock already cleared
> ZC> Adding Swap: 128484k swap-space (priority 0)
> 
> This is a normal case with no harm.  
> I think normal 2.1.101 should cause it too.
> It's simply a result of swapping adding swap.

Well, it looks like it's harmless. I don't know why. :)

> 
> ZC> and lots of these:
> 
> ZC> Jul 16 22:50:42 atlas kernel: write_page: called on a clean page! 
> ZC> Jul 16 22:51:16 atlas last message repeated 612 times
> ZC> Jul 16 22:51:29 atlas last message repeated 463 times
> ZC> Jul 16 22:51:29 atlas kernel: kmalloc: Size (131076) too large 
> ZC> Jul 16 22:51:30 atlas kernel: write_page: called on a clean page! 
> ZC> Jul 16 22:51:30 atlas last message repeated 10 times
> ZC> Jul 16 22:51:30 atlas kernel: kmalloc: Size (135172) too large 
> ZC> Jul 16 22:51:30 atlas kernel: write_page: called on a clean page! 
> ZC> Jul 16 22:51:30 atlas last message repeated 9 times
> ZC> Jul 16 22:51:31 atlas kernel: kmalloc: Size (139268) too large 
> ZC> etc...
> 
> A debugging message for a case I didn't realize was common!
> I haven't had a chance to update it yet.
> 
> The kmalloc is a little worrysome though.
> Are you creating really large files in shmfs?

Yes, I was creating very big file to test some things.

But after I applied my patch, I never saw those kmalloc messages?!

> 
> ZC> But other than that, machine didn't crash, and shmfs is happily
> ZC> running right now, while I'm writing this. :)
> 
> ZC> I decided to comment those "write_page..." messages, recompile kernel,
> ZC> and finally do some benchmarking:
> 
> ZC> 2.1.108 + shmfs:
> 
> ZC>               -------Sequential Output-------- ---Sequential Input-- --Random--
> ZC>               -Per Char- --Block--- -Rewrite-- -Per Char- --Block--- --Seeks---
> ZC> Machine    MB K/sec %CPU K/sec %CPU K/sec %CPU K/sec %CPU K/sec %CPU  /sec %CPU
> ZC>           100  2611 90.7  3924 86.2  3201 13.3  4763 61.4  6736 24.4 143.7  4.0
> 
> ZC> Then I decided to apply my patch, which removes page aging etc...
> ZC> (already sent to this list):
> 
> ZC>               -------Sequential Output-------- ---Sequential Input-- --Random--
> ZC>               -Per Char- --Block--- -Rewrite-- -Per Char- --Block--- --Seeks---
> ZC> Machine    MB K/sec %CPU K/sec %CPU K/sec %CPU K/sec %CPU K/sec %CPU  /sec %CPU
> ZC>           100  3023 99.5  4343 99.1  6342 26.3  7819 98.4 17860 64.0 156.4  3.6
> ZC>                                                           ^^^^^      ^^^^^
> ZC> Final result is great (almost 18MB/s, never saw such a big number in
> ZC> bonnie :)).
> 
> I'm a little worried by the slow output that uses huge chunks of cpu time.
> But it looks like I wrote my block allocation algorithm properly.
> 
> I have a lot of tuning options that can influence things, primarily
> because it is development code and I'm not sure what the best approach
> is.  Did you change any of them from their default?
>

Unfortunately not. Time for experimenting ran out. :(

> ZC> Last experiment I did was to put entry in /etc/fstab so that shmfs get
> ZC> mounted on /tmp at boot time. That indeed worked, but unfortunately, X
> ZC> (or maybe fvwm?) refused to work after that change, for unknown reason
> ZC> (nothing in logs).
> 
> Look at the permissions on /tmp.  But default only root can write to shmfs...
> I should probably implement uid gid options to set the permissions of
> the root directory but I haven't done that yet.
> 

Now when you say it, problem was probably that. Trivial. :)
And since fvwm writes some stupid temp file, now everything is
obvious.

> ZC> P166MMX, 64MB RAM
> ZC> hda: WDC AC22000L, ATA DISK drive
> ZC> sda: FUJITSU   Model: M2954ESP SUN4.2G  Rev: 2545 (aic7xxx)
> 
> ZC> shmfs                     /shm            shmfs   defaults   0       0
> ZC> /dev/hda1                 none            swap    sw,pri=0   0       0
> ZC> /dev/sda1                 none            swap    sw,pri=0   0       0
> 
> Interesting.  If I read this correctly you might have been getting
> parrallel raid type read performance off of your two disks, on the
> block read test.
> 
> ZC> Really good work, Eric!
> ZC> I hope your code gets into official kernel, as soon as possible.
> 
> Thanks for the encouragement, but until I equal or better ext2 in all
> marks the works not done :)
> 

Yesterday I tried to copy linux tree to /shm and got these errors:

Jul 17 18:57:10 atlas kernel: shmfs: No more inodes! 
Jul 17 18:57:10 atlas last message repeated 3 times
Jul 17 18:57:10 atlas kernel: shmfs_mkdir: shmfs_new_inode failed 
Jul 17 18:57:10 atlas kernel: shmfs: No more inodes! 
Jul 17 18:57:10 atlas last message repeated 2 times
Jul 17 18:57:10 atlas kernel: shmfs_mkdir: shmfs_new_inode failed 
Jul 17 18:57:10 atlas kernel: shmfs: No more inodes! 
Jul 17 18:57:10 atlas kernel: shmfs_mkdir: shmfs_new_inode failed 
Jul 17 18:57:10 atlas kernel: shmfs: No more inodes! 
Jul 17 18:57:10 atlas kernel: shmfs: No more inodes! 
Jul 17 18:57:10 atlas kernel: shmfs_mkdir: shmfs_new_inode failed 
...

Tree has around 4200 files (which is slightly more than inode limit on 
Linux!). Few last files didn't get copied.

Regards,
-- 
Posted by Zlatko Calusic           E-mail: <Zlatko.Calusic@CARNet.hr>
---------------------------------------------------------------------
       I'm a nobody, nobody is perfect, therefore I'm perfect.
--
This is a majordomo managed list.  To unsubscribe, send a message with
the body 'unsubscribe linux-mm me@address' to: majordomo@kvack.org

  reply	other threads:[~1998-07-18 12:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1998-07-16 22:03 Comments on shmfs-0.1.010 Zlatko Calusic
1998-07-18  0:50 ` Eric W. Biederman
1998-07-18 12:59   ` Zlatko Calusic [this message]
1998-07-18 16:03     ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hg0ffh7t.fsf@atlas.CARNet.hr \
    --to=zlatko.calusic@carnet.hr \
    --cc=ebiederm+eric@npwt.net \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.