All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tristan de Cacqueray <tristan@midirus.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Miguel Ojeda <ojeda@kernel.org>,
	linux-sound@vger.kernel.org, rust-for-linux@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 0/3] rust: snd: Introduce experimental ALSA rawmidi abstractions
Date: Mon, 12 Oct 2026 19:46:11 +0000	[thread overview]
Message-ID: <87ik36em81.fsf@midirus.com> (raw)
In-Reply-To: <87ld83gl9g.wl-tiwai@suse.de>


On Mon, Oct 12, 2026 at 14:23 Takashi Iwai wrote:
> On Sun, 11 Oct 2026 15:02:11 +0200,
> Tristan de Cacqueray wrote:
>>
>> Hi Takashi and the Rust for Linux maintainers.
>>
>> I just noticed your mail about an early Rust prototype for the sound
>> subsystem right before I was about to submit this RFC!
>>   https://lore.kernel.org/alsa-devel/878q48579z.wl-tiwai@suse.de/
>>
>> Nevertheless, please allow me to share what I had in mind through this
>> small proof of concept for the `rawmidi` API. I am looking for feedback on
>> the scope, coordination, and the ownership model rather than a detailed
>> review for merging.
>>
>> My use case is a new hardware controller using a custom serial protocol.
>> While developing its Rust driver, I needed an interface to ALSA rawmidi.
>> I'm particularly interested in handling rawmidi substream safely to avoid
>> issues like the one fixed by
>>   221253723dc5 ("ALSA: bcd2000: Fix race between rawmidi and disconnect")
>>
>> So, I wrote some bindings to see how that would look like. This series adds
>> experimental snd_card and snd_rawmidi wrappers, input/output callback
>> traits, and a sample rawmidi faux device using delayed work to simulate
>> incoming MIDI data.
>>
>> This is not merge-ready. In particular, the prototype does not yet enforce
>> the devres lifetime of the card or the lifetime of its rawmidi wrapper. The
>> substream helper also relies on the driver clearing it before close
>> returns.
>>
>> Here are my questions:
>>
>>   1. Does this rawmidi experiment overlaps with your prototype?
>>      If so, I would be happy to coordinate or adapt this experiment to it.
>
> No, my patchset doesn't contain rawmidi support yet.
> The sound card abstraction would conflict quite, sure, but it wouldn't
> be too hard to adapt, I guess.
>

That's great, I can rebase my rawmidi abstraction onto your branch.

>>   2. Is rawmidi a useful initial target for ALSA Rust abstraction?
>
> Sure, why not, if it's actually needed? :)
>

I think Rust could help make midi_ops implementation safer. Would it make
sense to port the virmidi driver as a demonstration, or would you
recommend a different driver as a starting point?

>>   3. Does your prototype mirror the C API 1:1, or for example, does it hide
>>      the substream lifecycle? That's the design choice I'm least sure about.
>
> It's mostly a straightforward wrapping of C API, but there are a few
> twists to adapt Rust-way.  The card can be managed in RAII style, too,
> for example.
>
> I haven't prepared for submission, but you can find the current
> changes in test/sound-rust branch of sound git tree (either kernel.org
> or github.com):
>   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/log/?h=test/sound-rust
>   https://github.com/tiwai/sound/tree/test/sound-rust
>
> Those are over 50 commits on top of 7.3-rc5, and I'll likely rebase a
> bit to rearrange before submission, so beware of changes in future.
>
> The commits begin with a few Rust kernel changes for fixing and
> addition for the sound support, including the PM support from Beata
> Michalska (just took what have been posted), followed by ALSA core
> abstractions for the card, PCM and controls.
>
> Then it continues to the implementations of 3 actual sound drivers for
> PCM/control: the dummy driver (with platform and hrtimer), and the
> ens1370 and intel8x0 drivers for PCI devices to be run on VM.
>
> After that, the extension to USB abstraction follows, including the
> isochronous support patches by Colin Braun, and then the USB-audio
> driver implementation (that can run on an actual bare metal), as well
> as the USB runtime PM support.
>

Thank you for sharing the branch. I'll take a look.

>
> BTW, until now, I haven't planned for any serious consideration to
> merge Rust stuff yet.  Partly because the above was a pure experiment
> for me, but another big obstacle is that the whole Rust C binding is
> limited to built-in vmlinux.  With a distribution kernel maintainer
> hat on, this is absolutely NO-GO -- we really want to avoid built-in.
> (Graphics is a kind of exception nowadays because of boot support,
> though.)  Can this be worked out soon...?
>

Wow, that sounds like a major limitation that I wasn't aware of. I'm not
familiar with the status of this issue, but I'd be happy to help if
there's something I can contribute.

Thank you for the prompt reply Takashi. I really appreciate it!
-Tristan


      reply	other threads:[~2026-10-12 19:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-11 13:02 [PATCH RFC 0/3] rust: snd: Introduce experimental ALSA rawmidi abstractions Tristan de Cacqueray
2026-10-11 13:02 ` [PATCH RFC 1/3] rust: snd: Add initial snd_card binding Tristan de Cacqueray
2026-10-11 13:02 ` [PATCH RFC 2/3] rust: snd: Add snd_rawmidi binding Tristan de Cacqueray
2026-10-11 13:02 ` [PATCH RFC 3/3] rust: snd: Add active rawmidi_substream helper Tristan de Cacqueray
2026-10-12 12:23 ` [PATCH RFC 0/3] rust: snd: Introduce experimental ALSA rawmidi abstractions Takashi Iwai
2026-10-12 19:46   ` Tristan de Cacqueray [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ik36em81.fsf@midirus.com \
    --to=tristan@midirus.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.