From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19741C88E41 for ; Fri, 11 Sep 2026 06:20:36 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x4uc0-0007Yk-C7; Fri, 11 Sep 2026 02:19:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x4ubr-0007SC-Vx for qemu-devel@nongnu.org; Fri, 11 Sep 2026 02:19:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x4ubm-0005E6-Pf for qemu-devel@nongnu.org; Fri, 11 Sep 2026 02:19:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1789107567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kzXQbcpjRw9LSYhLvrlRQAbDhTkUWMb9V7C7/z1sFek=; b=UTa45VvXo0aK2cpzZjz0xS298H5XPk6I/d2zao55VVCuX+4thyFbpWbQw1RoDCh2UzXyN5 saLAUugsIHDQr70VdJUkKYfFtuusdr5+xDFxgRrrhO8r189QV6W1JzYklnYvYTaj+FiJGB 7UboN/1MzGGPbMRIaKvrurDDLc7Ao3U= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-463-3qy27uPQP3uZZcQeSjF8LA-1; Fri, 11 Sep 2026 02:19:23 -0400 X-MC-Unique: 3qy27uPQP3uZZcQeSjF8LA-1 X-Mimecast-MFC-AGG-ID: 3qy27uPQP3uZZcQeSjF8LA_1789107562 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C1A92180057E; Fri, 11 Sep 2026 06:19:21 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.44.22.5]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 443581956087; Fri, 11 Sep 2026 06:19:21 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 9BE2121E6A04; Fri, 11 Sep 2026 08:19:18 +0200 (CEST) From: Markus Armbruster To: Fabiano Rosas Cc: qemu-devel@nongnu.org, Peter Xu , "Dr . David Alan Gilbert" , Laurent Vivier , Paolo Bonzini Subject: Re: [PATCH v2 11/18] migration: HMP: Fix bandwidth parameters In-Reply-To: <87zexpth8n.fsf@suse.de> (Fabiano Rosas's message of "Thu, 10 Sep 2026 09:37:12 -0300") References: <20260909214509.237309-1-farosas@suse.de> <20260909214509.237309-12-farosas@suse.de> <875x0dhc9u.fsf@pond.sub.org> <87zexpth8n.fsf@suse.de> Date: Fri, 11 Sep 2026 08:19:18 +0200 Message-ID: <87ik4cb995.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Fabiano Rosas writes: > Markus Armbruster writes: > >> Fabiano Rosas writes: >> >>> The max-bandwidth and avail-switchover-bandwidth parameters are >>> declared as bytes/second in migration.json and interpreted as such >>> throughout the code, except in HMP where they're expected to be >>> provided as mebibytes. >>> >>> Fix the HMP code to parse the values as bytes. >> >> I wouldn't call this a fix. The choice of unit was clearly intentional. >> Doesn't mean we must not change it now. David, what do you think? >> > > Hm, but if the code uses bytes in arithmetic throughout, there must be > bugs lingering somewhere. Although I haven't verified that. I don't think so; the old code parses the argument string into a byte count. > Nonetheless, > I can use a different terminology, no worries. Thanks!