From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B787C61DD6 for ; Wed, 2 Sep 2026 13:20:59 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x1ktY-0006Yw-Uv; Wed, 02 Sep 2026 09:20:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x1ktV-0006Xw-UL for qemu-arm@nongnu.org; Wed, 02 Sep 2026 09:20:50 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1x1ktT-00076l-3f for qemu-arm@nongnu.org; Wed, 02 Sep 2026 09:20:49 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-49b392ccaacso15184195e9.2 for ; Wed, 02 Sep 2026 06:20:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1788355244; x=1788960044; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:message-id:date :user-agent:references:in-reply-to:subject:cc:to:from:from:to:cc :subject:date:message-id:reply-to:content-type; bh=C+WdB3sH0pKz8efta5NVNWLlShVKyzTvfELYT2zM3J4=; b=FCKKqnHZpnCjsxQZUnWZVWeVcGPsJvIihUld/x4tw70UtsGNTJvtoz5+RVcWO0SmGp srW0xdywebuvn7mbJHi/ToUcn1WCrRa58mKavyPLnd4lrSXNcI4BMEkyFMed4PxTU/gZ IZ/zLBJgRKGQBU3tmnJYjrUYYcmJLvvYGhxQ6OAe0SCJ+snAPvH26SVLPrVduAD60T+P 7XxHQ4QvRtqe0hymOIWQ/ddp2cnFw6xUgj9+eh6rhqtPCk/ZS3Rt57AGHmpe6ag/kwh/ KaytBuJPQQaB5841eOq7aVL8aFh5o8vmfRArWdr2Xu6zFfNmQI2QuEHuVNMhU+CiQoiK tzWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788355244; x=1788960044; h=content-transfer-encoding:content-type:mime-version:message-id:date :user-agent:references:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=C+WdB3sH0pKz8efta5NVNWLlShVKyzTvfELYT2zM3J4=; b=Jbf1iZGWticitkyEqIgGNGdWpqbdWbCaDBqM7eqfH6UILNaqqUXSjIv17zLPmaDIUl Zc490qSVNrSSkLBODM5EuKD/WRI1moueSFZ6AcA5IGEBSRqX75NzkcUV+xPR2iZVVbhp 7ANlfTmfhYeRW8tb3k4hQaNSjtKD9HxqwVsqqCeTVTedAHicpWK2Y6rP2Lb70f3lAwmE hapSIkR9kzkdPyuejOftjJ6JFgv8SKJyvYrvqJShVj6QBZBeFdfJjPjavz+Fi8QX8Gdq 5B+hxI0aKjemaiQvMxmZZ7WMCL/GBUKjCE+7u0MePqVBZPk3X08QOGQww4YOVX6tv19t yf1g== X-Forwarded-Encrypted: i=1; AHgh+Rq8IeYQAAqg8+mBrkq4xdXb5zaHpgDGMbg3KIH24SF6Nx5M7DJZw1NT/N2PsQ4QlCSRRrVz3kqnKQ==@nongnu.org X-Gm-Message-State: AFuF++khJMNdjUHoolqeBJRAenQa+7Wez4iN5HLvB43tSV2znjVvL0M3 uYT1xoNPtnCqOnsQCXGOqJYFmAyevo0/Wt3Bs2V7bT5lIAlDeEHA6+qvP8ZruV6+htR3X2j2Df8 K/zhxpPQ= X-Gm-Gg: AR+sD1318FcjrCa2ITsPwnijEKEWGyOBIAHO3OtiGeTSIT5g1Z8bhEHvMMral6gBUG9 Ti5mA5SxWFigY9csqW1FuxeqzLfrpiyP111QDKMzjPAVTbi51Yhiibo+Op+mFMtJa9wmn42t7Ln Ow3NjoBD1SwDQPxEyG6jDxCejiF49Sy4sQzCVY8DMNQiEwKEuau750a0nFwC1nrpNwDTtX+GfqH 5Kogqg0G3e1XMgef4pn0VppFtBlPBw0g0WRCgj6kl9RqVEQNLjeQLgmIivpjLKtBpFf4/schM5C 3XmSeUcrJ2k+Hu8fYQ2zm/FJfAm3Wtu0JVZjPDrvwwAfFZZPP8L9FZWxTCH/0ccX3ff8dnoiWXh 2UWlf6/z+Pt7IKW1NxBiavjffHjSZVPey/Z9/AN8KyVCuBfmQWT83Y8t4cLCdS3orb+9FZa301Z TRb0ks1WRXJBGtLY2vLwq4OEkHmD74j0/sKcE+aZTGIvSzVjaowxoFs07EAPRd X-Received: by 2002:a05:600c:8b4c:b0:49c:edd2:855 with SMTP id 5b1f17b1804b1-49cedd20930mr10135665e9.6.1788355244336; Wed, 02 Sep 2026 06:20:44 -0700 (PDT) Received: from draig.lan ([185.124.0.156]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ce4642382sm75057215e9.3.2026.09.02.06.20.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 06:20:43 -0700 (PDT) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 391DE5F85F; Wed, 02 Sep 2026 14:20:42 +0100 (BST) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Gilles Grimaud Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org Subject: Re: [PATCH RFC v2 00/30] arm: add Raspberry Pi Pico/RP2040 machine In-Reply-To: <20260829234308.33725-1-gilles.grimaud@univ-lille.fr> (Gilles Grimaud's message of "Sun, 30 Aug 2026 01:42:34 +0200") References: <20260829234308.33725-1-gilles.grimaud@univ-lille.fr> User-Agent: mu4e 1.14.4-pre1; emacs 30.1 Date: Wed, 02 Sep 2026 14:20:42 +0100 Message-ID: <87ik4nrdqt.fsf@draig.linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Gilles Grimaud writes: > From: gilles grimaud > > This RFC adds a Raspberry Pi Pico / RP2040 machine to QEMU. > > The work continues the RP2040/Pico RFC posted by Alex Bennee in 2022: > > https://patchew.org/QEMU/20220110175104.2908956-1-alex.bennee%40linaro.= org/ > > The target is intended primarily for debugging bare-metal Pico firmware a= nd > for running firmware tests in CI without physical hardware. It provides a > functional, test-oriented model rather than a cycle-accurate RP2040 model. > > The machine supports two boot paths. The default synthetic ROM implements > the RP2040 boot protocol and selected ROM service tables, with optional > QEMU-accelerated helpers for firmware testing. Alternatively, users may > supply an RP2040 mask ROM image with -bios to exercise the modeled hardwa= re > path. QEMU does not ship that image, and USB BOOTSEL mass storage is not > currently supported. I've finished my first pass through, I'll re-review once you post v3. However some general points: - checkpatch everything - format commit messages - reduce duplication - ensure only one architectural features being modified per patch=20 I've also included our experimental AI reviewer so takes it's suggestions with a pinch of salt: https://patchpilot.linaro.org/run/b132da76b734#stage=3Dreview but it might be worth a read through none the less. > --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro