From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E47FDC44529 for ; Mon, 20 Jul 2026 19:37:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 640CD10E14E; Mon, 20 Jul 2026 19:37:50 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Df5Tcr3Q"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id F1C1A10E14E for ; Mon, 20 Jul 2026 19:37:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1784576239; x=1816112239; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=suzQGDhUwBHTNUcNoKna0r1lyt/Pv+fFsPkvUNPRLAU=; b=Df5Tcr3QELiRhr5TVedfFJEbLyYvo/d/4dJVlHh8MFigXuGeOHFRYTvx o0vGS0c0oF9UujCPzOrWdAM5vovv5aGgIJNmSf5DEcLygkmVQosbIvNki 8S0MJPtSBmMoH3nguqnDSzvi0KvwixA2+IBUnrgACC+hJSRuQBJm4PYba IY7mGHd8gxMg40ZjacPm+MSaiOKsh/d8GKRNVi+H6c1G/io9AFCa/WmMn jc5sB6WgujGhZJNAoZCvr4sIK1Jjvt8B+4Pb6dAl082452Z85QJpFIIPD k5t0kG+92IApa5a2F609+TGU5W47gynHMXZqqPKdc5qX8x8il7Pw3+PRZ Q==; X-CSE-ConnectionGUID: VLovKqUMQ3qZ7is9mRR9mA== X-CSE-MsgGUID: Y6elOhOGSK6GLFflgFphbg== X-IronPort-AV: E=McAfee;i="6800,10657,11852"; a="87704876" X-IronPort-AV: E=Sophos;i="6.25,175,1779174000"; d="scan'208";a="87704876" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2026 12:37:19 -0700 X-CSE-ConnectionGUID: ETbhGnQjRG+6lD6ulIvVrw== X-CSE-MsgGUID: HW19EWccSEKVJCCYXe36pA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,175,1779174000"; d="scan'208";a="282030767" Received: from oodele-mobl.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.65.76]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2026 12:37:18 -0700 Date: Mon, 20 Jul 2026 12:37:17 -0700 Message-ID: <87ik69xxjm.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: Subject: Re: [PATCH 1/4] tests/intel/xe_oa: Allow disabling load helper from command line In-Reply-To: <20260717210027.2008255-7-umesh.nerlige.ramappa@intel.com> References: <20260717210027.2008255-6-umesh.nerlige.ramappa@intel.com> <20260717210027.2008255-7-umesh.nerlige.ramappa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Fri, 17 Jul 2026 14:00:29 -0700, Umesh Nerlige Ramappa wrote: > > In some test runs, it is useful to assess behavior with and without load > helper. Add a command line switch to disable the load helper if needed. > > Signed-off-by: Umesh Nerlige Ramappa > --- > tests/intel/xe_oa.c | 29 +++++++++++++++++++++++++++-- > 1 file changed, 27 insertions(+), 2 deletions(-) > > diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c > index 68c7537d3888..e7e4f5601b61 100644 > --- a/tests/intel/xe_oa.c > +++ b/tests/intel/xe_oa.c > @@ -1798,10 +1798,14 @@ static struct load_helper { > bool exit; > struct igt_helper_process igt_proc; > struct intel_buf src, dst; > + bool disabled; > } lh = { 0, }; > > static void load_helper_signal_handler(int sig) > { > + if (lh.disabled) > + return; > + > if (sig == SIGUSR2) > lh.load = lh.load == LOW ? HIGH : LOW; > else > @@ -1812,6 +1816,9 @@ static void load_helper_set_load(enum load load) > { > igt_assert(lh.igt_proc.running); > > + if (lh.disabled) > + return; > + > if (lh.load == load) > return; > > @@ -1821,6 +1828,9 @@ static void load_helper_set_load(enum load load) > > static void load_helper_run(enum load load) > { > + if (lh.disabled) > + return; > + > if (!render_copy) > return; > > @@ -1856,6 +1866,9 @@ static void load_helper_run(enum load load) > > static void load_helper_stop(void) > { > + if (lh.disabled) > + return; > + > if (!render_copy) > return; > > @@ -1865,6 +1878,9 @@ static void load_helper_stop(void) > > static void load_helper_init(void) > { > + if (lh.disabled) > + return; > + > if (!render_copy) { > igt_info("Running test without render_copy\n"); > return; > @@ -1884,6 +1900,9 @@ static void load_helper_init(void) > > static void load_helper_fini(void) > { > + if (lh.disabled) > + return; > + > if (!render_copy) > return; nit: maybe we can combine the 'lh.disabled' check with the following '!render_copy' check and save some vertical real estate? But even otherwise this is: Reviewed-by: Ashutosh Dixit > @@ -4981,6 +5000,10 @@ static int opt_handler(int opt, int opt_index, void *data) > oa_trace = true; > igt_debug("Trace enabled\n"); > break; > + case 'd': > + lh.disabled = true; > + igt_info("Load helper disabled\n"); > + break; > default: > return IGT_OPT_HANDLER_ERROR; > } > @@ -4989,15 +5012,17 @@ static int opt_handler(int opt, int opt_index, void *data) > } > > static const char *help_str = " --trace | -t\t\tEnable ftrace\n" > - " --trace_buf_size_mb | -b\t\tSet ftrace buffer size in MB (default = 1, min = 1, max = 20)\n"; > + " --trace_buf_size_mb | -b\t\tSet ftrace buffer size in MB (default = 1, min = 1, max = 20)\n" > + " --disable-load-helper | -d\t\tDisable load helper\n"; > > static struct option long_options[] = { > {"trace", 0, 0, 't'}, > {"trace_buf_size_mb", 0, 0, 'b'}, > + {"disable-load-helper", 0, 0, 'd'}, > { NULL, 0, 0, 0 } > }; > > -int igt_main_args("b:t", long_options, help_str, opt_handler, NULL) > +int igt_main_args("b:td", long_options, help_str, opt_handler, NULL) > { > const struct sync_section { > const char *name; > -- > 2.51.0 >