From: Markus Armbruster <armbru@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Filip Hejsek <filip.hejsek@gmail.com>,
amit@kernel.org, berrange@redhat.com, eblake@redhat.com,
eduardo@habkost.net, lvivier@redhat.com,
marcandre.lureau@redhat.com, marcel.apfelbaum@gmail.com,
maxbr@linux.ibm.com, noh4hss@gmail.com, pbonzini@redhat.com,
philmd@linaro.org, qemu-devel@nongnu.org,
wangyanan55@huawei.com, zhao1.liu@intel.com
Subject: Re: [PATCH] qapi: drop "must exist" from ID descriptions for consistency
Date: Tue, 09 Jun 2026 15:00:21 +0200 [thread overview]
Message-ID: <87ik7rq36i.fsf@pond.sub.org> (raw)
In-Reply-To: <20260609063539-mutt-send-email-mst@kernel.org> (Michael S. Tsirkin's message of "Tue, 9 Jun 2026 06:36:02 -0400")
"Michael S. Tsirkin" <mst@redhat.com> writes:
> On Tue, Jun 09, 2026 at 12:34:03PM +0200, Markus Armbruster wrote:
>> Uh, this fell through the cracks, possibly because it was buried within
>> a thread.
>>
>> Filip Hejsek <filip.hejsek@gmail.com> writes:
>>
>> > Make chardev ID param descriptions more consistend with ID descriptions
>>
>> Typo: consistent
>>
>> Not worth a respin.
>>
>> > elsewhere.
>> > ---
>> > qapi/char.json | 6 +++---
>> > 1 file changed, 3 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/qapi/char.json b/qapi/char.json
>> > index 140614f82c..fbac5a1cb7 100644
>> > --- a/qapi/char.json
>> > +++ b/qapi/char.json
>> > @@ -791,7 +791,7 @@
>> > #
>> > # Change a character device backend
>> > #
>> > -# @id: the chardev's ID, must exist
>> > +# @id: the chardev's ID
>> > #
>> > # @backend: new backend type and parameters
>> > #
>> > @@ -832,7 +832,7 @@
>> > #
>> > # Remove a character device backend
>> > #
>> > -# @id: the chardev's ID, must exist and not be in use
>> > +# @id: the chardev's ID, must not be in use
>> > #
>> > # Since: 1.4
>> > #
>> > @@ -849,7 +849,7 @@
>> > #
>> > # Send a break to a character device
>> > #
>> > -# @id: the chardev's ID, must exist
>> > +# @id: the chardev's ID
>> > #
>> > # Since: 2.10
>> > #
>>
>> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>>
>> I can take this.
>
> maybe after it gets a signed off by tag from the author.
Oops, missed that! Can't take it without.
Filip?
next prev parent reply other threads:[~2026-06-09 13:00 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 3:27 [PATCH v6 00/12] virtio-console: notify about the terminal size Filip Hejsek
2026-01-19 3:27 ` [PATCH v6 01/12] chardev: add cols, rows fields Filip Hejsek
2026-01-19 3:27 ` [PATCH v6 02/12] chardev: add CHR_EVENT_RESIZE Filip Hejsek
2026-01-19 3:27 ` [PATCH v6 03/12] chardev: add qemu_chr_resize() Filip Hejsek
2026-01-19 3:27 ` [PATCH v6 04/12] char-mux: add support for the terminal size Filip Hejsek
2026-01-19 3:27 ` [PATCH v6 05/12] main-loop: change the handling of SIGWINCH Filip Hejsek
2026-01-19 3:27 ` [PATCH v6 06/12] char-stdio: add support for the terminal size Filip Hejsek
2026-01-19 3:27 ` [PATCH v6 07/12] qmp: add chardev-window-size-changed command Filip Hejsek
2026-01-19 6:47 ` Markus Armbruster
2026-01-20 8:04 ` Filip Hejsek
2026-01-20 8:18 ` [PATCH] qapi: drop "must exist" from ID descriptions for consistency Filip Hejsek
2026-06-09 10:34 ` Markus Armbruster
2026-06-09 10:36 ` Michael S. Tsirkin
2026-06-09 13:00 ` Markus Armbruster [this message]
2026-06-09 13:04 ` Markus Armbruster
2026-01-19 3:27 ` [PATCH v6 08/12] virtio-serial-bus: add terminal resize messages Filip Hejsek
2026-01-19 9:38 ` Daniel P. Berrangé
2026-01-19 9:43 ` Michael S. Tsirkin
2026-01-20 8:43 ` Daniel P. Berrangé
2026-01-20 9:16 ` Filip Hejsek
2026-01-20 12:56 ` Michael S. Tsirkin
2026-01-20 9:50 ` Filip Hejsek
2026-01-20 9:54 ` Daniel P. Berrangé
2026-01-20 10:07 ` Filip Hejsek
2026-01-20 10:10 ` Daniel P. Berrangé
2026-01-20 10:16 ` Filip Hejsek
2026-01-20 10:20 ` Daniel P. Berrangé
2026-01-20 10:22 ` Filip Hejsek
2026-01-20 10:28 ` Filip Hejsek
2026-01-20 12:58 ` Michael S. Tsirkin
2026-01-19 3:27 ` [PATCH v6 09/12] virtio-console: notify the guest about terminal resizes Filip Hejsek
2026-01-19 3:27 ` [PATCH v6 10/12] char-win-stdio: add support for terminal size Filip Hejsek
2026-01-19 3:27 ` [PATCH v6 11/12] ui/console-vc: forward text console size to vc chardev Filip Hejsek
2026-01-19 3:27 ` [PATCH v6 12/12] ui/gtk: forward gtk " Filip Hejsek
2026-06-09 8:02 ` [PATCH v6 00/12] virtio-console: notify about the terminal size Maximilian Immanuel Brandtner
2026-06-09 8:09 ` Michael S. Tsirkin
2026-06-09 8:26 ` Maximilian Immanuel Brandtner
2026-06-09 11:13 ` Filip Hejsek
2026-06-09 11:38 ` Maximilian Immanuel Brandtner
2026-06-09 12:10 ` Filip Hejsek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ik7rq36i.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=amit@kernel.org \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=filip.hejsek@gmail.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=maxbr@linux.ibm.com \
--cc=mst@redhat.com \
--cc=noh4hss@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=wangyanan55@huawei.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.