Re: [PATCH i-g-t] include/drm-uapi/xe_drm: Add srcid to drm_xe_fault struct

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Wed, 03 Jun 2026 10:22:41 -0700, Dixit, Ashutosh wrote:
>
> On Wed, 03 Jun 2026 08:01:22 -0700, Jonathan Cavitt wrote:
> >
> > Add srcid to drm_xe_fault struct, aligning with a KMD change.
> > Additionally, add logging for the new information to the associated
> > xe_vm test.
>
> Please follow the format of previous commit messages to
> include/drm-uapi/xe_drm.h and include the kernel commit sha
> include/drm-uapi/xe_drm.h is being sync'd till.

What I mean is, no point sending the IGT patch for this till the kernel
patch is merged, anyway 'Test-with' doesn't work for Xe. And, after kernel
patch is merged, rather than just this change, the IGT uapi header should
be sync'd with the kernel uapi header using

	make INSTALL_HDR_PATH=<dest-dir> headers_install

>
> >
> > Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> > Cc: Michal Mrozek <michal.mrozek@intel.com>
> > ---
> >  include/drm-uapi/xe_drm.h | 4 ++--
> >  tests/intel/xe_vm.c       | 1 +
> >  2 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/drm-uapi/xe_drm.h b/include/drm-uapi/xe_drm.h
> > index 5a96a7910b..273bac9e1f 100644
> > --- a/include/drm-uapi/xe_drm.h
> > +++ b/include/drm-uapi/xe_drm.h
> > @@ -1290,8 +1290,8 @@ struct xe_vm_fault {
> >  #define FAULT_LEVEL_PML4	3
> >  #define FAULT_LEVEL_PML5	4
> >	__u8 fault_level;
> > -	/** @pad: MBZ */
> > -	__u8 pad;
> > +	/** @srcid: ID of the faulting hardware unit */
> > +	__u8 srcid;
> >	/** @reserved: MBZ */
> >	__u64 reserved[4];
> >  };
> > diff --git a/tests/intel/xe_vm.c b/tests/intel/xe_vm.c
> > index 408bfdb718..260dae9cae 100644
> > --- a/tests/intel/xe_vm.c
> > +++ b/tests/intel/xe_vm.c
> > @@ -3023,6 +3023,7 @@ static void print_pf(struct xe_vm_fault *fault)
> >	igt_debug("access type = %u\n", fault->access_type);
> >	igt_debug("fault type = %u\n", fault->fault_type);
> >	igt_debug("fault level = %u\n", fault->fault_level);
> > +	igt_debug("srcid = 0x%08x\n", fault->srcid);
> >	igt_debug("\n");
> >  }
> >
> > --
> > 2.53.0
> >