From: Nam Cao <namcao@linutronix.de>
To: Gabriele Monaco <gmonaco@redhat.com>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Gabriele Monaco <gmonaco@redhat.com>,
linux-trace-kernel@vger.kernel.org
Cc: Wen Yang <wen.yang@linux.dev>
Subject: Re: [PATCH v2 03/12] rv: Reset per-task DA monitors before releasing the slot
Date: Thu, 28 May 2026 10:48:13 +0200 [thread overview]
Message-ID: <87ik87or76.fsf@yellow.woof> (raw)
In-Reply-To: <20260527062313.39908-4-gmonaco@redhat.com>
Gabriele Monaco <gmonaco@redhat.com> writes:
> Per-task monitors use task_mon_slot to determine which slot in the array
> to use for the monitor. During destruction, this slot is returned but
> this is done before resetting the monitor. As a result, the monitor's
> reset is in fact resetting a slot that is outside of the array
> (RV_PER_TASK_MONITOR_INIT).
Oh crap.
> Release the slot only after the reset to avoid out-of-bound memory
> access.
I think KASAN can catch this type of issue.
> Fixes: f5587d1b6ec93 ("rv: Add Hybrid Automata monitor type")
> Suggested-by: Wen Yang <wen.yang@linux.dev>
> Reviewed-by: Wen Yang <wen.yang@linux.dev>
> Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
Should we have
Cc: stable@vger.kernel.org
?
Reviewed-by: Nam Cao <namcao@linutronix.de>
next prev parent reply other threads:[~2026-05-28 8:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 6:23 [PATCH v2 00/12] rv: Fixes on Deterministic and Hybrid Automata Gabriele Monaco
2026-05-27 6:23 ` [PATCH v2 01/12] rv: Fix __user specifier usage in extract_params() Gabriele Monaco
2026-05-28 8:38 ` Nam Cao
2026-05-27 6:23 ` [PATCH v2 02/12] rv: Fix read_lock scope in per-task DA cleanup Gabriele Monaco
2026-05-28 8:43 ` Nam Cao
2026-05-29 6:08 ` Gabriele Monaco
2026-05-27 6:23 ` [PATCH v2 03/12] rv: Reset per-task DA monitors before releasing the slot Gabriele Monaco
2026-05-28 8:48 ` Nam Cao [this message]
2026-05-27 6:23 ` [PATCH v2 04/12] rv: Prevent task migration while handling per-CPU events Gabriele Monaco
2026-05-28 8:56 ` Nam Cao
2026-05-27 6:23 ` [PATCH v2 05/12] rv: Prevent in-flight per-task handlers from using invalid slots Gabriele Monaco
2026-05-28 8:59 ` Nam Cao
2026-05-27 6:23 ` [PATCH v2 06/12] rv: Ensure all pending probes terminate on per-obj monitor destroy Gabriele Monaco
2026-05-28 9:01 ` Nam Cao
2026-05-27 6:23 ` [PATCH v2 07/12] rv: Fix monitor start ordering and memory ordering for monitoring flag Gabriele Monaco
2026-05-28 9:09 ` Nam Cao
2026-05-31 14:54 ` Wen Yang
2026-05-27 6:23 ` [PATCH v2 08/12] rv: Ensure synchronous cleanup for HA monitors Gabriele Monaco
2026-05-27 6:23 ` [PATCH v2 09/12] rv: Do not rely on clean monitor when initialising HA Gabriele Monaco
2026-05-27 6:23 ` [PATCH v2 10/12] rv: Add automatic cleanup handlers for per-task HA monitors Gabriele Monaco
2026-05-27 6:23 ` [PATCH v2 11/12] verification/rvgen: Generate cleanup hook for per-obj monitor Gabriele Monaco
2026-05-27 6:23 ` [PATCH v2 12/12] verification/rvgen: Fix suffix strip in dot2k Gabriele Monaco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ik87or76.fsf@yellow.woof \
--to=namcao@linutronix.de \
--cc=gmonaco@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=wen.yang@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.