From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 676B6D5C0CD for ; Tue, 16 Dec 2025 08:06:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T7W4/s5Ph0Uvbv8iOfrt2xlNHJY8eAULTOB6D8rjtg0=; b=B3wQv1vnklU8E8 2eYj9R6EFBfabSU33EPqt6j0OO7v7ivQvd3cLCk8QU8K7Wzzgc5zs9hN4f3VMJoEQf3zpoSyzGvd3 BCNEU+xqCaReT0oV4qWl9zLAeeHi7POlgStoN0CMi99TpaQJ6Ao8jQDZNpVHQhes8jpydTJabcKhz WK4fHk+Z9yUobrcV2yQoy1mW7ZA+tBDSgy2xYxjUEZ5aJq3dAVhTlcJHKY+Zl3qF42F/745v3E039 NpNE5HRf+H2Wiwuc6wMXPb4TtNFcQ/G1/rwV5Wls6z7AhtSaxRGkwPNlRHMYm1l0u2XXiaJ/ON2Ex ZpyyY/o5wolCvstfYvFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vVQ4p-00000004tdD-1QGb; Tue, 16 Dec 2025 08:06:35 +0000 Received: from smtpout-03.galae.net ([185.246.85.4]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vVQ4f-00000004tc4-2fk4 for linux-mtd@lists.infradead.org; Tue, 16 Dec 2025 08:06:33 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id A39704E41B69; Tue, 16 Dec 2025 08:06:20 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 71CAA6071C; Tue, 16 Dec 2025 08:06:20 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id E92E511942F8B; Tue, 16 Dec 2025 09:06:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1765872379; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=mnPu3NaHdaqZPL8dQQmj9+t+nxocDNQkhh5BcD8Z/gI=; b=HrcE/nmsHuBxRg2BtHY9NPWXttK4ycNK2CvFdTGa2R3FroXElfzg5ZvWPL/4BiQekvC5zd bGT3OZI2CcuwwoexfBDYLj+nxU/QLg3zWYLKTFBqYyfH85uFF158xWpWMlxH9BQgnwT0ET aTZcvpeiV/BZlvvBpNsjwFNqbiE3xGCT6mlTNv7R0mmdWX+9zB7S80Q2cxDbVmYN6oOMSe ZeaISxFdLt4fuawXDCyfFiTuS0IyaqwhTTB2tRd3b0rZ78FJDMH2Qd0onE4wir9NlPlBvG 8LUZSbExXljzhDu3w69RenFt8KtvHJlATSxCEzTLHiYA0O1FkQ6DNI+triLHhg== From: Miquel Raynal To: Dharanitharan R Cc: Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] mtd: sm_ftl: use strscpy() in sm_attr_show() In-Reply-To: <20251206035313.10190-1-dharanitharan725@gmail.com> (Dharanitharan R.'s message of "Sat, 6 Dec 2025 03:53:13 +0000") References: <20251206035313.10190-1-dharanitharan725@gmail.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Tue, 16 Dec 2025 09:06:16 +0100 Message-ID: <87ike6svev.fsf@bootlin.com> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251216_000625_815406_B297AF1F X-CRM114-Status: UNSURE ( 9.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGVsbG8sCgpPbiAwNi8xMi8yMDI1IGF0IDAzOjUzOjEzIEdNVCwgRGhhcmFuaXRoYXJhbiBSIDxk aGFyYW5pdGhhcmFuNzI1QGdtYWlsLmNvbT4gd3JvdGU6Cgo+IEluIHNtX2Z0bC5jLCB0aGUgc21f YXR0cl9zaG93KCkgZnVuY3Rpb24gY3VycmVudGx5IGNvcGllcwo+IGF0dHJpYnV0ZSBkYXRhIHVz aW5nOgo+Cj4gICAgIHN0cm5jcHkoYnVmLCBzbV9hdHRyLT5kYXRhLCBzbV9hdHRyLT5sZW4pOwo+ ICAgICByZXR1cm4gc21fYXR0ci0+bGVuOwo+Cj4gVXNpbmcgc3RybmNweSgpIGNhbiBiZSB1bnNh ZmUgYmVjYXVzZSBpdCBkb2VzIG5vdCBndWFyYW50ZWUKPiBhIE5VTCB0ZXJtaW5hdG9yIGlmIHRo ZSBzb3VyY2UgbGVuZ3RoIGVxdWFscyB0aGUgYnVmZmVyIHNpemUuCj4gQWx0aG91Z2ggc21fYXR0 ci0+ZGF0YSBjb21lcyBmcm9tIGludGVybmFsIHN0cnVjdHVyZXMgYW5kCj4gaXMgTlVMLXRlcm1p bmF0ZWQsIGl0IGlzIGNsZWFuZXIgYW5kIHNhZmVyIHRvIHVzZSBzdHJzY3B5KCksCj4gd2hpY2gg Z3VhcmFudGVlcyBOVUwgdGVybWluYXRpb24gYW5kIGF2b2lkcyB6ZXJvLXBhZGRpbmcuCj4KPiBU aGUgZGVzdGluYXRpb24gYnVmZmVyIGlzIFBBR0VfU0laRSBieXRlcywgd2hpY2ggaXMgc3VmZmlj aWVudAo+IHRvIGhvbGQgc21fYXR0ci0+ZGF0YSB3aXRob3V0IHRydW5jYXRpb24uIFRoZSByZXR1 cm4gdmFsdWUKPiBvZiBzdHJzY3B5KCkgbWF0Y2hlcyB0aGUgZXhwZWN0ZWQgYmVoYXZpb3Igb2Yg c21fYXR0cl9zaG93KCkuCj4KPiBSZXBsYWNlIHRoZSBzdHJuY3B5KCkgY2FsbCB3aXRoOgo+Cj4g ICAgIHJldHVybiBzdHJzY3B5KGJ1Ziwgc21fYXR0ci0+ZGF0YSwgUEFHRV9TSVpFKTsKPgo+IFNp Z25lZC1vZmYtYnk6IERoYXJhbml0aGFyYW4gUiA8ZGhhcmFuaXRoYXJhbjcyNUBnbWFpbC5jb20+ CgpUaGlzIGNvbW1pdCB3b24ndCBhcHBseSwgcGxlYXNlIHJlc2VuZCBiYXNlZCBvbiB2Ni4xOS1y YzEuCgpUaGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 682F934A791 for ; Tue, 16 Dec 2025 08:06:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765872385; cv=none; b=gT7pQoPDYomqOjECg0OB8AYmO6ah44ugBvOeP8Qv2RWZcGPZd9ZkXTMiHlVjnpAy6pqKAf2cj3JiXeyduGKvP7KaN9S8reZ0UM8AjrajVLpW0Y/WA306vCiiYON+M17s1PuKiVPeSg8ufcKCnqVhafDVTip3u8yD/KneJs0oAc8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765872385; c=relaxed/simple; bh=/hrjUDBbbuI6vOCBtbC+KchTw3oKYN4ZNb1kUjcOJb0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=maFPmInIalH0P6vn3nQW6xCQZZ5iHk6eqIOMwR54cim0Y0spnrtabYbt7EAxCEng0i4yXE7FsBJjIMlLwjqkPSy4yFgythr/KGXYfWFdVmucfNwzNXr7cLeR+eL0+8+GQKpMPUTGLQdTODH1SMN1n3GFeY/p1rdbiCqKdi+OHAU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=HrcE/nms; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="HrcE/nms" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id A39704E41B69; Tue, 16 Dec 2025 08:06:20 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 71CAA6071C; Tue, 16 Dec 2025 08:06:20 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id E92E511942F8B; Tue, 16 Dec 2025 09:06:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1765872379; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=mnPu3NaHdaqZPL8dQQmj9+t+nxocDNQkhh5BcD8Z/gI=; b=HrcE/nmsHuBxRg2BtHY9NPWXttK4ycNK2CvFdTGa2R3FroXElfzg5ZvWPL/4BiQekvC5zd bGT3OZI2CcuwwoexfBDYLj+nxU/QLg3zWYLKTFBqYyfH85uFF158xWpWMlxH9BQgnwT0ET aTZcvpeiV/BZlvvBpNsjwFNqbiE3xGCT6mlTNv7R0mmdWX+9zB7S80Q2cxDbVmYN6oOMSe ZeaISxFdLt4fuawXDCyfFiTuS0IyaqwhTTB2tRd3b0rZ78FJDMH2Qd0onE4wir9NlPlBvG 8LUZSbExXljzhDu3w69RenFt8KtvHJlATSxCEzTLHiYA0O1FkQ6DNI+triLHhg== From: Miquel Raynal To: Dharanitharan R Cc: Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] mtd: sm_ftl: use strscpy() in sm_attr_show() In-Reply-To: <20251206035313.10190-1-dharanitharan725@gmail.com> (Dharanitharan R.'s message of "Sat, 6 Dec 2025 03:53:13 +0000") References: <20251206035313.10190-1-dharanitharan725@gmail.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Tue, 16 Dec 2025 09:06:16 +0100 Message-ID: <87ike6svev.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hello, On 06/12/2025 at 03:53:13 GMT, Dharanitharan R = wrote: > In sm_ftl.c, the sm_attr_show() function currently copies > attribute data using: > > strncpy(buf, sm_attr->data, sm_attr->len); > return sm_attr->len; > > Using strncpy() can be unsafe because it does not guarantee > a NUL terminator if the source length equals the buffer size. > Although sm_attr->data comes from internal structures and > is NUL-terminated, it is cleaner and safer to use strscpy(), > which guarantees NUL termination and avoids zero-padding. > > The destination buffer is PAGE_SIZE bytes, which is sufficient > to hold sm_attr->data without truncation. The return value > of strscpy() matches the expected behavior of sm_attr_show(). > > Replace the strncpy() call with: > > return strscpy(buf, sm_attr->data, PAGE_SIZE); > > Signed-off-by: Dharanitharan R This commit won't apply, please resend based on v6.19-rc1. Thanks, Miqu=C3=A8l