All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Zhao Liu <zhao1.liu@intel.com>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	qemu-devel@nongnu.org, devel@lists.libvirt.org
Subject: Re: [PATCH] docs/deprecated: Remove undeprecated SMP description
Date: Fri, 21 Nov 2025 09:45:33 +0100	[thread overview]
Message-ID: <87ikf3ojte.fsf@pond.sub.org> (raw)
In-Reply-To: <20251121084416.1031466-1-zhao1.liu@intel.com> (Zhao Liu's message of "Fri, 21 Nov 2025 16:44:16 +0800")

Zhao Liu <zhao1.liu@intel.com> writes:

> "Unsupported 'parameter=1' SMP configuration" was proposed to be
> deprecated in the commit 54c4ea8f3ae6 ("hw/core/machine-smp: Deprecate
> unsupported "parameter=1" SMP configurations").
>
> But the related code was reverted later in the commit 9d7950edb0cd
> ("hw/core: allow parameter=1 for SMP topology on any machine").
>
> Thus, this SMP behavior is still valid and is not actually deprecated.
>
> Remove outdated document descriptions.
>
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
>  docs/about/deprecated.rst | 14 --------------
>  1 file changed, 14 deletions(-)
>
> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> index 03e29915f0aa..bbfcce4a1ab3 100644
> --- a/docs/about/deprecated.rst
> +++ b/docs/about/deprecated.rst
> @@ -54,20 +54,6 @@ as short-form boolean values, and passed to plugins as ``arg_name=on``.
>  However, short-form booleans are deprecated and full explicit ``arg_name=on``
>  form is preferred.
>  
> -``-smp`` (Unsupported "parameter=1" SMP configurations) (since 9.0)
> -'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
> -
> -Specified CPU topology parameters must be supported by the machine.
> -
> -In the SMP configuration, users should provide the CPU topology parameters that
> -are supported by the target machine.
> -
> -However, historically it was allowed for users to specify the unsupported
> -topology parameter as "1", which is meaningless. So support for this kind of
> -configurations (e.g. -smp drawers=1,books=1,clusters=1 for x86 PC machine) is
> -marked deprecated since 9.0, users have to ensure that all the topology members
> -described with -smp are supported by the target machine.
> -
>  QEMU Machine Protocol (QMP) commands
>  ------------------------------------

Reviewed-by: Markus Armbruster <armbru@redhat.com>



  reply	other threads:[~2025-11-21  8:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-21  8:44 [PATCH] docs/deprecated: Remove undeprecated SMP description Zhao Liu
2025-11-21  8:45 ` Markus Armbruster [this message]
2025-11-25 21:50 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ikf3ojte.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=devel@lists.libvirt.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.