All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/xinetd: bump version to 2.3.15.4
Date: Wed, 19 Nov 2025 06:55:09 +0200	[thread overview]
Message-ID: <87ikf6wriq.fsf@tarshish> (raw)
In-Reply-To: <20251118211149.2013582-1-bernd@kuhls.net> (Bernd Kuhls's message of "Tue, 18 Nov 2025 22:11:49 +0100")

Hi Bernd,

On Tue, Nov 18 2025, Bernd Kuhls wrote:
> Switched to maintained fork:
> https://github.com/xinetd-org/xinetd/issues/30
>
> Removed all patches, they are either included in this release or not
> needed anymore.
>
> uClibc builds are broken due to missing ecvt/fcvt functions:
> https://cgit.uclibc-ng.org/cgi/cgit/uclibc-ng.git/tree/include/stdlib.h?h=v1.0.55#n830
> needed by
> https://github.com/openSUSE/xinetd/blob/master/src/sio/sprint.c#L176
>
> Added -std=gnu17 to CFLAGS as per upstream recommendation to fix build
> errors with newer gcc: https://github.com/openSUSE/xinetd/issues/49
>
> Fixes:
> https://autobuild.buildroot.net/results/399/399108140f1932e867e2907c5fa1be2add53beab/
>
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---

...

> diff --git a/package/xinetd/xinetd.mk b/package/xinetd/xinetd.mk
> index f63a8a2251..1542e44b6b 100644
> --- a/package/xinetd/xinetd.mk
> +++ b/package/xinetd/xinetd.mk
> @@ -4,18 +4,25 @@
>  #
>  ################################################################################
>  
> -XINETD_VERSION = 2.3.15
> -XINETD_SITE = \
> -	$(call github,xinetd-org,xinetd,xinetd-$(subst .,-,$(XINETD_VERSION)))
> +XINETD_VERSION = 2.3.15.4
> +XINETD_SOURCE = xinetd-$(XINETD_VERSION).tar.xz
> +XINETD_SITE = https://github.com/openSUSE/xinetd/releases/download/$(XINETD_VERSION)
>  XINETD_LICENSE = xinetd license
>  XINETD_LICENSE_FILES = COPYRIGHT
>  XINETD_CPE_ID_VENDOR = xinetd
>  
> -# 0005-CVE-2013-4342-xinetd-ignores-user-and-group-directiv.patch
> +# https://github.com/openSUSE/xinetd/commit/91e2401a219121eae15244a6b25d2e79c1af5864
>  XINETD_IGNORE_CVES += CVE-2013-4342

If this CVE is fixed in 2.3.15.4, why do we need to keep IGNORE it?

baruch

>  
>  XINETD_CFLAGS = $(TARGET_CFLAGS)
>  
> +# gcc-15 defaults to -std=gnu23 which introduces build failures.
> +# We force "-std=gnu17" for gcc version supporting it. Earlier gcc
> +# versions will work, since they are using the older standard.
> +ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_8),y)
> +XINETD_CFLAGS += -std=gnu17
> +endif
> +
>  # Three cases here:
>  #  1. We have libtirpc, use it by passing special flags
>  #  2. We have native RPC support, use it, no need to pass special

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2025-11-19  5:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-18 21:11 [Buildroot] [PATCH 1/1] package/xinetd: bump version to 2.3.15.4 Bernd Kuhls
2025-11-19  4:55 ` Baruch Siach via buildroot [this message]
     [not found] ` <87ikf6wriq.fsf__24259.6589656145$1763528538$gmane$org@tarshish>
2025-11-19  7:42   ` Bernd Kuhls
2025-11-19  8:52     ` Baruch Siach via buildroot
2026-01-01 15:49 ` Thomas Petazzoni via buildroot
2026-01-13 19:47 ` Arnout Vandecappelle via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ikf6wriq.fsf@tarshish \
    --to=buildroot@buildroot.org \
    --cc=baruch@tkos.co.il \
    --cc=bernd@kuhls.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.