From: Fabiano Rosas <farosas@suse.de>
To: Bernhard Beschow <shentey@gmail.com>, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Eduardo Habkost <eduardo@habkost.net>,
John Snow <jsnow@redhat.com>, Laurent Vivier <laurent@vivier.eu>,
kvm@vger.kernel.org, Zhao Liu <zhao1.liu@intel.com>,
qemu-trivial@nongnu.org,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Sunil Muthuswamy <sunilmut@microsoft.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Michael Tokarev <mjt@tls.msk.ru>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-block@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Bernhard Beschow <shentey@gmail.com>
Subject: Re: [PATCH 8/8] tests/qtest/ds1338-test: Reuse from_bcd()
Date: Tue, 21 Oct 2025 17:57:20 -0300 [thread overview]
Message-ID: <87ikg8t1lb.fsf@suse.de> (raw)
In-Reply-To: <20251017113338.7953-9-shentey@gmail.com>
Bernhard Beschow <shentey@gmail.com> writes:
> from_bcd() is a public API function which can be unit-tested. Reuse it to avoid
> code duplication.
>
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
prev parent reply other threads:[~2025-10-21 20:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 11:33 [PATCH 0/8] Trivial patches, mostly PC-related Bernhard Beschow
2025-10-17 11:33 ` [PATCH 1/8] hw/timer/i8254: Add I/O trace events Bernhard Beschow
2025-10-17 11:33 ` [PATCH 2/8] hw/audio/pcspk: " Bernhard Beschow
2025-10-17 11:33 ` [PATCH 3/8] hw/rtc/mc146818rtc: Convert CMOS_DPRINTF() into " Bernhard Beschow
2025-10-17 11:33 ` [PATCH 4/8] hw/rtc/mc146818rtc: Use ARRAY_SIZE macro Bernhard Beschow
2025-10-17 11:33 ` [PATCH 5/8] hw/rtc/mc146818rtc: Assert correct usage of mc146818rtc_set_cmos_data() Bernhard Beschow
2025-10-17 11:33 ` [PATCH 6/8] hw/i386/apic: Prefer APICCommonState over DeviceState Bernhard Beschow
2025-10-17 11:33 ` [PATCH 7/8] hw/ide/ide-internal: Move dma_buf_commit() into ide "namespace" Bernhard Beschow
2025-10-17 11:33 ` [PATCH 8/8] tests/qtest/ds1338-test: Reuse from_bcd() Bernhard Beschow
2025-10-21 20:57 ` Fabiano Rosas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ikg8t1lb.fsf@suse.de \
--to=farosas@suse.de \
--cc=eduardo@habkost.net \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=laurent@vivier.eu \
--cc=lvivier@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shentey@gmail.com \
--cc=sunilmut@microsoft.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.