Re: [PATCH] block: enable stats-intervals for virtio-blk devs with -blockdev

[Markus Armbruster <armbru@redhat.com>]

Kevin Wolf <kwolf@redhat.com> writes:

> Am 30.09.2025 um 01:52 hat Chandan geschrieben:
>> This patch allows the stats-intervals.* flag to be used with
>> -blockdev. Stats collection is initialized for virtio-blk devices
>> at their time of creation. However, it is limited to just virtio-blk
>> devices for now.
>> 
>> Signed-off-by: Chandan <csomani@redhat.com>

[...]

>>  struct BlockBackendRootState {
>> diff --git a/qapi/block-core.json b/qapi/block-core.json
>> index dc6eb4ae23..dbb53296b1 100644
>> --- a/qapi/block-core.json
>> +++ b/qapi/block-core.json
>> @@ -4771,6 +4771,9 @@
>>  # @force-share: force share all permission on added nodes.  Requires
>>  #     read-only=true.  (Since 2.10)
>>  #
>> +# @stats-intervals: #optional list of intervals for collecting I/O
>> +#                   statistics, in seconds (default: none)
>
> #optional is not a marker that is used anywhere else.

Because it gets rendered like this:

      * stats-intervals ([int], *optional*) -- #optional list of
        intervals for collecting I/O statistics, in seconds (default:
        none)

Drop it, please.

[...]