All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Tom Rini <trini@konsulko.com>, u-boot@lists.denx.de
Cc: Marek Vasut <marek.vasut@mailbox.org>
Subject: Re: [PATCH v2 5/5] usb: gadget: Tighten CI_UDC dependencies
Date: Tue, 30 Sep 2025 11:30:25 +0200	[thread overview]
Message-ID: <87ikh0i8y6.fsf@kernel.org> (raw)
In-Reply-To: <20250926153034.3680674-5-trini@konsulko.com>

Hi Tom,

Thank you for the patch.

On Fri, Sep 26, 2025 at 09:30, Tom Rini <trini@konsulko.com> wrote:

> This driver cannot build when DM_USB_GADGET is enabled as both options
> control building of files that use the same global namespace and
> functionality. In this case make CI_UDC depend on DM_USB_GADGET being
> disabled as non-DM support is the legacy choice.
>
> Signed-off-by: Tom Rini <trini@konsulko.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>

> ---
> Changes in v2:
> - None
>
> Cc: Marek Vasut <marek.vasut@mailbox.org>
> ---
>  drivers/usb/gadget/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index 9065e14768ad..9f817967a08b 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -152,6 +152,7 @@ config USB_GADGET_OS_DESCRIPTORS
>  
>  config CI_UDC
>  	bool "ChipIdea device controller"
> +	depends on !DM_USB_GADGET
>  	select USB_GADGET_DUALSPEED
>  	help
>  	  Say Y here to enable device controller functionality of the
> -- 
> 2.43.0

      reply	other threads:[~2025-09-30  9:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-26 15:30 [PATCH v2 1/5] omap3: evm: Drop old musb omap3 driver Tom Rini
2025-09-26 15:30 ` [PATCH v2 2/5] usb: musb: drop musb legacy drivers Tom Rini
2025-09-26 15:30 ` [PATCH v2 3/5] usb: gadget: Tighten the dependency for DWC2 OTG support Tom Rini
2025-09-26 15:44   ` Peter Robinson
2025-09-30  9:28   ` Mattijs Korpershoek
2025-09-26 15:30 ` [PATCH v2 4/5] usb: host: xhci: Make U_BOOT_DRIVER entries unique Tom Rini
2025-09-26 15:46   ` Peter Robinson
2025-09-26 15:30 ` [PATCH v2 5/5] usb: gadget: Tighten CI_UDC dependencies Tom Rini
2025-09-30  9:30   ` Mattijs Korpershoek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ikh0i8y6.fsf@kernel.org \
    --to=mkorpershoek@kernel.org \
    --cc=marek.vasut@mailbox.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.