From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36B2DC87FD3 for ; Fri, 8 Aug 2025 11:14:55 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ukL35-0003XM-Dp; Fri, 08 Aug 2025 07:14:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ukL32-0003W2-1r for qemu-devel@nongnu.org; Fri, 08 Aug 2025 07:14:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ukL2z-0008PE-7n for qemu-devel@nongnu.org; Fri, 08 Aug 2025 07:14:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754651643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jbQGWc9WVN9EY2IAWnh2yFX3n5c46uOrzpXexWWwoiY=; b=fGjDk1RGQ7+8F+BthJem1naKDEjFGoGtkpP9Uhel3SBbPJjh0xg9duysNG0qQDO9arPhJR ljJ53kjvoAWTbUq7AvnTkklAtQlLYZf5URsi7VYlHb41ZPL/myzOzrv2hfA2dwEX8geK8A XjZ9BBz+0bsfUayulwzZZJpnu0+cGko= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-221-vuqc-hh3Ng6oldFhaUKUBg-1; Fri, 08 Aug 2025 07:13:59 -0400 X-MC-Unique: vuqc-hh3Ng6oldFhaUKUBg-1 X-Mimecast-MFC-AGG-ID: vuqc-hh3Ng6oldFhaUKUBg_1754651639 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BC4D619560AD; Fri, 8 Aug 2025 11:13:58 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.18]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 738441800295; Fri, 8 Aug 2025 11:13:58 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 8E1DD21E6A27; Fri, 08 Aug 2025 13:13:55 +0200 (CEST) From: Markus Armbruster To: Jonathan Cameron Cc: , , Subject: Re: [PATCH 03/12] hw/cxl: Convert cxl_fmws_link() to Error In-Reply-To: <20250808114442.0000234d@huawei.com> (Jonathan Cameron's message of "Fri, 8 Aug 2025 11:44:42 +0100") References: <20250808080823.2638861-1-armbru@redhat.com> <20250808080823.2638861-4-armbru@redhat.com> <20250808114442.0000234d@huawei.com> Date: Fri, 08 Aug 2025 13:13:55 +0200 Message-ID: <87ikiygj64.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Jonathan Cameron writes: > On Fri, 8 Aug 2025 10:08:14 +0200 > Markus Armbruster wrote: > >> Functions that use an Error **errp parameter to return errors should >> not also report them to the user, because reporting is the caller's >> job. When the caller does, the error is reported twice. When it >> doesn't (because it recovered from the error), there is no error to >> report, i.e. the report is bogus. >> >> cxl_fmws_link_targets() violates this principle: it calls >> error_setg(&error_fatal, ...) via cxl_fmws_link(). Goes back to >> commit 584f722eb3ab (hw/cxl: Make the CXL fixed memory windows >> devices.) Currently harmless, because cxl_fmws_link_targets()'s >> callers always pass &error_fatal. Clean this up by converting >> cxl_fmws_link() to Error. > > Patch is definitely an improvement though I'm no sure how > it is really a violation of the above principle given > it has no effect on being called twice for example. Note I wrote "Clean this up", not "fix this" :) This is actually a canned commit message I've been using with suitable adjustments for similar patches: commit b765d21e4ab, 35b1561e3ec, e6696d3ee9b, 07d5b946539, ... >> Cc: Jonathan Cameron >> Signed-off-by: Markus Armbruster > > The -1 return is perhaps unrelated to the main thing here, > but does make more sense than return 1 so fair enough. Accident, will back it out. > None of the above comments I've raised are that important to me though. > > Reviewed-by: Jonathan Cameron Thanks! >> --- >> hw/cxl/cxl-host.c | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/hw/cxl/cxl-host.c b/hw/cxl/cxl-host.c >> index 5c2ce25a19..0d891c651d 100644 >> --- a/hw/cxl/cxl-host.c >> +++ b/hw/cxl/cxl-host.c >> @@ -72,6 +72,7 @@ static void cxl_fixed_memory_window_config(CXLFixedMemoryWindowOptions *object, >> >> static int cxl_fmws_link(Object *obj, void *opaque) >> { >> + Error **errp = opaque; >> struct CXLFixedWindow *fw; >> int i; >> >> @@ -87,9 +88,9 @@ static int cxl_fmws_link(Object *obj, void *opaque) >> o = object_resolve_path_type(fw->targets[i], TYPE_PXB_CXL_DEV, >> &ambig); >> if (!o) { >> - error_setg(&error_fatal, "Could not resolve CXLFM target %s", >> + error_setg(errp, "Could not resolve CXLFM target %s", >> fw->targets[i]); >> - return 1; >> + return -1; This line is the accident. >> } >> fw->target_hbs[i] = PXB_CXL_DEV(o); >> } >> @@ -99,7 +100,7 @@ static int cxl_fmws_link(Object *obj, void *opaque) >> void cxl_fmws_link_targets(Error **errp) >> { >> /* Order doesn't matter for this, so no need to build list */ >> - object_child_foreach_recursive(object_get_root(), cxl_fmws_link, NULL); >> + object_child_foreach_recursive(object_get_root(), cxl_fmws_link, errp); >> } >> >> static bool cxl_hdm_find_target(uint32_t *cache_mem, hwaddr addr,