From: Markus Armbruster <armbru@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel@nongnu.org, michael.roth@amd.com,
peter.maydell@linaro.org, eblake@redhat.com
Subject: Re: [PATCH 3/3] docs/devel/qapi-code-gen: Update cross-reference syntax
Date: Fri, 08 Aug 2025 08:35:42 +0200 [thread overview]
Message-ID: <87ikiymibl.fsf@pond.sub.org> (raw)
In-Reply-To: <CAFn=p-bYKEjGX-DYPNbxFn=52-dJH29-SwmPvWYZ7tgo9ZBS+w@mail.gmail.com> (John Snow's message of "Thu, 7 Aug 2025 17:31:34 -0400")
John Snow <jsnow@redhat.com> writes:
> On Thu, Jul 31, 2025 at 1:40 AM Markus Armbruster <armbru@redhat.com> wrote:
>>
>> The new QAPI code generator creates a cross-reference target for each
>> definition documentation. Enabled for the QEMU QMP Reference manual
>> in commit a377f39f38f, and for the QEMU Storage Daemon QMP Reference
>> Manual and the QEMU Guest Agent Protocol Reference in commit
>> a6af5443440. We've put these targets to use since, but neglected to
>> update doc comment markup documentation. Do that now.
>>
>> Co-developed-by: John Snow <jsnow@redhat.com>
>
> No need for this in my opinion, the SOB suffices to say the same thing
> in my book. I don't insist you remove it, just seems ... oddly
> pretentious to say I "co-developed" a single paragraph of text ;)
It wasn't obvious to me how to best credit you, so I tried this. The
Co-developed-by serves as an explanation why your S-o-b is there.
Please pick one:
1. Do nothing.
2. Delete Co-developed-by.
3. Delete Co-developed-by, your Signed-off-by, add your Reviewed-by.
>> Signed-off-by: John Snow <jsnow@redhat.com>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
> Reviewed-by: John Snow <jsnow@redhat.com>
Thanks!
next prev parent reply other threads:[~2025-08-08 6:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 5:40 [PATCH 0/3] docs/devel/qapi-code-gen: Update x-ref syntax, minor fixes Markus Armbruster
2025-07-31 5:40 ` [PATCH 1/3] docs/devel/qapi-code-gen: Add two cross-references we missed Markus Armbruster
2025-08-07 21:26 ` John Snow
2025-07-31 5:40 ` [PATCH 2/3] docs/devel/qapi-code-gen: Fix typos in QAPI schema language grammar Markus Armbruster
2025-08-07 21:28 ` John Snow
2025-07-31 5:40 ` [PATCH 3/3] docs/devel/qapi-code-gen: Update cross-reference syntax Markus Armbruster
2025-08-07 21:31 ` John Snow
2025-08-08 6:35 ` Markus Armbruster [this message]
2025-08-08 16:26 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ikiymibl.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=michael.roth@amd.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.