From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAD5E30AAAC for ; Wed, 2 Jul 2025 14:53:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751468036; cv=none; b=UCDr2e+Cm/cBwkEF0ZRZZfTHR2rMyrPWU6nqZ0zY2dMCENs2A0zWMUBO0J1rLUaeLcd3Y9XR+Y+VGb1tTDjorGbammZcjo9RetPbQlD1ncpgdPOyRbgkLkfGZ3h3t1VAgy/nDCe7XMtM0Dx1PEhgHSstaKOFB9euI82XNpgIetw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751468036; c=relaxed/simple; bh=mPbuEjcpZkqnW9/z23GhTgJRY8fs+/kHjUiI4+7VeIM=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=FH4muefdHNwtF+gowHmYQ9Pv6bY//KDEIUpK2E2QTOJoqmTau3+j/y8IZTEvF3QgfwiVAasmdvAhEbYAgihrfi5F4pIBoER+W8G9OpqwKhnQm1JkeTB1EGl5lvDCPQXiu9WdvSexgY9Nq5ZtBlK82OD+ROfsEQFgzajpfpW/QpU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=aDyRet7/; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=mVxRKfGF; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=aDyRet7/; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=mVxRKfGF; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="aDyRet7/"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="mVxRKfGF"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="aDyRet7/"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="mVxRKfGF" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EC00521161; Wed, 2 Jul 2025 14:53:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751468032; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J0NT7IP+odu1CwnKru+CrSk/O+Yo+mhlMg4rFJjFgPY=; b=aDyRet7/kPjky7MdlRB4hUFrmwMNHcfDrHh6FG0sT/LEUpJjCYY/6pblFmqEWz9AhdiOdV 3PP7DHz7K9m+PiaHd8ytnLAdKLDR9aDI996js3p6cMJAowNZFvSxXR1D25/mK3f+P6UYtn IRnCIgj7Hxb+DNC08zDV9wSS6E3/jrE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751468032; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J0NT7IP+odu1CwnKru+CrSk/O+Yo+mhlMg4rFJjFgPY=; b=mVxRKfGF7fl0Y4dbD99uyS4Eq4PRRVy5wLBB3minkkHHwpiGbaTsJupbg54ZbhZ6p/Ao3l BxuU4+5pGRlQW8Ag== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="aDyRet7/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=mVxRKfGF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751468032; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J0NT7IP+odu1CwnKru+CrSk/O+Yo+mhlMg4rFJjFgPY=; b=aDyRet7/kPjky7MdlRB4hUFrmwMNHcfDrHh6FG0sT/LEUpJjCYY/6pblFmqEWz9AhdiOdV 3PP7DHz7K9m+PiaHd8ytnLAdKLDR9aDI996js3p6cMJAowNZFvSxXR1D25/mK3f+P6UYtn IRnCIgj7Hxb+DNC08zDV9wSS6E3/jrE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751468032; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J0NT7IP+odu1CwnKru+CrSk/O+Yo+mhlMg4rFJjFgPY=; b=mVxRKfGF7fl0Y4dbD99uyS4Eq4PRRVy5wLBB3minkkHHwpiGbaTsJupbg54ZbhZ6p/Ao3l BxuU4+5pGRlQW8Ag== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BCAEE1369C; Wed, 2 Jul 2025 14:53:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 4GvWLP9HZWgTTgAAD6G6ig (envelope-from ); Wed, 02 Jul 2025 14:53:51 +0000 Date: Wed, 02 Jul 2025 16:53:51 +0200 Message-ID: <87ikkave2o.wl-tiwai@suse.de> From: Takashi Iwai To: linux-sound@vger.kernel.org Cc: Richard Fitzgerald , Kailang , Kai Vehmanen , Cezary Rojewski , Amadeusz =?ISO-8859-2?Q?S?= =?ISO-8859-2?Q?=B3awi=F1ski?= Subject: Re: [RFC] Reorganizing HD-audio driver code? In-Reply-To: <87h5zygawe.wl-tiwai@suse.de> References: <87ldpdgzle.wl-tiwai@suse.de> <87h5zygawe.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: EC00521161 X-Rspamd-Action: no action X-Spam-Flag: NO X-Spamd-Result: default: False [-2.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; DKIM_TRACE(0.00)[suse.de:+] X-Spam-Score: -2.51 X-Spam-Level: On Sun, 29 Jun 2025 11:22:25 +0200, Takashi Iwai wrote: > > On Fri, 27 Jun 2025 15:22:20 +0200, > Richard Fitzgerald wrote: > > > > On 27/06/2025 1:04 pm, Takashi Iwai wrote: > > > Hi, > > > > > > HD-audio driver is known to be quite messy in both file structures and > > > its design, but until now I haven't touched its files paths so much > > > because I set a higher priority for the easiness of backport to stable > > > kernels. But, you can't leave garbages forever, it's been already > > > high time for a large clean up. > > > > > > So I tried a quick code reorganization, and put the result in > > > test/hda-reorg branch of sound.git tree. > > > https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/log/?h=test/hda-reorg > > > > > > The basic idea is to move the code from sound/pci/hda/* into different > > > subdirectories in sound/hda/ per functionality, as most of the stuff > > > are independent from PCI, but rather HD-audio bus specific. > > > > > > > This all seems reasonable to me. I always thought it strange that there > > is a sound/hda directory but most of the HDA support isn't in that > > directory. > > Thanks for your review! > > It's a long story: at the time of ASoC Intel HD-audio support, we > thought to implement more ASoC-friendly way of HD-audio controller and > codec drivers, e.g. adapting DAPM and others. So we began with the > factoring out the HD-audio basic core stuff to the common directory > sound/hda/*, while keeping the rest legacy stuff almost as is. But > ASoC implementation didn't fly in the end from various reasons, and > the legacy HD-audio stuff was good enough for the actual use cases; > it's too bit to fail, after all. > > > > The Realtek codec is split further to smaller pieces (which was really > > > huge). > > > > Yes, that file was very confusing having support and quirks for so many > > Realtek parts all in one file. > > > > > The Cirrus and TI sub-codec drivers are moved to codecs/side-codecs > > > subdirectory: > > > > That's ok > > > > > They can be put to each own directory and drop the file name prefix, > > > if we want, too. Let me know if Cirrus and TI people would like to > > > split to more subdirectories. > > > > I don't mind either way. > > The hda_component* files are common to the amps and the realtek driver > > so I wonder whether they belong in helpers. They are only utility > > wrappers around the kernel component-binding APIs. > > Right. So far, just because it's basically only binding with > side-codecs, I put into side-codecs subdirectory. > > > > *HOWEVER* the biggest question is: whether it's worth? > > > > > > Essentially, this makes almost impossible to make a patch for stable > > > trees from the original commit as is; one has to translate the file > > > paths and adjust manually in each patch. > > > > Depends which file you are patching and how much it has changed. > > Git can figure out file renames (and changing directory is a rename). > > I'm afraid that the Realtek codec changes might be hard to track > automatically. Maybe the Cirrus side-codecs stuff would work. > > > > Also, of course, if anyone is working on HD-audio stuff right now, the > > > work had to be adjusted to the new file path. It'd be one-off action, > > > though. > > > > Speaking only for Cirrus, I don't think this makes much extra effort > > for us. Our amp drivers have only changed location, so that should be > > trivial. The other file we change is patch_realtek.c but that typically > > is only 1-line quirk entries. > > OK, thanks for confirmation! ... and now I worked further on this, resulting in larger set of changes. It's not only the file location changes but also the HD-audio codec driver binding changes. So I put more people to Cc for catch their cautions. To recap: - The all HD-audio driver code are moved under sound/hda. % ls sound/hda codecs/ common/ controllers/ core/ Kconfig Makefile * The former hda core code is found in sound/hda/core. * The former snd-hda-codec code is found in sound/hda/common. * The former snd-hda-intel, tegra and acpi are put in sound/hda/controllers. * The former patch_* and co are put to sound/hda/codecs. * Realtek codec driver is split to several modules as sound/hda/codecs/realtek/alc*. * Cirrus codec driver is split to cs420x and cs421x, put under sound/hda/codecs/cirrus together with cs8409. * HDMI codec driver is split to several modules under sound/hda/codecs/hdmi * Cirrus and TI sub-codecs are put under sound/hda/codecs/side-codecs - The HD-audio codec driver binding is changed from the embedded hda_codec.patch_ops to hda_codec_driver.ops. (As of now, hda_codec_driver.ops is a pointer, but it can be embedded later, too.) This change required some code to be modified without the dynamic override of callbacks. - In future, we may convert the runtime PM handling to use the standard pm_ops, too. This was raised some time ago during the discussion with Realtek devs. The current patches are found in test/hda-reorg branch of sound git tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/log/?h=test/hda-reorg It's based on master branch for taking all changes of for-linus and for-next, hence the branch may be still frequently rebased. So, please let me know if you see any issues or suggestions for this conversion. I have no concrete plan for merging, but if everything looks fine, it can be even on the next 6.17, too. thanks, Takashi