From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB571C5B552 for ; Mon, 9 Jun 2025 08:02:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mGy4MmZiCGT4m2ztjoAf6TVv747WrYI+98vKMx63o6M=; b=VU4Dwa0F37n5KU vD/XcYKs8ZSLcSyurX1mz2Q+eh3WtZWG45xnQPaibKSlzQ80ID8JHQDWS/l5xo9oAxwzRc+M0n0o3 brHO27EoFGFFn1t1Kw0cHXvMKEuNSN1ACgvkUNG6zHCpbtCHN9p4I9YppV9WCdkZVSB4DEm7U0pNu gzyuw/1u52pke3TchOF1GsellTr0z/GmHW60EvExE58QwNJt2TsjBV5e5AKaI7+NNv78zxVnh1Xps axmhrXMHWiaqICaNwhC34rbkQermlKollzDozvQ5E4jBPSsRaGCSXgOsyh6BwPJd9QrLPjKjXGNIX MTeQq9E4k9welPrqKDlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uOXSD-00000003csj-0XfY; Mon, 09 Jun 2025 08:02:01 +0000 Received: from relay1-d.mail.gandi.net ([2001:4b98:dc4:8::221]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uOXS9-00000003cs5-1c0B for linux-phy@lists.infradead.org; Mon, 09 Jun 2025 08:02:00 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id C57764333B; Mon, 9 Jun 2025 08:01:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1749456113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GWMslWGSvoXsYcCfEH9wUjkx8wd0acfIMyXXSa7t8/4=; b=LAwvyavXcxrHqdfx592VzTiRYZDjiiyHOItXX+9IsLrxlfW16mH7AVND/ggJfFdVKDFlOq bUrvazCd7FNsk229JN28YMyUqU37OSzPFoj0I5D1tEkkQhu2tS9j0D8mnEi5PUqTufcJ9n 3sPYSsaFjm/lYW/Dk7DC6+8pECqM9ojyI/O4WJOoTrhJZQ1lzGrmnV6Su2ZNL6SEaKaLJf q3Kl0tt4/jmisbzbrkdgeftjk9z7sS9LC4d10luDgabF44arG/dqXPhFYn2T6XzpDVOwhF Y/HWoZI1P15beL58qYOo5Uo2tpQ9rXKkWYdAzemAFISi52473WMEVCO66+ST1A== From: Miquel Raynal To: "Rob Herring (Arm)" Cc: Vinod Koul , Kishon Vijay Abraham I , Krzysztof Kozlowski , Conor Dooley , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: phy: Convert marvell,comphy-cp110 to DT schema In-Reply-To: <20250607212605.743176-1-robh@kernel.org> (Rob Herring's message of "Sat, 7 Jun 2025 16:26:03 -0500") References: <20250607212605.743176-1-robh@kernel.org> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Mon, 09 Jun 2025 10:01:50 +0200 Message-ID: <87ikl51gy9.fsf@bootlin.com> MIME-Version: 1.0 X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugdeltdefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtgfesthhqredttderjeenucfhrhhomhepofhiqhhuvghlucftrgihnhgrlhcuoehmihhquhgvlhdrrhgrhihnrghlsegsohhothhlihhnrdgtohhmqeenucggtffrrghtthgvrhhnpeffgefhjedtfeeigeduudekudejkedtiefhleelueeiueevheekvdeludehiedvfeenucfkphepledtrdekledrudeifedruddvjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeltddrkeelrdduieefrdduvdejpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihhquhgvlhdrrhgrhihnrghlsegsohhothhlihhnrdgtohhmpdhnsggprhgtphhtthhopeekpdhrtghpthhtoheprhhosghhsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehvkhhouhhlsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehkihhshhhonheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepkhhriihkodgutheskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheptghonhhorhdoughtsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihhnuhigqdhphhihsehlihhsthhsrdhinhhfr hgruggvrggurdhorhhgpdhrtghpthhtohepuggvvhhitggvthhrvggvsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhg X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250609_010158_199990_C3DF7553 X-CRM114-Status: GOOD ( 10.59 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org SGkgUm9iLAoKVGhhbmtzIGZvciB0aGUgY29udmVyc2lvbi4KCk9uIDA3LzA2LzIwMjUgYXQgMTY6 MjY6MDMgLTA1LCAiUm9iIEhlcnJpbmcgKEFybSkiIDxyb2JoQGtlcm5lbC5vcmc+IHdyb3RlOgoK PiBDb252ZXJ0IHRoZSBNYXJ2ZWxsIENQMTEwIGNvbWJvIFBIWSBiaW5kaW5nIHRvIERUIHNjaGVt YSBmb3JtYXQuIEl0J3MgYQo+IHN0cmFpZ2h0IGZvcndhcmQgY29udmVyc2lvbi4KPgo+IFNpZ25l ZC1vZmYtYnk6IFJvYiBIZXJyaW5nIChBcm0pIDxyb2JoQGtlcm5lbC5vcmc+CgpbLi4uXQoKPiAr cHJvcGVydGllczoKPiArICBjb21wYXRpYmxlOgo+ICsgICAgZW51bToKPiArICAgICAgLSBtYXJ2 ZWxsLGNvbXBoeS1jcDExMAo+ICsgICAgICAtIG1hcnZlbGwsY29tcGh5LWEzNzAwCj4gKwo+ICsg IHJlZzoKPiArICAgIG1pbkl0ZW1zOiAxCj4gKyAgICBpdGVtczoKPiArICAgICAgLSBkZXNjcmlw dGlvbjogR2VuZXJpYyBDT01QSFkgcmVnaXN0ZXJzCgpXb3VsZCB5b3UgbWluZCB0byBhZGQgIihB cm1hZGEgN2svOGspIiBoZXJlPyBUaGlzIGluZm9ybWF0aW9uIHdhcyBpbiB0aGUKZGVzY3JpcHRp b24gYW5kIGdvdCBsb3N0LiBBcm1hZGEgN2svOGsgaGFkIChJSVJDKSBhIG51bWJlciBvZgpBcHBs aWNhdGlvbiBQcm9jZXNzb3JzIGFuZCBDby1Qcm9jZXNzb3JzLCBpdCBtaWdodCBub3QgYmUKc3Ry YWlnaHRmb3J3YXJkIHRvIGd1ZXNzIHdoYXQgImNwMTEwIiBtZWFucyB0byBwZW9wbGUgbm90IGZh bWlsaWFyIHdpdGgKTWFydmVsbCBuYW1pbmcgb3RoZXJ3aXNlPwoKPiArICAgICAgLSBkZXNjcmlw dGlvbjogTGFuZSAxIChQQ0llL0diRSkgcmVnaXN0ZXJzIChBcm1hZGEgMzcwMCkKPiArICAgICAg LSBkZXNjcmlwdGlvbjogTGFuZSAwIChVU0IzL0diRSkgcmVnaXN0ZXJzIChBcm1hZGEgMzcwMCkK PiArICAgICAgLSBkZXNjcmlwdGlvbjogTGFuZSAyIChTQVRBL1VTQjMpIHJlZ2lzdGVycyAoQXJt YWRhIDM3MDApCj4gKwo+ICsgIHJlZy1uYW1lczoKPiArICAgIG1pbkl0ZW1zOiAxCgptaW5JdGVt cyBzaG91bGQgcHJvYmFibHkgYmUgNCBhcyBpdCBpcyBvbmx5IHJlcXVpcmVkIChhbmQgbWFuZGF0 b3J5KSBmb3IKdGhlIG1hcnZlbGwsY29tcGh5LWEzNzAwIGNvbXBhdGlibGU/IEkgZG8gbm90IHRo aW5rIHdlIGludGVuZGVkIHRvIGFzawpmb3IgYSByZWctbmFtZXMgcHJvcGVydHkgd2hlbiB0aGVy ZSB3YXMganVzdCBvbmUgZW50cnkgKHNlZQphcm1hZGEtY3AxMXguZHRzaSkuCgo+ICsgICAgaXRl bXM6Cj4gKyAgICAgIC0gY29uc3Q6IGNvbXBoeQo+ICsgICAgICAtIGNvbnN0OiBsYW5lMV9wY2ll X2diZQo+ICsgICAgICAtIGNvbnN0OiBsYW5lMF91c2IzX2diZQo+ICsgICAgICAtIGNvbnN0OiBs YW5lMl9zYXRhX3VzYjMKPiArCj4gKyAgJyNhZGRyZXNzLWNlbGxzJzoKPiArICAgIGNvbnN0OiAx CgpTaG91bGQgYmUgcmVxdWlyZWQ/Cgo+ICsKPiArICAnI3NpemUtY2VsbHMnOgo+ICsgICAgY29u c3Q6IDAKClNob3VsZCBiZSByZXF1aXJlZCBhcyB3ZWxsPwoKPiArCj4gKyAgY2xvY2tzOgo+ICsg ICAgbWF4SXRlbXM6IDMKPiArICAgIGRlc2NyaXB0aW9uOiBSZWZlcmVuY2UgY2xvY2tzIGZvciBD UDExMDsgTUcgY2xvY2ssIE1HIENvcmUgY2xvY2ssIEFYSSBjbG9jawo+ICsKPiArICBjbG9jay1u YW1lczoKPiArICAgIGl0ZW1zOgo+ICsgICAgICAtIGNvbnN0OiBtZ19jbGsKPiArICAgICAgLSBj b25zdDogbWdfY29yZV9jbGsKPiArICAgICAgLSBjb25zdDogYXhpX2Nsawo+ICsKPiArICBtYXJ2 ZWxsLHN5c3RlbS1jb250cm9sbGVyOgo+ICsgICAgZGVzY3JpcHRpb246IFBoYW5kbGUgdG8gdGhl IE1hcnZlbGwgc3lzdGVtIGNvbnRyb2xsZXIgKENQMTEwIG9ubHkpCj4gKyAgICAkcmVmOiAvc2No ZW1hcy90eXBlcy55YW1sIy9kZWZpbml0aW9ucy9waGFuZGxlCj4gKwo+ICtwYXR0ZXJuUHJvcGVy dGllczoKPiArICAnXnBoeUBbMC0yXSQnOgoKVGVjaG5pY2FsbHksIHRoZXNlIG5vZGVzIGFyZSBh bHNvIG1hbmRhdG9yeSwgSSBkb24ndCByZW1lbWJlciBpZiB3ZSBjYW4KbWFyayB0aGVtIGFzIHN1 Y2ggaW4gdGhlICJyZXF1aXJlZCIgc2VjdGlvbiB0aG91Z2guCgo+ICsgICAgZGVzY3JpcHRpb246 IEEgQ09NUEhZIGxhbmUgY2hpbGQgbm9kZQo+ICsgICAgdHlwZTogb2JqZWN0Cj4gKyAgICBhZGRp dGlvbmFsUHJvcGVydGllczogZmFsc2UKPiArCj4gKyAgICBwcm9wZXJ0aWVzOgo+ICsgICAgICBy ZWc6Cj4gKyAgICAgICAgZGVzY3JpcHRpb246IENPTVBIWSBsYW5lIG51bWJlcgo+ICsKPiArICAg ICAgJyNwaHktY2VsbHMnOgo+ICsgICAgICAgIGNvbnN0OiAxCj4gKwo+ICsgICAgcmVxdWlyZWQ6 Cj4gKyAgICAgIC0gcmVnCj4gKyAgICAgIC0gJyNwaHktY2VsbHMnCj4gKwo+ICtyZXF1aXJlZDoK PiArICAtIGNvbXBhdGlibGUKPiArICAtIHJlZwo+ICsKPiArYWRkaXRpb25hbFByb3BlcnRpZXM6 IGZhbHNlCgpUaGFua3MsCk1pcXXDqGwKCi0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4 LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mslow3.mail.gandi.net (mslow3.mail.gandi.net [217.70.178.249]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC7B41E3DF2; Mon, 9 Jun 2025 08:23:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.178.249 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749457430; cv=none; b=s8enJdTpew8IgXWHX02hd9mHNJrg0p48reiNl86PDBkeIV2AeHHaMxTbPlNk89BLWd0+QOllZlU3zKHN6ZifmNd07IGpT6kiDDMlYpSSN3zR7pk8VauPV5f1s/yagxzERfOdafDk5r5uqLPro723+qQB00JeMPatkGxH5tzXE0A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749457430; c=relaxed/simple; bh=aldj5xYyjzQWxK3ondhGvy0kNJNEb5k7X1O4cKIaPgY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=hwe5EDFKAWPN9AgEVx2+BNgG7OE9281TYHjcS9u9w7yqwLIG5+FH7tKhc1MMb/WPXfYyItkH1MeC34H27LoQu+S9rSsnjOwfeUcoiMWrRx8sWUm27l8WV48WHCkjFbWrMRvF6Mb5cQtO10RFkiTiDKruSuumKCVRcbLdAuJoBq8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=LAwvyavX; arc=none smtp.client-ip=217.70.178.249 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="LAwvyavX" Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::221]) by mslow3.mail.gandi.net (Postfix) with ESMTP id 42400582021; Mon, 9 Jun 2025 08:02:01 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id C57764333B; Mon, 9 Jun 2025 08:01:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1749456113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GWMslWGSvoXsYcCfEH9wUjkx8wd0acfIMyXXSa7t8/4=; b=LAwvyavXcxrHqdfx592VzTiRYZDjiiyHOItXX+9IsLrxlfW16mH7AVND/ggJfFdVKDFlOq bUrvazCd7FNsk229JN28YMyUqU37OSzPFoj0I5D1tEkkQhu2tS9j0D8mnEi5PUqTufcJ9n 3sPYSsaFjm/lYW/Dk7DC6+8pECqM9ojyI/O4WJOoTrhJZQ1lzGrmnV6Su2ZNL6SEaKaLJf q3Kl0tt4/jmisbzbrkdgeftjk9z7sS9LC4d10luDgabF44arG/dqXPhFYn2T6XzpDVOwhF Y/HWoZI1P15beL58qYOo5Uo2tpQ9rXKkWYdAzemAFISi52473WMEVCO66+ST1A== From: Miquel Raynal To: "Rob Herring (Arm)" Cc: Vinod Koul , Kishon Vijay Abraham I , Krzysztof Kozlowski , Conor Dooley , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: phy: Convert marvell,comphy-cp110 to DT schema In-Reply-To: <20250607212605.743176-1-robh@kernel.org> (Rob Herring's message of "Sat, 7 Jun 2025 16:26:03 -0500") References: <20250607212605.743176-1-robh@kernel.org> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Mon, 09 Jun 2025 10:01:50 +0200 Message-ID: <87ikl51gy9.fsf@bootlin.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugdeltdefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtgfesthhqredttderjeenucfhrhhomhepofhiqhhuvghlucftrgihnhgrlhcuoehmihhquhgvlhdrrhgrhihnrghlsegsohhothhlihhnrdgtohhmqeenucggtffrrghtthgvrhhnpeffgefhjedtfeeigeduudekudejkedtiefhleelueeiueevheekvdeludehiedvfeenucfkphepledtrdekledrudeifedruddvjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeltddrkeelrdduieefrdduvdejpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihhquhgvlhdrrhgrhihnrghlsegsohhothhlihhnrdgtohhmpdhnsggprhgtphhtthhopeekpdhrtghpthhtoheprhhosghhsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehvkhhouhhlsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehkihhshhhonheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepkhhriihkodgutheskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheptghonhhorhdoughtsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihhnuhigqdhphhihsehlihhsthhsrdhinhhfr hgruggvrggurdhorhhgpdhrtghpthhtohepuggvvhhitggvthhrvggvsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhg X-GND-Sasl: miquel.raynal@bootlin.com Hi Rob, Thanks for the conversion. On 07/06/2025 at 16:26:03 -05, "Rob Herring (Arm)" wrote: > Convert the Marvell CP110 combo PHY binding to DT schema format. It's a > straight forward conversion. > > Signed-off-by: Rob Herring (Arm) [...] > +properties: > + compatible: > + enum: > + - marvell,comphy-cp110 > + - marvell,comphy-a3700 > + > + reg: > + minItems: 1 > + items: > + - description: Generic COMPHY registers Would you mind to add "(Armada 7k/8k)" here? This information was in the description and got lost. Armada 7k/8k had (IIRC) a number of Application Processors and Co-Processors, it might not be straightforward to guess what "cp110" means to people not familiar with Marvell naming otherwise? > + - description: Lane 1 (PCIe/GbE) registers (Armada 3700) > + - description: Lane 0 (USB3/GbE) registers (Armada 3700) > + - description: Lane 2 (SATA/USB3) registers (Armada 3700) > + > + reg-names: > + minItems: 1 minItems should probably be 4 as it is only required (and mandatory) for the marvell,comphy-a3700 compatible? I do not think we intended to ask for a reg-names property when there was just one entry (see armada-cp11x.dtsi). > + items: > + - const: comphy > + - const: lane1_pcie_gbe > + - const: lane0_usb3_gbe > + - const: lane2_sata_usb3 > + > + '#address-cells': > + const: 1 Should be required? > + > + '#size-cells': > + const: 0 Should be required as well? > + > + clocks: > + maxItems: 3 > + description: Reference clocks for CP110; MG clock, MG Core clock, AX= I clock > + > + clock-names: > + items: > + - const: mg_clk > + - const: mg_core_clk > + - const: axi_clk > + > + marvell,system-controller: > + description: Phandle to the Marvell system controller (CP110 only) > + $ref: /schemas/types.yaml#/definitions/phandle > + > +patternProperties: > + '^phy@[0-2]$': Technically, these nodes are also mandatory, I don't remember if we can mark them as such in the "required" section though. > + description: A COMPHY lane child node > + type: object > + additionalProperties: false > + > + properties: > + reg: > + description: COMPHY lane number > + > + '#phy-cells': > + const: 1 > + > + required: > + - reg > + - '#phy-cells' > + > +required: > + - compatible > + - reg > + > +additionalProperties: false Thanks, Miqu=C3=A8l