From: Nick Alcock <nick.alcock@oracle.com>
To: Kris Van Hees via DTrace-devel <dtrace-devel@oss.oracle.com>
Cc: dtrace@lists.linux.dev, Kris Van Hees <kris.van.hees@oracle.com>
Subject: Re: [DTrace-devel] [PATCH 2/2] consume: avoid a bad prid causing a core dump
Date: Fri, 21 Mar 2025 15:06:28 +0000 [thread overview]
Message-ID: <87iko24e4r.fsf@esperi.org.uk> (raw)
In-Reply-To: <9aa129d930bfce0b1a060389fc886e9f.kris.van.hees@oracle.com> (Kris Van Hees via DTrace-devel's message of "Fri, 21 Mar 2025 10:43:59 -0400")
On 21 Mar 2025, Kris Van Hees via DTrace-devel said:
> We were not guarding against prid being DTACE_IDNONE (0), which would
> cause a core dump if it was encountered in a trace record.
... hm, I had no idea that the dt_probes array was 1-based, but I guess
given that the NONE id is 0 it kind of has to be.
> Signed-off-by: Kris Van Hees <kris.van.hees@oracle.com>
Reviewed-by: Nick Alcock <nick.alcock@oracle.com>
prev parent reply other threads:[~2025-03-21 15:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 14:43 [PATCH 2/2] consume: avoid a bad prid causing a core dump Kris Van Hees
2025-03-21 15:06 ` Nick Alcock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iko24e4r.fsf@esperi.org.uk \
--to=nick.alcock@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=kris.van.hees@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.