From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 824C9C35FFC for ; Wed, 19 Mar 2025 17:32:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/4bKiOP8SeRRPtKc0sWDd0dsg9dXD05FapO1xR2ILAM=; b=uq8KfskIxDT0A1 lkSRg3B+GQfBcD+z+L7MsVuBTlWSOIwBZ1ZYG4hTDIQcGdWHdDUCWQj40oPMJ8S3EPP4f0FZiCFse l4kM5dZXY8HaE+2vsZgOL1wSjhR91uAEpd7ZLILR/NHWo6+nCd+DaUbutdnmaFHyG/AWnkxX6KCXP gGrEsj7zVfLVdNklHTlxUJKf7jk4bcV4zZbhoA5xawCgUaXeidXpbCa8haJIEIssJEVwilgJwBhLX PFzfyhw+Kr9NmQ5a45/Hx9k7DZKTsEjxCKaTsTdzgQSWaFA/GKiyEoGuPxuKskE+hH74gOX9yGTSN VbKkBiI8M//oEioYbSYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tuxHM-00000009iPr-3bo0; Wed, 19 Mar 2025 17:32:32 +0000 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tuxHJ-00000009iPF-1yez for linux-mtd@lists.infradead.org; Wed, 19 Mar 2025 17:32:31 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 0942D443C7; Wed, 19 Mar 2025 17:32:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1742405546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5C7I0N55tGNiLgOlLviaVlEZTLMrzLLmEJs0DulmBOY=; b=c4d3vOtxZ9r3CFRArLFjw2OSj+8aoBFQg+7+NdkH7Y1E77lORyM5o8oWpCLwMyZVOCu5QG NPBnBOpyQ+69GnyIonraYCfPo6gtlQZ+9y2kWwsxeewlV+qYWQZ7LkaD+Non9xwfboxRab I52hP3KgFBVY9MeGe5Ry08e1TRNJs3t08p2R1hwSVWy/bkLM3USH0dnKlrs9xiJ9NTopYT vfBF6xrXO3ghUVP/N1I7SE5yJKvBMlTsSwEUeRqBraBEJkFPwzm+I9pz6NIsKEEPpSrMVJ DpW7k5orHM4lpoS4Q2ef4te5Sg6z5uhd9+89GFYfqRr3iXeD6HOt1jSbA+1WCQ== From: Miquel Raynal To: Tudor Ambarus Cc: Richard Weinberger , Vignesh Raghavendra , Santhosh Kumar K , Pratyush Yadav , Michael Walle , Thomas Petazzoni , Steam Lin , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/21] mtd: spinand: Use more specific naming for the reset op In-Reply-To: (Tudor Ambarus's message of "Mon, 10 Mar 2025 12:14:06 +0200") References: <20250307-winbond-6-14-rc1-octal-v1-0-45c1e074ad74@bootlin.com> <20250307-winbond-6-14-rc1-octal-v1-1-45c1e074ad74@bootlin.com> <9004166e-5535-4024-8114-9fdb217407bb@linaro.org> <87v7skrgjl.fsf@bootlin.com> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Wed, 19 Mar 2025 18:32:24 +0100 Message-ID: <87iko50vvb.fsf@bootlin.com> MIME-Version: 1.0 X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddugeehleegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtgfesthhqredttderjeenucfhrhhomhepofhiqhhuvghlucftrgihnhgrlhcuoehmihhquhgvlhdrrhgrhihnrghlsegsohhothhlihhnrdgtohhmqeenucggtffrrghtthgvrhhnpeffgefhjedtfeeigeduudekudejkedtiefhleelueeiueevheekvdeludehiedvfeenucfkphepledtrdekledrudeifedruddvjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeltddrkeelrdduieefrdduvdejpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihhquhgvlhdrrhgrhihnrghlsegsohhothhlihhnrdgtohhmpdhnsggprhgtphhtthhopedutddprhgtphhtthhopehtuhguohhrrdgrmhgsrghruhhssehlihhnrghrohdrohhrghdprhgtphhtthhopehrihgthhgrrhgusehnohgurdgrthdprhgtphhtthhopehvihhgnhgvshhhrhesthhirdgtohhmpdhrtghpthhtohepshdqkheisehtihdrtghomhdprhgtphhtthhopehprhgrthihuhhshheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepmhhitghhrggvlhesfigrlhhlvgdrtggtpdhrt ghpthhtohepthhhohhmrghsrdhpvghtrgiiiihonhhisegsohhothhlihhnrdgtohhmpdhrtghpthhtohepshhtlhhinhdvseifihhnsghonhgurdgtohhm X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250319_103229_982200_79425BA8 X-CRM114-Status: GOOD ( 29.13 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGVsbG8gVHVkb3IsCgpPbiAxMC8wMy8yMDI1IGF0IDEyOjE0OjA2ICswMiwgVHVkb3IgQW1iYXJ1 cyA8dHVkb3IuYW1iYXJ1c0BsaW5hcm8ub3JnPiB3cm90ZToKCj4gT24gMDcuMDMuMjAyNSAxNzo0 NSwgTWlxdWVsIFJheW5hbCB3cm90ZToKPj4gSGkgVHVkb3IsCj4KPiBIaSEKPgo+PiAKPj4+PiAt I2RlZmluZSBTUElOQU5EX1JFU0VUX09QCQkJCQkJXAo+Pj4+ICsjZGVmaW5lIFNQSU5BTkRfUkVT RVRfMVNfMF8wX09QCQkJCQkJXAo+Pj4gSGksIE1pcXVlbCwKPj4+Cj4+PiBIYXZlIHlvdSBzZWVu IGFueSByZXNldCBvcCB3aXRoIGFkZHJlc3Mgb3IgZGF0YT8gSWYgbm90LCBJJ20gbm90IHJlYWxs eQo+Pj4gc3VyZSB3aGV0aGVyIHdlIHNoYWxsIGNoYW5nZSB0aGUgbmFtZSBmb3IgdGhlc2UgYmFz aWMgb3BlcmF0aW9ucy4KPj4+Cj4+PiBDaGFuZ2luZyB0aGVtIHRvIDFTLTAtMCBtYXkgYWxzbyBp bmRpY2F0ZSB0aGF0IHRoZXJlIGFyZSByZXNldHMgd2l0aAo+Pj4gYWRkcmVzcyBvciBkYXRhIGZp ZWxkcywgd2hpY2ggSSBmaW5kIGNvbmZ1c2luZy4KPj4+Cj4+PiBJIHRoaW5rIHRoZSBjaGFuZ2Ug aXMgZ29vZCBmb3IgcmVhZHMgYW5kIHdyaXRlcy4gSSdsbCBjaGVjayBmdXJ0aGVyIGluCj4+PiB0 aGUgc2VyaWVzIGFuZCBsZXQgeW91IGtub3cuCj4+IAo+PiBJIHdhbnQgdG8gcmVuYW1lIHRoaXMg bWFjcm8gZm9yIHR3byByZWFzb25zOgo+PiAtIFdlIG1pZ2h0IHNlZSBpbiB0aGUgbmVhciBmdXR1 cmUgdGhlIGFkZGl0aW9uIG9mIDhELTAtMCBvcHMgKEkgcGxhbiBvbgo+PiAgIHdvcmtpbmcgb24g aXQpLgo+PiAtIEkgd291bGQgbGlrZSBzb21lIGtpbmQgb2YgaGFybW9ueSBhbW9uZyB0aGVzZSBt YWNyb3MuCj4+IAo+PiBOb3csIHdoZXRoZXIgaXMgc2hvdWxkIGJlIG5hbWVkIGxpa2UgSSBwcm9w b3NlZCBvciBqdXN0Cj4+IFNQSU5BTkRfUkVTRVRfT1BfMVMsIEkgaGF2ZSBubyBzdHJvbmcgcHJl ZmVyZW5jZSBhbmQgSSBjYW4gY2hhbmdlIHRoYXQKPj4gaW4gYW4gdXBjb21pbmcgdmVyc2lvbi4K Pj4gCj4+IFdoaWNoIG9uZSB3b3VsZCB5b3UgcHJlZmVyPwo+Cj4gSSBkb24ndCBrbm93LiBXaGlj aCBvbmUgaXMgYmFja2VkIHVwIGJ5IGEgc3RhbmRhcmQ/CgpXZWxsLCBhcyBmYXIgYXMgSSBrbm93 LCBub25lIG9mIHRoZSBTUEkgTkFORCBkZXZpY2VzIGZvbGxvdyBhIHZlcnkKc3BlY2lmaWMgc3Rh bmRhcmQuIE1vc3QgdmVuZG9ycyBpbiBwcmFjdGljZSBmb2xsb3cgc2ltaWxhciBjb252ZW50aW9u cywKYnV0IHRoZXkgYWxsIGRldmlhdGUgYSBiaXQgZnJvbSBpdC4KCj4gSkVTRDIxNkYgZGVmaW5l cwo+ICIoQW4tQm4tQ24pOiBDb21tYW5kIG1vZGUgbm9tZW5jbGF0dXJlIHVzZWQgdG8gaW5kaWNh dGUgdGhlIG51bWJlciBvZgo+IGFjdGl2ZSBwaW5zIHVzZWQgZm9yIHRoZSBpbnN0cnVjdGlvbiAo QSksIGFkZHJlc3MgKEIpLCBhbmQgZGF0YSAoQyksIGFuZAo+IHRoZSBkYXRhIHJhdGUgdXNlZCBm b3IgZWFjaC4gRGF0YSByYXRlcyhuKSBjYW4gYmUgc2luZ2xlIChTKSBhbmQgZHVhbCAoRCkuIgo+ Cj4gQWxzbywgIih4LXkteikgbm9tZW5jbGF0dXJlIGlzIGVxdWl2YWxlbnQgdG8oQVMtQlMtQ1Mp IHVubGVzcyBvdGhlcndpc2UKPiBub3RlZC4iCj4KPiBXaGF0J3MgYW4gImFjdGl2ZSBwaW4iPwo+ Cj4gVGhlbiBpZiBJIGxvb2sgYXQgSkVTRDI1MS0xLjAxIGFuZCBKRVNEMjUxQywgKEFuLUJuLUNu KSBpcyByZWZlcnJlZCB0bwo+IGFzICJwcm90b2NvbCBtb2RlIi4gV3JpdGUgRW5hYmxlLCB3aGlj aCBpcyBqdXN0IGFuIGluc3RydWN0aW9uIGNvbW1hbmQKPiB3aXRoIG5vIGFkZHJlc3Mgb3IgZGF0 YSwgaXMgc2VlbiBhcyBhIHJlcXVpcmVkIGNvbW1hbmQgaW4gYm90aCA0RC00RC00RAo+IGFuZCA4 RC04RC04RCBwcm90b2NvbCBtb2RlcywgYW5kIGl0J3MgZGVmaW5lZCBhcyBhICIxLkEiIHRyYW5z YWN0aW9uCj4gZm9ybWF0IGNvbW1hbmQuIEFuZCB0aGUgdHJhbnNhY3Rpb24gZm9ybWF0IGlzOgo+ ICcnJwo+IFRoZSBmb2xsb3dpbmcgdHJhbnNhY3Rpb24gZm9ybWF0cyBhcmUgdXNlZCBpbiBQcm9m aWxlIDEuMCBtb2RlIDhELThELThEOgo+IEZvcm1hdCAxLkE6IENvbW1hbmQgYW5kIENvbW1hbmQg RXh0ZW5zaW9uCj4gRm9ybWF0IDEuQjogQ29tbWFuZCwgQ29tbWFuZCBFeHRlbnNpb24sIDQtYnl0 ZSBBZGRyZXNzLCDigJhu4oCZIExhdGVuY3kKPiBDeWNsZXMsIGFuZCBSZWFkIERhdGEKPiBGb3Jt YXQgMS5DOiBDb21tYW5kLCBDb21tYW5kIEV4dGVuc2lvbiwgYW5kIDQtYnl0ZSBBZGRyZXNzCj4g Rm9ybWF0IDEuRDogQ29tbWFuZCwgQ29tbWFuZCBFeHRlbnNpb24sIDQtYnl0ZSBBZGRyZXNzLCBh bmQgV3JpdGUgRGF0YQo+ICcnJwo+Cj4gU28gYWNjb3JkaW5nIHRvIHRoZXNlIHN0YW5kYXJkcyBt YXliZSB3ZSBzaGFsbCByZWZlciB0byBpdCBhczoKPiBXUkVOLThELThELThELTFBPyBUaGlzIHNl ZW1zIGxlc3MgaW50dWl0aXZlIHRoYW4gOEQtMC0wLCBidXQgSSB0aGluayBpdAo+IGFsbCBkZXBl bmRzIG9uIHdoYXQncyBhbiAiYWN0aXZlIHBpbiIuIEkgdGhpbmsgaXQgZGVzY3JpYmVzIHRoZSBw cm90b2NvbAo+IG1vZGUsIGFuZCBub3Qgd2hhdCdzIGFjdHVhbGx5IHNlbnQgb24gdGhlIGxpbmUu IEFzIHdlIHNhdywgV1JFTiBpcwo+IGNvbnNpZGVyZWQgYW4gOEQtOEQtOEQgY29tbWFuZCwgYW5k IG5vdCBhbiA4RC0wLTAgY29tbWFuZC4KPgo+IEZvciBkdWFsIG1vZGUsIHdoaWNoIGlzIG5vdCBj b3ZlcmVkIGJ5IHhTUEksIEkgZ3Vlc3Mgd2UgY2FuIHVzZSB0aGUKPiBzaW5nbGUgc3BpIHRyYW5z YWN0aW9uIGZvcm1hdHMgMC57QSxCLEMsLi4ufS4KPgo+IEhvdyBkbyB5b3UgZmVlbCBhYm91dCBh IE9QLUFuLUJuLUNuLXRyYW5zYWN0aW9uLWZvcm1hdCwKPiAJd2hlcmUgQSwgQiwgQyBpcyB7MSwg MiwgNCwgOH0KPiAJbiBpcyB7UywgRH0KPiAJdHJhbnNhY3Rpb24gZm9ybWF0IGlzIHswLDEsMiwz fXtBLEIsQywuLi59Cj4KPiBDYXJlIG11c3QgYmUgdGFrZW4gY2FyZSBvZiBhdCB0aGUgdHJhbnNh Y3Rpb24gZm9ybWF0LCBhcyBJIHNlZSB0aGVyZSBhcmUKPiBhIGZldywgZGVwZW5kaW5nIG9uIHRo ZSB4U1BJIHByb2ZpbGUgYW5kIHByb3RvY29sIG1vZGUuCgpJIG11c3QgYWRtaXQgSSByZWFsbHkg ZGlzbGlrZSB0aGUgdHJhbnNhY3Rpb24gZm9ybWF0IGFiYnJldmlhdGlvbiBiZWNhdXNlCml0IGlz IHNwZWNpZmljIHRvIGEgc3BlYyB3ZSBkbyBub3QgZm9sbG93IGFuZCBpcyBub3QgZXhwbGljaXQu IEkgaGF2ZSBhCnN0cm9uZyBwcmVmZXJlbmNlIHRvd2FyZHMga2VlcGluZyBqdXN0ICJBbi1Cbi1D biIsIGxpa2UgSSBkaWQgaW4gdGhpcwpzZXJpZXMuIElmIHBlb3BsZSBhcmUgaW4gZG91YnQsIHRo ZXkgY2FuIGNoZWNrIHdoYXQgaXMgaW4gdGhlIG9wLCBpdCBpcwpzZWxmIGV4cGxhbmF0b3J5LiBJ IGNob3NlIHRoaXMgaW4gdGhlIGZpcnN0IHBsYWNlIGJlY2F1c2UgaXQgaXMgbW9yZQpleHBsaWNp dCB0aGFuIGp1c3QgIkFuIiB3aGljaCBtYXkgZmVlbCBsaWtlIGEgY3JvcHBlZAphY3JvbnltLiBG dXJ0aGVybW9yZSwgbW9zdCBvY3RhbCBjYXBhYmxlIGRhdGFzaGVldHMgSSd2ZSBsb29rZWQgYXQg c2VlbQp0byB1c2UgdGhlICJBbi1Cbi1DbiIgZm9ybWF0LCBldmVuIGZvciBzaW5nbGUgb3Bjb2Rl cy4KClNvIHVubGVzcyB0aGVyZSBhcmUgc3Ryb25nIGFyZ3VtZW50cyBhZ2FpbnN0LCBJJ2QgcHJl ZmVyIHRvIGtlZXAgdGhlCmN1cnJlbnQgZm9ybWF0dGluZy4gVEJILCBpdCBpcyBub3Qgc2V0IGlu IHN0b25lIGFuZCBjYW4gc3RpbGwgZXZvbHZlCmxhdGVyIGlmIHRoYXQncyBuZWVkZWQuCgpUaGFu a3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1AB418DF93 for ; Wed, 19 Mar 2025 17:32:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742405550; cv=none; b=di4jA2r7tBhvCQ+D6nAp+j1nPSWjPAorRmJwyVz0SHHMDIMPQYAAepSQRlrgLsKxy9cJjoR8lm8IbiroVbsV4Bpf+1RiQZnneRP75W/cqAJKJG4X1wyHBA4linzZL30KspEaOgaTqxCtdct+0xZizzdesDPXxTdpE29QMnk33yQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742405550; c=relaxed/simple; bh=1X9u9KzK0gb6a1C8FSSp6AtPgQJA+sK4ulkRKoFnqbg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Sy3PLM3NQvqyzsK3UgSK2LC+FYbYwXZSfiWIZTEouAiM+aURzm6NvnmJheHtddLvVUw9XsFlRAHrjTFO+Xzv2/vAvNkFWdGspbgSFoiiQ6z15TTq4++bbta3tVEeD6Dv3jcy6F6vp4AcIpJD+/5fwMnK1QzgC9HNX24RSkaDe4o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=c4d3vOtx; arc=none smtp.client-ip=217.70.183.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="c4d3vOtx" Received: by mail.gandi.net (Postfix) with ESMTPSA id 0942D443C7; Wed, 19 Mar 2025 17:32:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1742405546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5C7I0N55tGNiLgOlLviaVlEZTLMrzLLmEJs0DulmBOY=; b=c4d3vOtxZ9r3CFRArLFjw2OSj+8aoBFQg+7+NdkH7Y1E77lORyM5o8oWpCLwMyZVOCu5QG NPBnBOpyQ+69GnyIonraYCfPo6gtlQZ+9y2kWwsxeewlV+qYWQZ7LkaD+Non9xwfboxRab I52hP3KgFBVY9MeGe5Ry08e1TRNJs3t08p2R1hwSVWy/bkLM3USH0dnKlrs9xiJ9NTopYT vfBF6xrXO3ghUVP/N1I7SE5yJKvBMlTsSwEUeRqBraBEJkFPwzm+I9pz6NIsKEEPpSrMVJ DpW7k5orHM4lpoS4Q2ef4te5Sg6z5uhd9+89GFYfqRr3iXeD6HOt1jSbA+1WCQ== From: Miquel Raynal To: Tudor Ambarus Cc: Richard Weinberger , Vignesh Raghavendra , Santhosh Kumar K , Pratyush Yadav , Michael Walle , Thomas Petazzoni , Steam Lin , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/21] mtd: spinand: Use more specific naming for the reset op In-Reply-To: (Tudor Ambarus's message of "Mon, 10 Mar 2025 12:14:06 +0200") References: <20250307-winbond-6-14-rc1-octal-v1-0-45c1e074ad74@bootlin.com> <20250307-winbond-6-14-rc1-octal-v1-1-45c1e074ad74@bootlin.com> <9004166e-5535-4024-8114-9fdb217407bb@linaro.org> <87v7skrgjl.fsf@bootlin.com> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Wed, 19 Mar 2025 18:32:24 +0100 Message-ID: <87iko50vvb.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddugeehleegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtgfesthhqredttderjeenucfhrhhomhepofhiqhhuvghlucftrgihnhgrlhcuoehmihhquhgvlhdrrhgrhihnrghlsegsohhothhlihhnrdgtohhmqeenucggtffrrghtthgvrhhnpeffgefhjedtfeeigeduudekudejkedtiefhleelueeiueevheekvdeludehiedvfeenucfkphepledtrdekledrudeifedruddvjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeltddrkeelrdduieefrdduvdejpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihhquhgvlhdrrhgrhihnrghlsegsohhothhlihhnrdgtohhmpdhnsggprhgtphhtthhopedutddprhgtphhtthhopehtuhguohhrrdgrmhgsrghruhhssehlihhnrghrohdrohhrghdprhgtphhtthhopehrihgthhgrrhgusehnohgurdgrthdprhgtphhtthhopehvihhgnhgvshhhrhesthhirdgtohhmpdhrtghpthhtohepshdqkheisehtihdrtghomhdprhgtphhtthhopehprhgrthihuhhshheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepmhhitghhrggvlhesfigrlhhlvgdrtggtpdhrt ghpthhtohepthhhohhmrghsrdhpvghtrgiiiihonhhisegsohhothhlihhnrdgtohhmpdhrtghpthhtohepshhtlhhinhdvseifihhnsghonhgurdgtohhm X-GND-Sasl: miquel.raynal@bootlin.com Hello Tudor, On 10/03/2025 at 12:14:06 +02, Tudor Ambarus wro= te: > On 07.03.2025 17:45, Miquel Raynal wrote: >> Hi Tudor, > > Hi! > >>=20 >>>> -#define SPINAND_RESET_OP \ >>>> +#define SPINAND_RESET_1S_0_0_OP \ >>> Hi, Miquel, >>> >>> Have you seen any reset op with address or data? If not, I'm not really >>> sure whether we shall change the name for these basic operations. >>> >>> Changing them to 1S-0-0 may also indicate that there are resets with >>> address or data fields, which I find confusing. >>> >>> I think the change is good for reads and writes. I'll check further in >>> the series and let you know. >>=20 >> I want to rename this macro for two reasons: >> - We might see in the near future the addition of 8D-0-0 ops (I plan on >> working on it). >> - I would like some kind of harmony among these macros. >>=20 >> Now, whether is should be named like I proposed or just >> SPINAND_RESET_OP_1S, I have no strong preference and I can change that >> in an upcoming version. >>=20 >> Which one would you prefer? > > I don't know. Which one is backed up by a standard? Well, as far as I know, none of the SPI NAND devices follow a very specific standard. Most vendors in practice follow similar conventions, but they all deviate a bit from it. > JESD216F defines > "(An-Bn-Cn): Command mode nomenclature used to indicate the number of > active pins used for the instruction (A), address (B), and data (C), and > the data rate used for each. Data rates(n) can be single (S) and dual (D)= ." > > Also, "(x-y-z) nomenclature is equivalent to(AS-BS-CS) unless otherwise > noted." > > What's an "active pin"? > > Then if I look at JESD251-1.01 and JESD251C, (An-Bn-Cn) is referred to > as "protocol mode". Write Enable, which is just an instruction command > with no address or data, is seen as a required command in both 4D-4D-4D > and 8D-8D-8D protocol modes, and it's defined as a "1.A" transaction > format command. And the transaction format is: > ''' > The following transaction formats are used in Profile 1.0 mode 8D-8D-8D: > Format 1.A: Command and Command Extension > Format 1.B: Command, Command Extension, 4-byte Address, =E2=80=98n=E2=80= =99 Latency > Cycles, and Read Data > Format 1.C: Command, Command Extension, and 4-byte Address > Format 1.D: Command, Command Extension, 4-byte Address, and Write Data > ''' > > So according to these standards maybe we shall refer to it as: > WREN-8D-8D-8D-1A? This seems less intuitive than 8D-0-0, but I think it > all depends on what's an "active pin". I think it describes the protocol > mode, and not what's actually sent on the line. As we saw, WREN is > considered an 8D-8D-8D command, and not an 8D-0-0 command. > > For dual mode, which is not covered by xSPI, I guess we can use the > single spi transaction formats 0.{A,B,C,...}. > > How do you feel about a OP-An-Bn-Cn-transaction-format, > where A, B, C is {1, 2, 4, 8} > n is {S, D} > transaction format is {0,1,2,3}{A,B,C,...} > > Care must be taken care of at the transaction format, as I see there are > a few, depending on the xSPI profile and protocol mode. I must admit I really dislike the transaction format abbreviation because it is specific to a spec we do not follow and is not explicit. I have a strong preference towards keeping just "An-Bn-Cn", like I did in this series. If people are in doubt, they can check what is in the op, it is self explanatory. I chose this in the first place because it is more explicit than just "An" which may feel like a cropped acronym. Furthermore, most octal capable datasheets I've looked at seem to use the "An-Bn-Cn" format, even for single opcodes. So unless there are strong arguments against, I'd prefer to keep the current formatting. TBH, it is not set in stone and can still evolve later if that's needed. Thanks, Miqu=C3=A8l