From: "Alex Bennée" <alex.bennee@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v3] meson.build: default to -gsplit-dwarf for debug info
Date: Fri, 07 Mar 2025 14:52:22 +0000 [thread overview]
Message-ID: <87ikok3nbt.fsf@draig.linaro.org> (raw)
In-Reply-To: <CABgObfbcTqr7LNDumDXo7wXf=WigZ2U0Kwv97NRFAHgPoCQ8WQ@mail.gmail.com> (Paolo Bonzini's message of "Fri, 7 Mar 2025 15:36:01 +0100")
Paolo Bonzini <pbonzini@redhat.com> writes:
> On Thu, Mar 6, 2025 at 5:16 PM Alex Bennée <alex.bennee@linaro.org> wrote:
>> +if get_option('debug')
>> + qemu_cflags += get_option('split_debug') ? ['-gsplit-dwarf'] : ['-g']
>> +endif
>
> Since -g is already added by meson, it's enough to do
>
> -if get_option('debug')
> - qemu_cflags += get_option('split_debug') ? ['-gsplit-dwarf'] : ['-g']
> +if get_option('debug') and get_option('split_debug')
> + qemu_cflags += '-gsplit-dwarf'
> endif
>
> Applied with this change, then.
Ahh I guess I was missing that meson does that under the hood. Can I
have a r-b with that change or do do you want to wait for v4?
>
> Paolo
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
prev parent reply other threads:[~2025-03-07 14:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 16:16 [PATCH v3] meson.build: default to -gsplit-dwarf for debug info Alex Bennée
2025-03-07 14:36 ` Paolo Bonzini
2025-03-07 14:52 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ikok3nbt.fsf@draig.linaro.org \
--to=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.