From: Joshua Murphy <joshuamurphy@posteo.net>
To: asmadeus@codewreck.org
Cc: Daniel Verkamp <dverkamp@chromium.org>,
ericvh@kernel.org, lucho@ionkov.net, linux_oss@crudebyte.com,
v9fs@lists.linux.dev
Subject: Re: [PATCH] net/9p/fd: change port to char *
Date: Sat, 25 Jan 2025 17:48:38 +0000 [thread overview]
Message-ID: <87ikq27pjd.fsf@posteo.net> (raw)
In-Reply-To: <Z5RTs5XANcDxvZT0@codewreck.org> (asmadeus@codewreck.org's message of "Sat, 25 Jan 2025 12:00:03 +0900")
> I didn't quite estimate the clean up path would be this messy, this
> "simple cleanup" is ending up being more complicated than the originial
> version so I'm thinking we're better off keeping the int -- what do you
> think?
Yeah, I’m also thinking that keeping the int would be best.
I don’t think the end result would be more clean than the
current code.
Thanks for the review from you both anyways!
--
Joshua Murphy
joshuamurphy@posteo.net
prev parent reply other threads:[~2025-01-25 17:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 21:14 [PATCH] net/9p/fd: change port to char * Joshua Murphy
2025-01-24 23:12 ` Daniel Verkamp
2025-01-25 3:00 ` asmadeus
2025-01-25 17:48 ` Joshua Murphy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ikq27pjd.fsf@posteo.net \
--to=joshuamurphy@posteo.net \
--cc=asmadeus@codewreck.org \
--cc=dverkamp@chromium.org \
--cc=ericvh@kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.