From: Nick Alcock <nick.alcock@oracle.com>
To: Nick Alcock <nick.alcock@oracle.com>
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [PATCH] dtprobed: don't chown systemd service files to root during install
Date: Mon, 11 Nov 2024 15:59:29 +0000 [thread overview]
Message-ID: <87ikst4v8e.fsf@esperi.org.uk> (raw)
In-Reply-To: <20241111104646.435193-1-nick.alcock@oracle.com> (Nick Alcock's message of "Mon, 11 Nov 2024 10:46:46 +0000")
On 11 Nov 2024, Nick Alcock said:
> I put this in while thinking vaguely that "systemd requires these
> to be root-owned, we're not using install(1) so we should fix that".
> If redirecting, the ownership will be the ownership of the running
> process unless the file already exists (and the thing to do there is
> to rm -f it first, not to chown it afterwards): and if we're not
> root, chowning isn't going to work anyway (and will abort the
> install).
>
> So take the chown out and replace it with an rm -f in the right place.
Patch withdrawn: Kris's patch is better.
prev parent reply other threads:[~2024-11-11 15:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 10:46 [PATCH] dtprobed: don't chown systemd service files to root during install Nick Alcock
2024-11-11 15:59 ` Nick Alcock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ikst4v8e.fsf@esperi.org.uk \
--to=nick.alcock@oracle.com \
--cc=dtrace-devel@oss.oracle.com \
--cc=dtrace@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.