From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Alexander Lobakin <aleksander.lobakin@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Alexander Lobakin <aleksander.lobakin@intel.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
John Fastabend <john.fastabend@gmail.com>,
Andrii Nakryiko <andrii@kernel.org>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Stanislav Fomichev <sdf@fomichev.me>,
Magnus Karlsson <magnus.karlsson@intel.com>,
nex.sw.ncis.osdt.itp.upstreaming@intel.com, bpf@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 10/18] xdp: get rid of xdp_frame::mem.id
Date: Fri, 01 Nov 2024 14:13:34 +0100 [thread overview]
Message-ID: <87ikt79jwh.fsf@toke.dk> (raw)
In-Reply-To: <20241030165201.442301-11-aleksander.lobakin@intel.com>
Alexander Lobakin <aleksander.lobakin@intel.com> writes:
> Initially, xdp_frame::mem.id was used to search for the corresponding
> &page_pool to return the page correctly.
> However, after that struct page now contains a direct pointer to its PP,
> further keeping of this field makes no sense. xdp_return_frame_bulk()
> still uses it to do a lookup, but this is rather a leftover.
> Remove xdp_frame::mem and replace it with ::mem_type, as only memory
> type still matters and we need to know it to be able to free the frame
> correctly.
> As a cute side effect, we can now make every scalar field in &xdp_frame
> of 4 byte width, speeding up accesses to them.
>
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
Reviewed-by: Toke Høiland-Jørgensen <toke@redhat.com>
next prev parent reply other threads:[~2024-11-01 13:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 16:51 [PATCH net-next v3 00/18] xdp: a fistful of generic changes (+libeth_xdp) Alexander Lobakin
2024-10-30 16:51 ` [PATCH net-next v3 01/18] jump_label: export static_key_slow_{inc,dec}_cpuslocked() Alexander Lobakin
2024-10-30 16:51 ` [PATCH net-next v3 02/18] skbuff: allow 2-4-argument skb_frag_dma_map() Alexander Lobakin
2024-10-30 16:51 ` [PATCH net-next v3 03/18] unroll: add generic loop unroll helpers Alexander Lobakin
2024-10-30 16:51 ` [PATCH net-next v3 04/18] bpf, xdp: constify some bpf_prog * function arguments Alexander Lobakin
2024-11-01 11:46 ` Toke Høiland-Jørgensen
2024-10-30 16:51 ` [PATCH net-next v3 05/18] xdp, xsk: constify read-only arguments of some static inline helpers Alexander Lobakin
2024-11-01 11:47 ` Toke Høiland-Jørgensen
2024-10-30 16:51 ` [PATCH net-next v3 06/18] xdp: allow attaching already registered memory model to xdp_rxq_info Alexander Lobakin
2024-11-01 11:51 ` Toke Høiland-Jørgensen
2024-10-30 16:51 ` [PATCH net-next v3 07/18] xdp: register system page pool as an XDP memory model Alexander Lobakin
2024-10-30 16:51 ` [PATCH net-next v3 08/18] page_pool: make page_pool_put_page_bulk() actually handle array of pages Alexander Lobakin
2024-11-01 11:55 ` Toke Høiland-Jørgensen
2024-10-30 16:51 ` [PATCH net-next v3 09/18] page_pool: allow mixing PPs within one bulk Alexander Lobakin
2024-11-01 13:09 ` Toke Høiland-Jørgensen
2024-11-04 14:32 ` Alexander Lobakin
2024-11-04 16:22 ` Toke Høiland-Jørgensen
2024-10-30 16:51 ` [PATCH net-next v3 10/18] xdp: get rid of xdp_frame::mem.id Alexander Lobakin
2024-11-01 0:41 ` Jakub Kicinski
2024-11-04 14:36 ` Alexander Lobakin
2024-11-05 2:59 ` Jakub Kicinski
2024-11-01 13:13 ` Toke Høiland-Jørgensen [this message]
2024-10-30 16:51 ` [PATCH net-next v3 11/18] xdp: add generic xdp_buff_add_frag() Alexander Lobakin
2024-10-30 16:51 ` [PATCH net-next v3 12/18] xdp: add generic xdp_build_skb_from_buff() Alexander Lobakin
2024-11-01 13:18 ` Toke Høiland-Jørgensen
2024-11-04 14:39 ` Alexander Lobakin
2024-10-30 16:51 ` [PATCH net-next v3 13/18] xsk: allow attaching XSk pool via xdp_rxq_info_reg_mem_model() Alexander Lobakin
2024-11-01 13:20 ` Toke Høiland-Jørgensen
2024-10-30 16:51 ` [PATCH net-next v3 14/18] xsk: make xsk_buff_add_frag really add a frag via __xdp_buff_add_frag() Alexander Lobakin
2024-10-30 16:51 ` [PATCH net-next v3 15/18] xsk: add generic XSk &xdp_buff -> skb conversion Alexander Lobakin
2024-10-30 16:51 ` [PATCH net-next v3 16/18] xsk: add helper to get &xdp_desc's DMA and meta pointer in one go Alexander Lobakin
2024-10-30 16:52 ` [PATCH net-next v3 17/18] libeth: support native XDP and register memory model Alexander Lobakin
2024-10-30 16:52 ` [PATCH net-next v3 18/18] libeth: add a couple of XDP helpers (libeth_xdp) Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ikt79jwh.fsf@toke.dk \
--to=toke@redhat.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nex.sw.ncis.osdt.itp.upstreaming@intel.com \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.