From: Kalle Valo <kvalo@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Jeff Johnson <quic_jjohnson@quicinc.com>,
Jeff Johnson <jjohnson@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-firmware@kernel.org, ath11k@lists.infradead.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [RFC PULL] ath11k: move WCN6750 firmware to the device-specific subdir
Date: Mon, 28 Oct 2024 19:37:01 +0200 [thread overview]
Message-ID: <87iktcgmde.fsf@kernel.org> (raw)
In-Reply-To: <CAA8EJppAiktoPk9hZnDdj5igZ9-D0229WRfwg08y8CPnwerx-g@mail.gmail.com> (Dmitry Baryshkov's message of "Mon, 21 Oct 2024 21:34:27 +0300")
Dmitry Baryshkov <dmitry.baryshkov@linaro.org> writes:
> On Mon, 21 Oct 2024 at 21:22, Kalle Valo <kvalo@kernel.org> wrote:
>
>>
>> Jeff Johnson <quic_jjohnson@quicinc.com> writes:
>>
>> >> Dmitry Baryshkov (1):
>> >> ath11k: move WCN6750 firmware to the device-specific subdir
>> >>
>> >> WHENCE | 12 ++----------
>> >> ath11k/WCN6750/hw1.0/{wpss.b04 => sc7280/wpss.mbn} | Bin 5819999 -> 7463728 bytes
>> >> ath11k/WCN6750/hw1.0/wpss.b00 | Bin 340 -> 0 bytes
>> >> ath11k/WCN6750/hw1.0/wpss.b01 | Bin 6848 -> 0 bytes
>> >> ath11k/WCN6750/hw1.0/wpss.b02 | Bin 10300 -> 0 bytes
>> >> ath11k/WCN6750/hw1.0/wpss.b03 | Bin 4096 -> 0 bytes
>> >> ath11k/WCN6750/hw1.0/wpss.b05 | Bin 164332 -> 0 bytes
>> >> ath11k/WCN6750/hw1.0/wpss.b06 | Bin 266684 -> 0 bytes
>> >> ath11k/WCN6750/hw1.0/wpss.b07 | Bin 1176368 -> 0 bytes
>> >> ath11k/WCN6750/hw1.0/wpss.b08 | 0
>> >> ath11k/WCN6750/hw1.0/wpss.mdt | Bin 7188 -> 0 bytes
>> >> 11 files changed, 2 insertions(+), 10 deletions(-)
>> >> rename ath11k/WCN6750/hw1.0/{wpss.b04 => sc7280/wpss.mbn} (77%)
>>
>> So this follow basically the same directory hierarchy as you Dmitry
>> implemented for ath10k in commit 5abf259772df ("wifi: ath10k: support
>> board-specific firmware overrides"), right? Just making sure we are on
>> the same page. I think ath10k/ath11k/ath12k drivers should follow the
>> same design as much as possible.
>
> Yes, that was my goal. Having subdirs under the main dir.
Very good.
>> >> delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b00
>> >> delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b01
>> >> delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b02
>> >> delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b03
>> >> delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b05
>> >> delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b06
>> >> delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b07
>> >> delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b08
>> >> delete mode 100644 ath11k/WCN6750/hw1.0/wpss.mdt
>> >
>> > I'm waiting for Kalle to respond, but at a minimum I suspect our internal
>> > firmware tooling would be impacted by this change.
>>
>> Yeah, most likely we need to update our tools. But we would have to do
>> it anyway so I'm not concerned about that.
>
> Ok. If there are no concerns from your side, could you possibly
> respond with Acked-by? Then we can unblock and merge this.
Sure:
Acked-by: Kalle Valo <kvalo@kernel.org>
>> > Kalle, do you have concerns or suggestions on how to handle this issue?
>>
>> Looks good to me.
>>
>> Dmitry, if you have the time please take a look at this:
>>
>> https://patchwork.kernel.org/project/linux-wireless/cover/20241001033053.2084360-1-quic_miaoqing@quicinc.com/
>>
>> Based on a quick look it seems to do things differently and not really a
>> fan of that.
>
> Yes, I'd prefer a subdir rather than this implementation. I'll respond
> either today or tomorrow.
Thanks a lot, I appreciate you helping us.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2024-10-28 17:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 6:16 [RFC PULL] ath11k: move WCN6750 firmware to the device-specific subdir Dmitry Baryshkov
2024-10-18 22:16 ` Jeff Johnson
2024-10-21 18:22 ` Kalle Valo
2024-10-21 18:34 ` Dmitry Baryshkov
2024-10-28 17:37 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iktcgmde.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=andersson@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jjohnson@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-firmware@kernel.org \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.