From: Sam James <sam@gentoo.org>
To: Eder Zulian <ezulian@redhat.com>
Cc: acme@redhat.com, andrii@kernel.org, ast@kernel.org,
bpf@vger.kernel.org, daniel@iogearbox.net, eddyz87@gmail.com,
haoluo@google.com, john.fastabend@gmail.com, jolsa@kernel.org,
kpsingh@kernel.org, linux-kernel@vger.kernel.org,
martin.lau@linux.dev, sdf@fomichev.me, song@kernel.org,
vmalik@redhat.com, williams@redhat.com, yonghong.song@linux.dev,
"Michael Weiß" <michael.weiss@aisec.fraunhofer.de>
Subject: Re: [PATCH] tools/resolve_btfids: Fix 'variable' may be used uninitialized warnings
Date: Mon, 14 Oct 2024 01:58:06 +0100 [thread overview]
Message-ID: <87iktvlcv5.fsf@gentoo.org> (raw)
In-Reply-To: <Zwoub8GniNhTF1gu@f39> (Eder Zulian's message of "Sat, 12 Oct 2024 10:08:15 +0200")
Eder Zulian <ezulian@redhat.com> writes:
> Hi Sam, thank you for pointing it out.
>
> On Sat, Oct 12, 2024 at 05:14:29AM +0100, Sam James wrote:
>> The parse-options change was sent before as
>> https://lore.kernel.org/all/20240731085217.94928-1-michael.weiss@aisec.fraunhofer.de/
>
> Sorry, I missed Michael's patch.
> My suggestion is to initialize 'o' to NULL instead. An illegal dereferencing
> (if any) would then be evident.
Yeah, I was wondering the same.
>
>> but seems to have fallen through the cracks.
>>
>>
> Would it be better to revert this part and wait a bit for Michael's patch to
> be merged, please let me know.
I'll defer to the maintainers.
>
> Thank you,
> Eder
next prev parent reply other threads:[~2024-10-14 0:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 20:00 [PATCH] tools/resolve_btfids: Fix 'variable' may be used uninitialized warnings Eder Zulian
2024-10-12 4:14 ` Sam James
2024-10-12 8:08 ` Eder Zulian
2024-10-14 0:58 ` Sam James [this message]
2024-10-14 11:17 ` Viktor Malik
2024-10-14 22:34 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iktvlcv5.fsf@gentoo.org \
--to=sam@gentoo.org \
--cc=acme@redhat.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=ezulian@redhat.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=michael.weiss@aisec.fraunhofer.de \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=vmalik@redhat.com \
--cc=williams@redhat.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.