All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org,  linux-wireless@vger.kernel.org
Subject: Re: pull-request: wireless-next-2024-09-11
Date: Thu, 12 Sep 2024 01:29:53 +0300	[thread overview]
Message-ID: <87ikv1bz8e.fsf@kernel.org> (raw)
In-Reply-To: <20240911134521.7f510329@kernel.org> (Jakub Kicinski's message of "Wed, 11 Sep 2024 13:45:21 -0700")

Jakub Kicinski <kuba@kernel.org> writes:

> On Wed, 11 Sep 2024 08:41:47 +0000 (UTC) Kalle Valo wrote:
>> here's a pull request to net-next tree, more info below. Please let me know if
>> there are any problems.
>
> For a follow up, clang W=1 says:
>
> ../drivers/net/wireless/realtek/rtw89/coex.c:6323:23: warning:
> variable 'cnt_2g' set but not used [-Wunused-but-set-variable]
>  6323 |         u8 i, mode, cnt = 0, cnt_2g = 0, cnt_5g = 0, phy_now = RTW89_PHY_MAX, phy_dbcc;
>       |                              ^
> ../drivers/net/wireless/realtek/rtw89/coex.c:6323:35: warning:
> variable 'cnt_5g' set but not used [-Wunused-but-set-variable]
>  6323 |         u8 i, mode, cnt = 0, cnt_2g = 0, cnt_5g = 0, phy_now = RTW89_PHY_MAX, phy_dbcc;
>       |                                          ^
> 2 warnings generated.
> ../drivers/staging/rtl8712/rtl8712_recv.c:139:6: warning: variable
> 'drvinfo_sz' set but not used [-Wunused-but-set-variable]
>   139 |         u16 drvinfo_sz;
>       |             ^
> 1 warning generated.
> ../drivers/staging/rtl8723bs/core/rtw_efuse.c:285:6: warning: variable
> 'efuseValue' set but not used [-Wunused-but-set-variable]
>   285 |         u32 efuseValue;
>       |             ^
> 1 warning generated.
> ../drivers/staging/rtl8723bs/core/rtw_recv.c:2030:7: warning: variable
> 'cnt' set but not used [-Wunused-but-set-variable]
>  2030 |                 int cnt = 0;
>       |                     ^
> 1 warning generated.
> ../drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:288:6: warning:
> variable 'poll_cnt' set but not used [-Wunused-but-set-variable]
>   288 |                 u8 poll_cnt = 0;
>       |                    ^

What's the deadline for these? Do you need the fixes tomorrow or can it
wait a week or two?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2024-09-11 22:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-11  8:41 pull-request: wireless-next-2024-09-11 Kalle Valo
2024-09-11 20:45 ` Jakub Kicinski
2024-09-11 22:29   ` Kalle Valo [this message]
2024-09-11 22:36     ` Jakub Kicinski
2024-09-11 22:38       ` Jakub Kicinski
2024-09-12  2:33         ` Ping-Ke Shih
2024-09-12  6:28           ` Kalle Valo
2024-09-12  6:33             ` Ping-Ke Shih
2024-09-11 22:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ikv1bz8e.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.