From: Markus Armbruster <armbru@redhat.com>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Kashyap Chamarthy" <kchamart@redhat.com>,
qemu-devel@nongnu.org, "Kevin Wolf" <kwolf@redhat.com>,
"Hanna Czenczek" <hreitz@redhat.com>
Subject: Re: [PATCH v6 1/4] docs/interop/firmware.json: add new enum FirmwareFormat
Date: Fri, 19 Jul 2024 14:33:51 +0200 [thread overview]
Message-ID: <87ikx1tvbk.fsf@pond.sub.org> (raw)
In-Reply-To: <20240719-qapi-firmware-json-v6-1-c2e3de390b58@linutronix.de> ("Thomas Weißschuh"'s message of "Fri, 19 Jul 2024 09:37:22 +0200")
Thomas Weißschuh <thomas.weissschuh@linutronix.de> writes:
> Only a small subset of all blockdev drivers make sense for firmware
> images. Introduce and use a new enum to represent this.
>
> This also reduces the dependency on firmware.json from the global qapi
> definitions.
>
> Claim "Since: 3.0" for the new enum, because that's correct for its
> members, and the members are what matters in the interface.
>
> Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2024-07-19 12:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 7:37 [PATCH v6 0/4] docs/interop/firmware.json: scripts/qapi-gen.py compatibility Thomas Weißschuh
2024-07-19 7:37 ` [PATCH v6 1/4] docs/interop/firmware.json: add new enum FirmwareFormat Thomas Weißschuh
2024-07-19 12:33 ` Markus Armbruster [this message]
2024-07-19 7:37 ` [PATCH v6 2/4] docs/interop/firmware.json: add new enum FirmwareArchitecture Thomas Weißschuh
2024-07-19 12:32 ` Markus Armbruster
2024-07-19 7:37 ` [PATCH v6 3/4] docs/interop/firmware.json: convert "Example" section Thomas Weißschuh
2024-07-19 7:37 ` [PATCH v6 4/4] docs: add test for firmware.json QAPI Thomas Weißschuh
2024-07-19 12:38 ` Markus Armbruster
2024-07-22 22:15 ` Philippe Mathieu-Daudé
2024-07-23 6:32 ` Thomas Weißschuh
2024-07-19 13:06 ` [PATCH v6 0/4] docs/interop/firmware.json: scripts/qapi-gen.py compatibility Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ikx1tvbk.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=hreitz@redhat.com \
--cc=kchamart@redhat.com \
--cc=kwolf@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.