From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38F9C2B9BE; Sun, 2 Jun 2024 13:53:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717336385; cv=none; b=a3a0IPGrcEJbcfBcZHaZ9rclXl5nvxOjk1WOS/RVOvKpTK+RptOp8d2mmCUTY2cHWEB9tIexjJzTbDFmctNUr6GVBFQZjIuLN2EIg2Si3FCpyprNNRQbuc+lw/13xchnCaGBW4ALNRcP5lO3H/kFyFzwHYXImfgW0moHqNtTp6c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717336385; c=relaxed/simple; bh=DeL5aeSA5tvcVCR2KVHhivWXgJ21YbHHOT6rNYrcTrw=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=m2UZBVlXpAU5NLCP9Db9gnxW3OhDurnK07D3y5bzCTclBzqTtfTlxP30f8+IapRknHuN1Q41rCcWvesojVQSO023EQ7Pc47+UjC4u4KixBWBCxy9tiMByLccpC4M3y1z/AeaYgfT9efi6sFm98FmC8Fzp+XoH8P0j3GtFI5Js8c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ppHRVVz+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ppHRVVz+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A19C5C2BBFC; Sun, 2 Jun 2024 13:53:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717336384; bh=DeL5aeSA5tvcVCR2KVHhivWXgJ21YbHHOT6rNYrcTrw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ppHRVVz+0PtvG8TMK054YMKaO989L5de2R+5klqf3WnUm6UADjkIf4HPjx7DigvI1 uLCe934prVquN6n8DGXkBdvh6kfbmDyFiwdv2RmFDIHn/RuQ/PBXmNbkAcp0Vtt41a iS2UzoTJhHhVScZEKY028TSq82FGtZzR1k4dZjgNkJRmNy8cUWWTw30KFsGw71LTfH kr1bc2fSButlekEwjT0eig4PL+WJL24SxAwwZbxNgAxr11pk/jxC3A4Dj55ocC7Vwa wlY1wjmmyk3ojnOty1ONIOJjbOHAzaHheR/8k1O6mBrSm9yn2UisoEccEoFx+L5x/Z TgBVXbFTQPRsw== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sDldu-00HZRE-3k; Sun, 02 Jun 2024 14:53:02 +0100 Date: Sun, 02 Jun 2024 14:53:02 +0100 Message-ID: <87ikyr30zl.wl-maz@kernel.org> From: Marc Zyngier To: yu harry Cc: corbet@lwn.net, catalin.marinas@arm.com, will@kernel.org, tglx@linutronix.de, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] irqchip/gic-v3: Add Allwinner sunxi001 erratum workaround In-Reply-To: References: <20240602071058.6405-1-harry.yu185@gmail.com> <86o78jlms2.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: harry.yu185@gmail.com, corbet@lwn.net, catalin.marinas@arm.com, will@kernel.org, tglx@linutronix.de, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Sun, 02 Jun 2024 14:23:43 +0100, yu harry wrote: >=20 > On Sun, Jun 2, 2024 at 5:25=E2=80=AFPM Marc Zyngier wrot= e: > > > > On Sun, 02 Jun 2024 08:10:58 +0100, > > "harry.yu185" wrote: > > > > > > Allwinner A523 GIC600 integration does not support the > > > sharability feature. So assigned Erratum ID #sunxi001 for this > > > issue. > > > > > > That the 0x0201643b ID is not Allwinner specific and thus > > > there is an extra of_machine_is_compatible() check. > > > > > > Note, because more than one soc may have this problem, the 'sunxi' > > > name is used instead of a fixed soc name like A523. > > > > > > Signed-off-by: harry.yu185 > > > > No, this is all already handled by the driver already (since 6.6). > > > > Please fix your DT to include the "dma-noncoherent" property in the > > GIC and ITS nodes, which should paper over the integration bug. > > > > Thanks, > > > > M. > > > > -- > > Without deviation from the norm, progress is not possible. >=20 > Thank you for your reply, > the method you said may not be suitable, because this SOC > also needs RDIST_FLAGS_FORCE_NON_SHAREABLE, > just like RK3588, but it is different from the RK3588 version. Who is talking of RK3588? Have you read what I wrote? Have you actually looked at what these attributes do? For context, here's what you're proposing: +static bool __maybe_unused its_enable_sunxi001(void *data) +{ + struct its_node *its =3D data; + + if (!of_machine_is_compatible("arm,sun55iw3p1")) + return false; + + its->flags |=3D ITS_FLAGS_FORCE_NON_SHAREABLE; + gic_rdists->flags |=3D RDIST_FLAGS_FORCE_NON_SHAREABLE; + + return true; +} + "dma-noncoherent" on the GIC node provides: static bool rd_set_non_coherent(void *data) { struct gic_chip_data *d =3D data; d->rdists.flags |=3D RDIST_FLAGS_FORCE_NON_SHAREABLE; return true; } "dma-noncoherent" on the ITS node provides: static bool its_set_non_coherent(void *data) { struct its_node *its =3D data; its->flags |=3D ITS_FLAGS_FORCE_NON_SHAREABLE; return true; } So please do explain how the combination of the two isn't equivalent to your patch. How does it fail to provide the required workaround? M. --=20 Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8609C25B74 for ; Sun, 2 Jun 2024 13:53:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ApN3adDGIARIubxuNKdId8/c2+Rk/xt+9TZatc/ZHf4=; b=2OlODW32Ys8d9X ExR2vZnl9SHXsWoRyq22wf/kU8VmhZFp4ijsBz4AGriVVPJFskMTebNb3cwmqZ7KCeFCbZiGRT9en CLGKbvuoASGbq1TXDg4Oy6r/BZ7Sd6CUwjxppwQZKL/62S728W/wDUzgQ/zQ0Fpg69YTlYK09NMPE BoUN4/9W4grt8ixqTCa5mXLso1EsI1t02Se9ZTTPvKyZUonyJ7+78tlfiNgzM8trc9U7pqYaY3C5E QcMDu+p9LNeu3gGt/BwTJRtJcXwKATt1coihV7WbcuLoXy6M3exKEXq6uflNlLMM6sW/DFBR4xu8H /fklBI/ohmYbr5y4IYzw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sDle0-0000000EKgj-0cUc; Sun, 02 Jun 2024 13:53:08 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sDldy-0000000EKg7-0abI for linux-arm-kernel@lists.infradead.org; Sun, 02 Jun 2024 13:53:07 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2987E60B98; Sun, 2 Jun 2024 13:53:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A19C5C2BBFC; Sun, 2 Jun 2024 13:53:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717336384; bh=DeL5aeSA5tvcVCR2KVHhivWXgJ21YbHHOT6rNYrcTrw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ppHRVVz+0PtvG8TMK054YMKaO989L5de2R+5klqf3WnUm6UADjkIf4HPjx7DigvI1 uLCe934prVquN6n8DGXkBdvh6kfbmDyFiwdv2RmFDIHn/RuQ/PBXmNbkAcp0Vtt41a iS2UzoTJhHhVScZEKY028TSq82FGtZzR1k4dZjgNkJRmNy8cUWWTw30KFsGw71LTfH kr1bc2fSButlekEwjT0eig4PL+WJL24SxAwwZbxNgAxr11pk/jxC3A4Dj55ocC7Vwa wlY1wjmmyk3ojnOty1ONIOJjbOHAzaHheR/8k1O6mBrSm9yn2UisoEccEoFx+L5x/Z TgBVXbFTQPRsw== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sDldu-00HZRE-3k; Sun, 02 Jun 2024 14:53:02 +0100 Date: Sun, 02 Jun 2024 14:53:02 +0100 Message-ID: <87ikyr30zl.wl-maz@kernel.org> From: Marc Zyngier To: yu harry Cc: corbet@lwn.net, catalin.marinas@arm.com, will@kernel.org, tglx@linutronix.de, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] irqchip/gic-v3: Add Allwinner sunxi001 erratum workaround In-Reply-To: References: <20240602071058.6405-1-harry.yu185@gmail.com> <86o78jlms2.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: harry.yu185@gmail.com, corbet@lwn.net, catalin.marinas@arm.com, will@kernel.org, tglx@linutronix.de, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240602_065306_336447_B2F410BE X-CRM114-Status: GOOD ( 25.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU3VuLCAwMiBKdW4gMjAyNCAxNDoyMzo0MyArMDEwMCwKeXUgaGFycnkgPGhhcnJ5Lnl1MTg1 QGdtYWlsLmNvbT4gd3JvdGU6Cj4gCj4gT24gU3VuLCBKdW4gMiwgMjAyNCBhdCA1OjI14oCvUE0g TWFyYyBaeW5naWVyIDxtYXpAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPgo+ID4gT24gU3VuLCAwMiBK dW4gMjAyNCAwODoxMDo1OCArMDEwMCwKPiA+ICJoYXJyeS55dTE4NSIgPGhhcnJ5Lnl1MTg1QGdt YWlsLmNvbT4gd3JvdGU6Cj4gPiA+Cj4gPiA+IEFsbHdpbm5lciBBNTIzIEdJQzYwMCBpbnRlZ3Jh dGlvbiBkb2VzIG5vdCBzdXBwb3J0IHRoZQo+ID4gPiBzaGFyYWJpbGl0eSBmZWF0dXJlLiBTbyBh c3NpZ25lZCBFcnJhdHVtIElEICNzdW54aTAwMSBmb3IgdGhpcwo+ID4gPiBpc3N1ZS4KPiA+ID4K PiA+ID4gVGhhdCB0aGUgMHgwMjAxNjQzYiBJRCBpcyBub3QgQWxsd2lubmVyIHNwZWNpZmljIGFu ZCB0aHVzCj4gPiA+IHRoZXJlIGlzIGFuIGV4dHJhIG9mX21hY2hpbmVfaXNfY29tcGF0aWJsZSgp IGNoZWNrLgo+ID4gPgo+ID4gPiBOb3RlLCBiZWNhdXNlIG1vcmUgdGhhbiBvbmUgc29jIG1heSBo YXZlIHRoaXMgcHJvYmxlbSwgdGhlICdzdW54aScKPiA+ID4gbmFtZSBpcyB1c2VkIGluc3RlYWQg b2YgYSBmaXhlZCBzb2MgbmFtZSBsaWtlIEE1MjMuCj4gPiA+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6 IGhhcnJ5Lnl1MTg1IDxoYXJyeS55dTE4NUBnbWFpbC5jb20+Cj4gPgo+ID4gTm8sIHRoaXMgaXMg YWxsIGFscmVhZHkgaGFuZGxlZCBieSB0aGUgZHJpdmVyIGFscmVhZHkgKHNpbmNlIDYuNikuCj4g Pgo+ID4gUGxlYXNlIGZpeCB5b3VyIERUIHRvIGluY2x1ZGUgdGhlICJkbWEtbm9uY29oZXJlbnQi IHByb3BlcnR5IGluIHRoZQo+ID4gR0lDIGFuZCBJVFMgbm9kZXMsIHdoaWNoIHNob3VsZCBwYXBl ciBvdmVyIHRoZSBpbnRlZ3JhdGlvbiBidWcuCj4gPgo+ID4gVGhhbmtzLAo+ID4KPiA+ICAgICAg ICAgTS4KPiA+Cj4gPiAtLQo+ID4gV2l0aG91dCBkZXZpYXRpb24gZnJvbSB0aGUgbm9ybSwgcHJv Z3Jlc3MgaXMgbm90IHBvc3NpYmxlLgo+IAo+IFRoYW5rIHlvdSBmb3IgeW91ciByZXBseSwKPiB0 aGUgbWV0aG9kIHlvdSBzYWlkIG1heSBub3QgYmUgc3VpdGFibGUsIGJlY2F1c2UgdGhpcyBTT0MK PiBhbHNvIG5lZWRzIFJESVNUX0ZMQUdTX0ZPUkNFX05PTl9TSEFSRUFCTEUsCj4ganVzdCBsaWtl IFJLMzU4OCwgYnV0IGl0IGlzIGRpZmZlcmVudCBmcm9tIHRoZSBSSzM1ODggdmVyc2lvbi4KCldo byBpcyB0YWxraW5nIG9mIFJLMzU4OD8gSGF2ZSB5b3UgcmVhZCB3aGF0IEkgd3JvdGU/IEhhdmUg eW91CmFjdHVhbGx5IGxvb2tlZCBhdCB3aGF0IHRoZXNlIGF0dHJpYnV0ZXMgZG8/CgpGb3IgY29u dGV4dCwgaGVyZSdzIHdoYXQgeW91J3JlIHByb3Bvc2luZzoKCitzdGF0aWMgYm9vbCBfX21heWJl X3VudXNlZCBpdHNfZW5hYmxlX3N1bnhpMDAxKHZvaWQgKmRhdGEpCit7CisJc3RydWN0IGl0c19u b2RlICppdHMgPSBkYXRhOworCisJaWYgKCFvZl9tYWNoaW5lX2lzX2NvbXBhdGlibGUoImFybSxz dW41NWl3M3AxIikpCisJCXJldHVybiBmYWxzZTsKKworCWl0cy0+ZmxhZ3MgfD0gSVRTX0ZMQUdT X0ZPUkNFX05PTl9TSEFSRUFCTEU7CisJZ2ljX3JkaXN0cy0+ZmxhZ3MgfD0gUkRJU1RfRkxBR1Nf Rk9SQ0VfTk9OX1NIQVJFQUJMRTsKKworCXJldHVybiB0cnVlOworfQorCgoiZG1hLW5vbmNvaGVy ZW50IiBvbiB0aGUgR0lDIG5vZGUgcHJvdmlkZXM6CgpzdGF0aWMgYm9vbCByZF9zZXRfbm9uX2Nv aGVyZW50KHZvaWQgKmRhdGEpCnsKCXN0cnVjdCBnaWNfY2hpcF9kYXRhICpkID0gZGF0YTsKCglk LT5yZGlzdHMuZmxhZ3MgfD0gUkRJU1RfRkxBR1NfRk9SQ0VfTk9OX1NIQVJFQUJMRTsKCXJldHVy biB0cnVlOwp9CgoiZG1hLW5vbmNvaGVyZW50IiBvbiB0aGUgSVRTIG5vZGUgcHJvdmlkZXM6Cgpz dGF0aWMgYm9vbCBpdHNfc2V0X25vbl9jb2hlcmVudCh2b2lkICpkYXRhKQp7CglzdHJ1Y3QgaXRz X25vZGUgKml0cyA9IGRhdGE7CgoJaXRzLT5mbGFncyB8PSBJVFNfRkxBR1NfRk9SQ0VfTk9OX1NI QVJFQUJMRTsKCXJldHVybiB0cnVlOwp9CgpTbyBwbGVhc2UgZG8gZXhwbGFpbiBob3cgdGhlIGNv bWJpbmF0aW9uIG9mIHRoZSB0d28gaXNuJ3QgZXF1aXZhbGVudAp0byB5b3VyIHBhdGNoLiBIb3cg ZG9lcyBpdCBmYWlsIHRvIHByb3ZpZGUgdGhlIHJlcXVpcmVkIHdvcmthcm91bmQ/CgoJTS4KCi0t IApXaXRob3V0IGRldmlhdGlvbiBmcm9tIHRoZSBub3JtLCBwcm9ncmVzcyBpcyBub3QgcG9zc2li bGUuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg==