All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org,
	 Johannes Berg <johannes.berg@intel.com>,
	 Miriam Rachel Korenblit <miriam.rachel.korenblit@intel.com>
Subject: Re: [PATCH 4/5] wifi: mac80211: pass parsed TPE data to drivers
Date: Wed, 15 May 2024 16:16:06 +0300	[thread overview]
Message-ID: <87ikzfcj1l.fsf@kernel.org> (raw)
In-Reply-To: <20240506214536.2aa839969b60.I265b28209e0b29772b2f125f7f83de44a4da877b@changeid> (Johannes Berg's message of "Mon, 6 May 2024 21:37:56 +0200")

Johannes Berg <johannes@sipsolutions.net> writes:

> From: Johannes Berg <johannes.berg@intel.com>
>
> Instead of passing the full TPE elements, in all their glory
> and mixed up data formats for HE backward compatibility, parse
> them fully into the right values, and pass that to the drivers.
>
> Also introduce proper validation already in mac80211, so that
> drivers don't need to do it, and parse the EHT portions.
>
> The code now passes the values in the right order according to
> the channel used by an interface, which could also be a subset
> of the data advertised by the AP, if we couldn't connect with
> the full bandwidth (for whatever reason.)
>
> Also add kunit tests for the more complicated bits of it.
>
> Reviewed-by: Miriam Rachel Korenblit <miriam.rachel.korenblit@intel.com>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

Very nice, thanks for cleaning this up! Unfortunately I don't have right
now any means to test this but for ath11k changes:

Acked-by: Kalle Valo <kvalo@kernel.org>

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2024-05-15 13:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-06 19:37 [PATCH 0/5] wifi: mac80211: build TPE handling Johannes Berg
2024-05-06 19:37 ` [PATCH 1/5] wifi: mac80211: update 6 GHz AP power type before association Johannes Berg
2024-05-06 19:37 ` [PATCH 2/5] wifi: ieee80211/ath11k: remove IEEE80211_MAX_NUM_PWR_LEVEL Johannes Berg
2024-05-15 13:11   ` Kalle Valo
2024-05-06 19:37 ` [PATCH 3/5] wifi: ath11k: fix TPE power levels Johannes Berg
2024-05-15 13:12   ` Kalle Valo
2024-05-06 19:37 ` [PATCH 4/5] wifi: mac80211: pass parsed TPE data to drivers Johannes Berg
2024-05-15 13:16   ` Kalle Valo [this message]
2024-05-06 19:37 ` [PATCH 5/5] wifi: mac80211: track changes in AP's TPE Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ikzfcj1l.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=johannes.berg@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=miriam.rachel.korenblit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.