From: "Peter Münster" <pm@a16n.net>
To: Michael Chan <michael.chan@broadcom.com>
Cc: netdev@vger.kernel.org
Subject: Re: kernel panic with b44 and netifd
Date: Wed, 03 Apr 2024 17:50:24 +0200 [thread overview]
Message-ID: <87il0ye98f.fsf@a16n.net> (raw)
In-Reply-To: <CACKFLikqEyAQf-2DxbAnKSFbvTP9Wj=X1Yr1ff6LzZ13T6OZ6w@mail.gmail.com> (Michael Chan's message of "Wed, 3 Apr 2024 07:53:09 -0700")
[-- Attachment #1.1: Type: text/plain, Size: 285 bytes --]
On Wed, Apr 03 2024, Michael Chan wrote:
> please post the patch to netdev for review.
Ok, please find it here attached.
And please consider also KanjiMonster’s comment here:
https://github.com/openwrt/openwrt/issues/13789#issuecomment-2034601851
--
Peter
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: b44.patch --]
[-- Type: text/x-patch, Size: 831 bytes --]
--- build_dir/target-mipsel_mips32_musl/linux-bcm47xx_legacy/linux-5.15.153/drivers/net/ethernet/broadcom/b44.c~ 2024-04-03 10:04:09.177021530 +0200
+++ build_dir/target-mipsel_mips32_musl/linux-bcm47xx_legacy/linux-5.15.153/drivers/net/ethernet/broadcom/b44.c 2024-04-03 10:46:42.267884445 +0200
@@ -2056,12 +2056,14 @@
bp->flags |= B44_FLAG_TX_PAUSE;
else
bp->flags &= ~B44_FLAG_TX_PAUSE;
- if (bp->flags & B44_FLAG_PAUSE_AUTO) {
- b44_halt(bp);
- b44_init_rings(bp);
- b44_init_hw(bp, B44_FULL_RESET);
- } else {
- __b44_set_flow_ctrl(bp, bp->flags);
+ if (netif_running(dev)) {
+ if (bp->flags & B44_FLAG_PAUSE_AUTO) {
+ b44_halt(bp);
+ b44_init_rings(bp);
+ b44_init_hw(bp, B44_FULL_RESET);
+ } else {
+ __b44_set_flow_ctrl(bp, bp->flags);
+ }
}
spin_unlock_irq(&bp->lock);
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 211 bytes --]
next prev parent reply other threads:[~2024-04-03 15:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 14:13 kernel panic with b44 and netifd Peter Münster
2024-04-03 14:53 ` Michael Chan
2024-04-03 15:50 ` Peter Münster [this message]
2024-04-03 22:00 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il0ye98f.fsf@a16n.net \
--to=pm@a16n.net \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.