From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E22DF168D5; Wed, 20 Dec 2023 07:14:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oltmanns.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oltmanns.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oltmanns.dev header.i=@oltmanns.dev header.b="aqewHPPW" Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4Sw4YS2tHnz9sp6; Wed, 20 Dec 2023 08:14:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oltmanns.dev; s=MBO0001; t=1703056444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5JWAYPuW2w1S4QldNPnKh0l/fjpe1uHU+1lOR2wMdU0=; b=aqewHPPWceld/vN8dMOtuujW1lrzIuiuwJzKUDlrCm/5bgQUqYB3yB3wupaAbprIDdvT3S E0Z4gggq86mbLA9q8ui0llGLXNLQ47UXkdP9lx3NOVL0/k/J9PPq2Q5d+p58OsnUZoADD1 s5FlKWcrSAR0b6vJMSPqWd/Ne/RLgf/FdJyB9G+h9CrsLz1FwWTIGxt+x7kQnTQekWAVBw z5+ACiE/uFS20YhQPE2IsU6qq1kBInaD5p1wvFr+QVkbU5K0FIqhlPAK88oVeTaakhkHaZ bKquYn0TEz46x3Kf3Dwt0d/v03zuyUVCqkL4QucIBwA+dpgdra82zMhkl7P4tg== References: <20231218-pinephone-pll-fixes-v1-0-e238b6ed6dc1@oltmanns.dev> <20231218-pinephone-pll-fixes-v1-4-e238b6ed6dc1@oltmanns.dev> <13411739.uLZWGnKmhe@jernej-laptop> From: Frank Oltmanns To: Jernej =?utf-8?Q?=C5=A0krabec?= Cc: Michael Turquette , Stephen Boyd , Chen-Yu Tsai , Samuel Holland , Guido =?utf-8?Q?G=C3=BCnther?= , Purism Kernel Team , Ondrej Jirman , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 4/5] clk: sunxi-ng: a64: Add constraints on PLL-VIDEO0's n/m ratio Date: Wed, 20 Dec 2023 08:09:28 +0100 In-reply-to: <13411739.uLZWGnKmhe@jernej-laptop> Message-ID: <87il4t9wi1.fsf@oltmanns.dev> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2023-12-19 at 17:54:19 +0100, Jernej =C5=A0krabec wrote: > Dne ponedeljek, 18. december 2023 ob 14:35:22 CET je Frank Oltmanns napis= al(a): >> The Allwinner A64 manual lists the following constraint for the >> PLL-VIDEO0 clock: 8 <=3D N/M <=3D 25 >> >> Use this constraint. >> >> Signed-off-by: Frank Oltmanns >> --- >> drivers/clk/sunxi-ng/ccu-sun50i-a64.c | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c b/drivers/clk/sunxi-n= g/ccu-sun50i-a64.c >> index c034ac027d1c..75d839da446c 100644 >> --- a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c >> +++ b/drivers/clk/sunxi-ng/ccu-sun50i-a64.c >> @@ -68,7 +68,8 @@ static SUNXI_CCU_NM_WITH_SDM_GATE_LOCK(pll_audio_base_= clk, "pll-audio-base", >> BIT(28), /* lock */ >> CLK_SET_RATE_UNGATE); >> >> -static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_CLOSEST(pll_video0_clk,= "pll-video0", >> +static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_FEAT_NM_RATIO(pll_video= 0_clk, >> + "pll-video0", >> "osc24M", 0x010, >> 192000000, /* Minimum rate */ >> 1008000000, /* Maximum rate */ >> @@ -80,7 +81,10 @@ static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_CLOSE= ST(pll_video0_clk, "pll-vid >> 297000000, /* frac rate 1 */ >> BIT(31), /* gate */ >> BIT(28), /* lock */ >> - CLK_SET_RATE_UNGATE); >> + CLK_SET_RATE_UNGATE, >> + CCU_FEATURE_FRACTIONAL | >> + CCU_FEATURE_CLOSEST_RATE, > > Above flags are unrelated change, put them in new patch if needed. You might notice that I am using a new macro for initializing the pll_video0_clk struct: New: SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_FEAT_NM_RATIO Old: SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_CLOSEST Setting the two CCU_FEATURE flags is part of the old initialization macro. I'll add SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_NM_RATIO_CLOSEST which hopefully resolves the confusion. Thanks, Frank > > Best regards, > Jernej > >> + 8, 25); /* min/max nm ratio */ >> >> static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK(pll_ve_clk, "pll-ve", >> "osc24M", 0x018, >> >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A951C3DA6E for ; Wed, 20 Dec 2023 07:14:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JQGJ8DaLDDhxH/CmWQT45Vxsau6H1BgE7UevgjQawGs=; b=Z7MBPN8N1fSBf2 1v5QOgq0mp4kiiaEoIAs4eZ5BMB9p2Hm+mQ6KGPLu0XbEDEVZy07rOxTJwpP6R8NaGRzkLMDWYaM+ sm8KFVFTwh8aKvIox/DZbz3jNf8sgBZqdYcVzIpPDiudckP5FimlK96Kj2u+X5M51np5BH4I+bllc 4b2oOmPo3gYLCM1bICbl5D1ueTlmreMjZEyjV9MocAPyqvYLBUnMy08jpUB18zrkFSyIj16c6SCr8 YwPxSO7kshue4X9+Bx2r+c6vPq8g8Pl507heojMKA4/EHNMm7YwbVDO19DM6u73ekraRNzbE5SJb5 y54C9oE0EH0dsWeZYS8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFqmT-00GNKw-2F; Wed, 20 Dec 2023 07:14:14 +0000 Received: from mout-p-202.mailbox.org ([2001:67c:2050:0:465::202]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFqmQ-00GNIo-0c for linux-arm-kernel@lists.infradead.org; Wed, 20 Dec 2023 07:14:12 +0000 Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4Sw4YS2tHnz9sp6; Wed, 20 Dec 2023 08:14:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oltmanns.dev; s=MBO0001; t=1703056444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5JWAYPuW2w1S4QldNPnKh0l/fjpe1uHU+1lOR2wMdU0=; b=aqewHPPWceld/vN8dMOtuujW1lrzIuiuwJzKUDlrCm/5bgQUqYB3yB3wupaAbprIDdvT3S E0Z4gggq86mbLA9q8ui0llGLXNLQ47UXkdP9lx3NOVL0/k/J9PPq2Q5d+p58OsnUZoADD1 s5FlKWcrSAR0b6vJMSPqWd/Ne/RLgf/FdJyB9G+h9CrsLz1FwWTIGxt+x7kQnTQekWAVBw z5+ACiE/uFS20YhQPE2IsU6qq1kBInaD5p1wvFr+QVkbU5K0FIqhlPAK88oVeTaakhkHaZ bKquYn0TEz46x3Kf3Dwt0d/v03zuyUVCqkL4QucIBwA+dpgdra82zMhkl7P4tg== References: <20231218-pinephone-pll-fixes-v1-0-e238b6ed6dc1@oltmanns.dev> <20231218-pinephone-pll-fixes-v1-4-e238b6ed6dc1@oltmanns.dev> <13411739.uLZWGnKmhe@jernej-laptop> From: Frank Oltmanns To: Jernej =?utf-8?Q?=C5=A0krabec?= Cc: Michael Turquette , Stephen Boyd , Chen-Yu Tsai , Samuel Holland , Guido =?utf-8?Q?G=C3=BCnther?= , Purism Kernel Team , Ondrej Jirman , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 4/5] clk: sunxi-ng: a64: Add constraints on PLL-VIDEO0's n/m ratio Date: Wed, 20 Dec 2023 08:09:28 +0100 In-reply-to: <13411739.uLZWGnKmhe@jernej-laptop> Message-ID: <87il4t9wi1.fsf@oltmanns.dev> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231219_231410_474856_1CD4F09A X-CRM114-Status: GOOD ( 14.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ck9uIDIwMjMtMTItMTkgYXQgMTc6NTQ6MTkgKzAxMDAsIEplcm5laiDFoGtyYWJlYyA8amVybmVq LnNrcmFiZWNAZ21haWwuY29tPiB3cm90ZToKPiBEbmUgcG9uZWRlbGplaywgMTguIGRlY2VtYmVy IDIwMjMgb2IgMTQ6MzU6MjIgQ0VUIGplIEZyYW5rIE9sdG1hbm5zIG5hcGlzYWwoYSk6Cj4+IFRo ZSBBbGx3aW5uZXIgQTY0IG1hbnVhbCBsaXN0cyB0aGUgZm9sbG93aW5nIGNvbnN0cmFpbnQgZm9y IHRoZQo+PiBQTEwtVklERU8wIGNsb2NrOiA4IDw9IE4vTSA8PSAyNQo+Pgo+PiBVc2UgdGhpcyBj b25zdHJhaW50Lgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBGcmFuayBPbHRtYW5ucyA8ZnJhbmtAb2x0 bWFubnMuZGV2Pgo+PiAtLS0KPj4gIGRyaXZlcnMvY2xrL3N1bnhpLW5nL2NjdS1zdW41MGktYTY0 LmMgfCA4ICsrKysrKy0tCj4+ICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAyIGRl bGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9jbGsvc3VueGktbmcvY2N1LXN1 bjUwaS1hNjQuYyBiL2RyaXZlcnMvY2xrL3N1bnhpLW5nL2NjdS1zdW41MGktYTY0LmMKPj4gaW5k ZXggYzAzNGFjMDI3ZDFjLi43NWQ4MzlkYTQ0NmMgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvY2xr L3N1bnhpLW5nL2NjdS1zdW41MGktYTY0LmMKPj4gKysrIGIvZHJpdmVycy9jbGsvc3VueGktbmcv Y2N1LXN1bjUwaS1hNjQuYwo+PiBAQCAtNjgsNyArNjgsOCBAQCBzdGF0aWMgU1VOWElfQ0NVX05N X1dJVEhfU0RNX0dBVEVfTE9DSyhwbGxfYXVkaW9fYmFzZV9jbGssICJwbGwtYXVkaW8tYmFzZSIs Cj4+ICAJCQkJICAgICAgIEJJVCgyOCksCS8qIGxvY2sgKi8KPj4gIAkJCQkgICAgICAgQ0xLX1NF VF9SQVRFX1VOR0FURSk7Cj4+Cj4+IC1zdGF0aWMgU1VOWElfQ0NVX05NX1dJVEhfRlJBQ19HQVRF X0xPQ0tfTUlOX01BWF9DTE9TRVNUKHBsbF92aWRlbzBfY2xrLCAicGxsLXZpZGVvMCIsCj4+ICtz dGF0aWMgU1VOWElfQ0NVX05NX1dJVEhfRlJBQ19HQVRFX0xPQ0tfTUlOX01BWF9GRUFUX05NX1JB VElPKHBsbF92aWRlbzBfY2xrLAo+PiArCQkJCQkJInBsbC12aWRlbzAiLAo+PiAgCQkJCQkJIm9z YzI0TSIsIDB4MDEwLAo+PiAgCQkJCQkJMTkyMDAwMDAwLAkvKiBNaW5pbXVtIHJhdGUgKi8KPj4g IAkJCQkJCTEwMDgwMDAwMDAsCS8qIE1heGltdW0gcmF0ZSAqLwo+PiBAQCAtODAsNyArODEsMTAg QEAgc3RhdGljIFNVTlhJX0NDVV9OTV9XSVRIX0ZSQUNfR0FURV9MT0NLX01JTl9NQVhfQ0xPU0VT VChwbGxfdmlkZW8wX2NsaywgInBsbC12aWQKPj4gIAkJCQkJCTI5NzAwMDAwMCwJLyogZnJhYyBy YXRlIDEgKi8KPj4gIAkJCQkJCUJJVCgzMSksCS8qIGdhdGUgKi8KPj4gIAkJCQkJCUJJVCgyOCks CS8qIGxvY2sgKi8KPj4gLQkJCQkJCUNMS19TRVRfUkFURV9VTkdBVEUpOwo+PiArCQkJCQkJQ0xL X1NFVF9SQVRFX1VOR0FURSwKPj4gKwkJCQkJCUNDVV9GRUFUVVJFX0ZSQUNUSU9OQUwgfAo+PiAr CQkJCQkJQ0NVX0ZFQVRVUkVfQ0xPU0VTVF9SQVRFLAo+Cj4gQWJvdmUgZmxhZ3MgYXJlIHVucmVs YXRlZCBjaGFuZ2UsIHB1dCB0aGVtIGluIG5ldyBwYXRjaCBpZiBuZWVkZWQuCgpZb3UgbWlnaHQg bm90aWNlIHRoYXQgSSBhbSB1c2luZyBhIG5ldyBtYWNybyBmb3IgaW5pdGlhbGl6aW5nIHRoZQpw bGxfdmlkZW8wX2NsayBzdHJ1Y3Q6Ck5ldzogU1VOWElfQ0NVX05NX1dJVEhfRlJBQ19HQVRFX0xP Q0tfTUlOX01BWF9GRUFUX05NX1JBVElPCk9sZDogU1VOWElfQ0NVX05NX1dJVEhfRlJBQ19HQVRF X0xPQ0tfTUlOX01BWF9DTE9TRVNUCgpTZXR0aW5nIHRoZSB0d28gQ0NVX0ZFQVRVUkUgZmxhZ3Mg aXMgcGFydCBvZiB0aGUgb2xkIGluaXRpYWxpemF0aW9uCm1hY3JvLgoKSSdsbCBhZGQgU1VOWElf Q0NVX05NX1dJVEhfRlJBQ19HQVRFX0xPQ0tfTUlOX01BWF9OTV9SQVRJT19DTE9TRVNUIHdoaWNo CmhvcGVmdWxseSByZXNvbHZlcyB0aGUgY29uZnVzaW9uLgoKVGhhbmtzLAogIEZyYW5rCgo+Cj4g QmVzdCByZWdhcmRzLAo+IEplcm5lago+Cj4+ICsJCQkJCQk4LCAyNSk7CQkvKiBtaW4vbWF4IG5t IHJhdGlvICovCj4+Cj4+ICBzdGF0aWMgU1VOWElfQ0NVX05NX1dJVEhfRlJBQ19HQVRFX0xPQ0so cGxsX3ZlX2NsaywgInBsbC12ZSIsCj4+ICAJCQkJCSJvc2MyNE0iLCAweDAxOCwKPj4KPj4KCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62553C3DA6E for ; Wed, 20 Dec 2023 07:14:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B173010E32E; Wed, 20 Dec 2023 07:14:08 +0000 (UTC) Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7990110E50F for ; Wed, 20 Dec 2023 07:14:07 +0000 (UTC) Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4Sw4YS2tHnz9sp6; Wed, 20 Dec 2023 08:14:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oltmanns.dev; s=MBO0001; t=1703056444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5JWAYPuW2w1S4QldNPnKh0l/fjpe1uHU+1lOR2wMdU0=; b=aqewHPPWceld/vN8dMOtuujW1lrzIuiuwJzKUDlrCm/5bgQUqYB3yB3wupaAbprIDdvT3S E0Z4gggq86mbLA9q8ui0llGLXNLQ47UXkdP9lx3NOVL0/k/J9PPq2Q5d+p58OsnUZoADD1 s5FlKWcrSAR0b6vJMSPqWd/Ne/RLgf/FdJyB9G+h9CrsLz1FwWTIGxt+x7kQnTQekWAVBw z5+ACiE/uFS20YhQPE2IsU6qq1kBInaD5p1wvFr+QVkbU5K0FIqhlPAK88oVeTaakhkHaZ bKquYn0TEz46x3Kf3Dwt0d/v03zuyUVCqkL4QucIBwA+dpgdra82zMhkl7P4tg== References: <20231218-pinephone-pll-fixes-v1-0-e238b6ed6dc1@oltmanns.dev> <20231218-pinephone-pll-fixes-v1-4-e238b6ed6dc1@oltmanns.dev> <13411739.uLZWGnKmhe@jernej-laptop> From: Frank Oltmanns To: Jernej =?utf-8?Q?=C5=A0krabec?= Subject: Re: [PATCH 4/5] clk: sunxi-ng: a64: Add constraints on PLL-VIDEO0's n/m ratio Date: Wed, 20 Dec 2023 08:09:28 +0100 In-reply-to: <13411739.uLZWGnKmhe@jernej-laptop> Message-ID: <87il4t9wi1.fsf@oltmanns.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Purism Kernel Team , Samuel Holland , Stephen Boyd , David Airlie , Michael Turquette , linux-kernel@vger.kernel.org, Maxime Ripard , linux-clk@vger.kernel.org, linux-sunxi@lists.linux.dev, Chen-Yu Tsai , Ondrej Jirman , dri-devel@lists.freedesktop.org, Thomas Zimmermann , Jessica Zhang , Sam Ravnborg , Guido =?utf-8?Q?G=C3=BCnther?= , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2023-12-19 at 17:54:19 +0100, Jernej =C5=A0krabec wrote: > Dne ponedeljek, 18. december 2023 ob 14:35:22 CET je Frank Oltmanns napis= al(a): >> The Allwinner A64 manual lists the following constraint for the >> PLL-VIDEO0 clock: 8 <=3D N/M <=3D 25 >> >> Use this constraint. >> >> Signed-off-by: Frank Oltmanns >> --- >> drivers/clk/sunxi-ng/ccu-sun50i-a64.c | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c b/drivers/clk/sunxi-n= g/ccu-sun50i-a64.c >> index c034ac027d1c..75d839da446c 100644 >> --- a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c >> +++ b/drivers/clk/sunxi-ng/ccu-sun50i-a64.c >> @@ -68,7 +68,8 @@ static SUNXI_CCU_NM_WITH_SDM_GATE_LOCK(pll_audio_base_= clk, "pll-audio-base", >> BIT(28), /* lock */ >> CLK_SET_RATE_UNGATE); >> >> -static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_CLOSEST(pll_video0_clk,= "pll-video0", >> +static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_FEAT_NM_RATIO(pll_video= 0_clk, >> + "pll-video0", >> "osc24M", 0x010, >> 192000000, /* Minimum rate */ >> 1008000000, /* Maximum rate */ >> @@ -80,7 +81,10 @@ static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_CLOSE= ST(pll_video0_clk, "pll-vid >> 297000000, /* frac rate 1 */ >> BIT(31), /* gate */ >> BIT(28), /* lock */ >> - CLK_SET_RATE_UNGATE); >> + CLK_SET_RATE_UNGATE, >> + CCU_FEATURE_FRACTIONAL | >> + CCU_FEATURE_CLOSEST_RATE, > > Above flags are unrelated change, put them in new patch if needed. You might notice that I am using a new macro for initializing the pll_video0_clk struct: New: SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_FEAT_NM_RATIO Old: SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_CLOSEST Setting the two CCU_FEATURE flags is part of the old initialization macro. I'll add SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK_MIN_MAX_NM_RATIO_CLOSEST which hopefully resolves the confusion. Thanks, Frank > > Best regards, > Jernej > >> + 8, 25); /* min/max nm ratio */ >> >> static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK(pll_ve_clk, "pll-ve", >> "osc24M", 0x018, >> >>