From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83AEDC41535 for ; Tue, 19 Dec 2023 12:14:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1690E10E489; Tue, 19 Dec 2023 12:14:53 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0A08410E488; Tue, 19 Dec 2023 12:14:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702988092; x=1734524092; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=MzXwOKF36dSLvD7SAiEMA9wsT0Rd8g3q7N4ec+ws4cI=; b=Bf59oeaakCBqdI4kc2dPu7Y6nIdzOLciUjAdaGWj9DeXfDzZH3slkEOz zDNXKS0z86HFX0e2J4JmFo3YBcG8vPvlEfFNoPSej8Mi2+7GVl2ExzHNF xvvhtMq+bAUNkMRPLyH9ckfQQPCe2PgptLMtXgSbDwJUuz/A3eaZhzeOv LBi0LELoNK+zvjs9eU3emmuWDG+7sXi14ff+nz4PDyi1L8uLVNYXxR7t4 mHA1sRlJZ/YRldtWUrnKnz6qGXzeSps2doSTe89sotqWrtYcsKkUkhq9C jZGT+jtaXQXBBOkO4V/Gpg3Z75GLtGNgh8y6XBvjyPEZOOyGFOtGe15oK w==; X-IronPort-AV: E=McAfee;i="6600,9927,10928"; a="459991812" X-IronPort-AV: E=Sophos;i="6.04,288,1695711600"; d="scan'208";a="459991812" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2023 04:14:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10928"; a="810216191" X-IronPort-AV: E=Sophos;i="6.04,288,1695711600"; d="scan'208";a="810216191" Received: from alexeyze-mobl.ger.corp.intel.com (HELO localhost) ([10.252.34.118]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2023 04:14:49 -0800 From: Jani Nikula To: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/nouveau: include drm/drm_edid.h only where needed In-Reply-To: <20231212135418.3816792-1-jani.nikula@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20231212135418.3816792-1-jani.nikula@intel.com> Date: Tue, 19 Dec 2023 14:14:46 +0200 Message-ID: <87il4utmmh.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Tue, 12 Dec 2023, Jani Nikula wrote: > Including drm_edid.h from nouveau_connector.h causes the rebuild of 15 > files when drm_edid.h is modified, while there are only a few files that > actually need to include drm_edid.h. Ping? > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/nouveau/dispnv50/head.c | 1 + > drivers/gpu/drm/nouveau/nouveau_connector.h | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/dispnv50/head.c b/drivers/gpu/drm/nouveau/dispnv50/head.c > index 5f490fbf1877..83355dbc15ee 100644 > --- a/drivers/gpu/drm/nouveau/dispnv50/head.c > +++ b/drivers/gpu/drm/nouveau/dispnv50/head.c > @@ -32,6 +32,7 @@ > > #include > #include > +#include > #include > #include "nouveau_connector.h" > > diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.h b/drivers/gpu/drm/nouveau/nouveau_connector.h > index a2df4918340c..0608cabed058 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_connector.h > +++ b/drivers/gpu/drm/nouveau/nouveau_connector.h > @@ -35,7 +35,6 @@ > > #include > #include > -#include > #include > #include > > @@ -44,6 +43,7 @@ > > struct nvkm_i2c_port; > struct dcb_output; > +struct edid; > > #ifdef CONFIG_DRM_NOUVEAU_BACKLIGHT > struct nouveau_backlight { -- Jani Nikula, Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C74ABC46CD3 for ; Tue, 19 Dec 2023 12:14:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 15F7010E488; Tue, 19 Dec 2023 12:14:53 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0A08410E488; Tue, 19 Dec 2023 12:14:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702988092; x=1734524092; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=MzXwOKF36dSLvD7SAiEMA9wsT0Rd8g3q7N4ec+ws4cI=; b=Bf59oeaakCBqdI4kc2dPu7Y6nIdzOLciUjAdaGWj9DeXfDzZH3slkEOz zDNXKS0z86HFX0e2J4JmFo3YBcG8vPvlEfFNoPSej8Mi2+7GVl2ExzHNF xvvhtMq+bAUNkMRPLyH9ckfQQPCe2PgptLMtXgSbDwJUuz/A3eaZhzeOv LBi0LELoNK+zvjs9eU3emmuWDG+7sXi14ff+nz4PDyi1L8uLVNYXxR7t4 mHA1sRlJZ/YRldtWUrnKnz6qGXzeSps2doSTe89sotqWrtYcsKkUkhq9C jZGT+jtaXQXBBOkO4V/Gpg3Z75GLtGNgh8y6XBvjyPEZOOyGFOtGe15oK w==; X-IronPort-AV: E=McAfee;i="6600,9927,10928"; a="459991812" X-IronPort-AV: E=Sophos;i="6.04,288,1695711600"; d="scan'208";a="459991812" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2023 04:14:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10928"; a="810216191" X-IronPort-AV: E=Sophos;i="6.04,288,1695711600"; d="scan'208";a="810216191" Received: from alexeyze-mobl.ger.corp.intel.com (HELO localhost) ([10.252.34.118]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2023 04:14:49 -0800 From: Jani Nikula To: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/nouveau: include drm/drm_edid.h only where needed In-Reply-To: <20231212135418.3816792-1-jani.nikula@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20231212135418.3816792-1-jani.nikula@intel.com> Date: Tue, 19 Dec 2023 14:14:46 +0200 Message-ID: <87il4utmmh.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Danilo Krummrich , Karol Herbst Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 12 Dec 2023, Jani Nikula wrote: > Including drm_edid.h from nouveau_connector.h causes the rebuild of 15 > files when drm_edid.h is modified, while there are only a few files that > actually need to include drm_edid.h. Ping? > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/nouveau/dispnv50/head.c | 1 + > drivers/gpu/drm/nouveau/nouveau_connector.h | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/dispnv50/head.c b/drivers/gpu/drm/nouveau/dispnv50/head.c > index 5f490fbf1877..83355dbc15ee 100644 > --- a/drivers/gpu/drm/nouveau/dispnv50/head.c > +++ b/drivers/gpu/drm/nouveau/dispnv50/head.c > @@ -32,6 +32,7 @@ > > #include > #include > +#include > #include > #include "nouveau_connector.h" > > diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.h b/drivers/gpu/drm/nouveau/nouveau_connector.h > index a2df4918340c..0608cabed058 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_connector.h > +++ b/drivers/gpu/drm/nouveau/nouveau_connector.h > @@ -35,7 +35,6 @@ > > #include > #include > -#include > #include > #include > > @@ -44,6 +43,7 @@ > > struct nvkm_i2c_port; > struct dcb_output; > +struct edid; > > #ifdef CONFIG_DRM_NOUVEAU_BACKLIGHT > struct nouveau_backlight { -- Jani Nikula, Intel