From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F5131DA34; Thu, 9 Nov 2023 12:23:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="JOE+Y96n" Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D6C52D55; Thu, 9 Nov 2023 04:23:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1699532610; bh=R2IIgl4ZRFgwipCQ4ZBWquxZCbtnLxeQT8yMzVcSClk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=JOE+Y96nQb0g0fD7YjgIsTtXOrsQ0zdJ9Xit6bae239vdgrtE8Xe20tGEjOEwp6b5 bBGasTtN2qhciM6Vxj5gO1APMLHXfhhNabxTTxDpDoDz6AXcIv0hdu9+rRXuZNmSj3 PriUuPEOny5OCaNxYhuQeMYyhW0D7Uuip11fA5kii4KmxM9zaRV2MnEviCDpMHy6zq fUfZ9elCA6bj44/a3P1CQqNaCruTVzrNA2B2UxDQEd/EBpaSM5DHluHgXy74J1JLYp rlgnpTfcT5fdD0htnPYkbVFENF7DqxPzxI5N3NUPYBgm/lUlPDoiySV3dJVovZ01Br M0UtCQNJ+RaEQ== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4SR1MD6jtmz4wd2; Thu, 9 Nov 2023 23:23:20 +1100 (AEDT) From: Michael Ellerman To: Christophe Leroy , Arnd Bergmann , Arnd Bergmann , Andrew Morton , "linux-kernel@vger.kernel.org" , Masahiro Yamada , "linux-kbuild@vger.kernel.org" Cc: Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Steven Rostedt , Masami Hiramatsu , Mark Rutland , guoren , Peter Zijlstra , Ard Biesheuvel , Huacai Chen , Greg Ungerer , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Nicholas Piggin , Geoff Levand , Palmer Dabbelt , Heiko Carstens , John Paul Adrian Glaubitz , "David S . Miller" , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , "x86@kernel.org" , Helge Deller , Sudip Mukherjee , Greg Kroah-Hartman , Timur Tabi , Kent Overstreet , David Woodhouse , "Naveen N. Rao" , Anil S Keshavamurthy , Kees Cook , Vincenzo Frascino , Juri Lelli , Vincent Guittot , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Alexander Viro , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , "linux-alpha@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linux-trace-kernel@vger.kernel.org" , "linux-csky@vger.kernel.org" , "loongarch@lists.linux.dev" , "linux-m68k@lists.linux-m68k.org" , "linux-mips@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "linux-sh@vger.kernel.org" , "sparclinux@vger.kernel.org" , Netdev , "linux-parisc@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-bcachefs@vger.kernel.org" , "linux-mtd@lists.infradead.org" Subject: Re: [PATCH 15/22] arch: vdso: consolidate gettime prototypes In-Reply-To: <886df4e4-9fc2-ca52-e7e9-53688e6e821a@csgroup.eu> References: <20231108125843.3806765-1-arnd@kernel.org> <20231108125843.3806765-16-arnd@kernel.org> <87o7g3qlf5.fsf@mail.lhotse> <886df4e4-9fc2-ca52-e7e9-53688e6e821a@csgroup.eu> Date: Thu, 09 Nov 2023 23:23:20 +1100 Message-ID: <87il6bqfnr.fsf@mail.lhotse> Precedence: bulk X-Mailing-List: linux-alpha@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Christophe Leroy writes: > Le 09/11/2023 =C3=A0 11:18, Michael Ellerman a =C3=A9crit=C2=A0: >> "Arnd Bergmann" writes: >>> On Wed, Nov 8, 2023, at 19:31, Christophe Leroy wrote: >>>> Le 08/11/2023 =C3=A0 13:58, Arnd Bergmann a =C3=A9crit=C2=A0: >>> >>>> powerpc has functions doing more or less the same, they are called >>>> __c_kernel_clock_gettime() and alike with their prototypes siting in >>>> arch/powerpc/include/asm/vdso/gettimeofday.h >>>> >>>> Should those prototypes be moved to include/vdso/gettime.h too and >>>> eventually renamed, or are they considered too powerpc specific ? >>> >>> I don't actually know, my initial interpretation was that >>> these function names are part of the user ABI for the vdso, >>> but I never looked closely enough at how vdso works to >>> be sure what the actual ABI is. >>=20 >> AFAIK the ABI is just the symbols we export, as defined in the linker >> script: >>=20 >> /* >> * This controls what symbols we export from the DSO. >> */ >> VERSION >> { >> VDSO_VERSION_STRING { >> global: >> __kernel_get_syscall_map; >> __kernel_gettimeofday; >> __kernel_clock_gettime; >> __kernel_clock_getres; >> __kernel_get_tbfreq; >> __kernel_sync_dicache; >> __kernel_sigtramp_rt64; >> __kernel_getcpu; >> __kernel_time; >>=20 >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/= arch/powerpc/kernel/vdso/vdso64.lds.S?h=3Dv6.6&#n117 >>=20 >>> If __c_kernel_clock_gettime() etc are not part of the user-facing >>> ABI, I think renaming them for consistency with the other >>> architectures would be best. >>=20 >> The __c symbols are not part of the ABI, so we could rename them. >>=20 >> At the moment though they don't have the same prototype as the generic >> versions, because we find the VDSO data in asm and pass it to the C >> functions, eg: >>=20 >> int __c_kernel_gettimeofday(struct __kernel_old_timeval *tv, struct time= zone *tz, >> const struct vdso_data *vd); >>=20 >> I think we can rework that though, by implementing >> __arch_get_vdso_data() and getting the vdso_data in C. Then we'd be able >> to share the prototypes. > > I think it would not a been good idea, it would be less performant, for=20 > explanation see commit=20 > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit= /?id=3De876f0b69dc993e86ca7795e63e98385aa9a7ef3 Ah thanks. I was wondering why you had done it in asm. It's a pity but you're right that's probably a measurable performance hit for some of those calls. cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07FA7C4167D for ; Thu, 9 Nov 2023 12:23:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/yApRfeN3VhSmz3Vh6Jw7d7shWObTtav6fxfjECojZ0=; b=j4C0b6pUN5ziHf cGQag3BclQNWzhZMSgFZ5limznKLQ/v3ZXkrrxu0n/Aoq+mQ5hLwBexQU/NWuJvOFk4dGMWmNQdW6 OBPkl3gFR1fuIERfam2ZPblLL9cFf6dr8A8pVlgr7iJDMvs8ovcoN0M4vJjdh9QSNVKVbY74h0xwz QLRxYmhBSzRgqHYTmjHalQHkAEVv89bLx0Zmzjb3wLy0ah8itOPzFE+6j/7gc96xk1Led+nlGIryf spXTe4kNkhJmHBLDb35EwMMpXhyET3PyzRnnPTaf+hfNZ0tor8XAbsYeV6l00swY3PD5+bDgQyvBp KlKCbd/ZL3uYwvbHY8dg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r144R-006J53-19; Thu, 09 Nov 2023 12:23:39 +0000 Received: from gandalf.ozlabs.org ([150.107.74.76]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r144M-006J33-0z; Thu, 09 Nov 2023 12:23:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1699532610; bh=R2IIgl4ZRFgwipCQ4ZBWquxZCbtnLxeQT8yMzVcSClk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=JOE+Y96nQb0g0fD7YjgIsTtXOrsQ0zdJ9Xit6bae239vdgrtE8Xe20tGEjOEwp6b5 bBGasTtN2qhciM6Vxj5gO1APMLHXfhhNabxTTxDpDoDz6AXcIv0hdu9+rRXuZNmSj3 PriUuPEOny5OCaNxYhuQeMYyhW0D7Uuip11fA5kii4KmxM9zaRV2MnEviCDpMHy6zq fUfZ9elCA6bj44/a3P1CQqNaCruTVzrNA2B2UxDQEd/EBpaSM5DHluHgXy74J1JLYp rlgnpTfcT5fdD0htnPYkbVFENF7DqxPzxI5N3NUPYBgm/lUlPDoiySV3dJVovZ01Br M0UtCQNJ+RaEQ== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4SR1MD6jtmz4wd2; Thu, 9 Nov 2023 23:23:20 +1100 (AEDT) From: Michael Ellerman To: Christophe Leroy , Arnd Bergmann , Arnd Bergmann , Andrew Morton , "linux-kernel@vger.kernel.org" , Masahiro Yamada , "linux-kbuild@vger.kernel.org" Cc: Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Steven Rostedt , Masami Hiramatsu , Mark Rutland , guoren , Peter Zijlstra , Ard Biesheuvel , Huacai Chen , Greg Ungerer , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Nicholas Piggin , Geoff Levand , Palmer Dabbelt , Heiko Carstens , John Paul Adrian Glaubitz , "David S . Miller" , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , "x86@kernel.org" , Helge Deller , Sudip Mukherjee , Greg Kroah-Hartman , Timur Tabi , Kent Overstreet , David Woodhouse , "Naveen N. Rao" , Anil S Keshavamurthy , Kees Cook , Vincenzo Frascino , Juri Lelli , Vincent Guittot , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Alexander Viro , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , "linux-alpha@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linux-trace-kernel@vger.kernel.org" , "linux-csky@vger.kernel.org" , "loongarch@lists.linux.dev" , "linux-m68k@lists.linux-m68k.org" , "linux-mips@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "linux-sh@vger.kernel.org" , "sparclinux@vger.kernel.org" , Netdev , "linux-parisc@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-bcachefs@vger.kernel.org" , "linux-mtd@lists.infradead.org" Subject: Re: [PATCH 15/22] arch: vdso: consolidate gettime prototypes In-Reply-To: <886df4e4-9fc2-ca52-e7e9-53688e6e821a@csgroup.eu> References: <20231108125843.3806765-1-arnd@kernel.org> <20231108125843.3806765-16-arnd@kernel.org> <87o7g3qlf5.fsf@mail.lhotse> <886df4e4-9fc2-ca52-e7e9-53688e6e821a@csgroup.eu> Date: Thu, 09 Nov 2023 23:23:20 +1100 Message-ID: <87il6bqfnr.fsf@mail.lhotse> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231109_042334_629165_AB6EA76B X-CRM114-Status: GOOD ( 17.21 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Q2hyaXN0b3BoZSBMZXJveSA8Y2hyaXN0b3BoZS5sZXJveUBjc2dyb3VwLmV1PiB3cml0ZXM6Cj4g TGUgMDkvMTEvMjAyMyDDoCAxMToxOCwgTWljaGFlbCBFbGxlcm1hbiBhIMOpY3JpdMKgOgo+PiAi QXJuZCBCZXJnbWFubiIgPGFybmRAYXJuZGIuZGU+IHdyaXRlczoKPj4+IE9uIFdlZCwgTm92IDgs IDIwMjMsIGF0IDE5OjMxLCBDaHJpc3RvcGhlIExlcm95IHdyb3RlOgo+Pj4+IExlIDA4LzExLzIw MjMgw6AgMTM6NTgsIEFybmQgQmVyZ21hbm4gYSDDqWNyaXTCoDoKPj4+Cj4+Pj4gcG93ZXJwYyBo YXMgZnVuY3Rpb25zIGRvaW5nIG1vcmUgb3IgbGVzcyB0aGUgc2FtZSwgdGhleSBhcmUgY2FsbGVk Cj4+Pj4gX19jX2tlcm5lbF9jbG9ja19nZXR0aW1lKCkgYW5kIGFsaWtlIHdpdGggdGhlaXIgcHJv dG90eXBlcyBzaXRpbmcgaW4KPj4+PiBhcmNoL3Bvd2VycGMvaW5jbHVkZS9hc20vdmRzby9nZXR0 aW1lb2ZkYXkuaAo+Pj4+Cj4+Pj4gU2hvdWxkIHRob3NlIHByb3RvdHlwZXMgYmUgbW92ZWQgdG8g aW5jbHVkZS92ZHNvL2dldHRpbWUuaCB0b28gYW5kCj4+Pj4gZXZlbnR1YWxseSByZW5hbWVkLCBv ciBhcmUgdGhleSBjb25zaWRlcmVkIHRvbyBwb3dlcnBjIHNwZWNpZmljID8KPj4+Cj4+PiBJIGRv bid0IGFjdHVhbGx5IGtub3csIG15IGluaXRpYWwgaW50ZXJwcmV0YXRpb24gd2FzIHRoYXQKPj4+ IHRoZXNlIGZ1bmN0aW9uIG5hbWVzIGFyZSBwYXJ0IG9mIHRoZSB1c2VyIEFCSSBmb3IgdGhlIHZk c28sCj4+PiBidXQgSSBuZXZlciBsb29rZWQgY2xvc2VseSBlbm91Z2ggYXQgaG93IHZkc28gd29y a3MgdG8KPj4+IGJlIHN1cmUgd2hhdCB0aGUgYWN0dWFsIEFCSSBpcy4KPj4gCj4+IEFGQUlLIHRo ZSBBQkkgaXMganVzdCB0aGUgc3ltYm9scyB3ZSBleHBvcnQsIGFzIGRlZmluZWQgaW4gdGhlIGxp bmtlcgo+PiBzY3JpcHQ6Cj4+IAo+PiAvKgo+PiAgICogVGhpcyBjb250cm9scyB3aGF0IHN5bWJv bHMgd2UgZXhwb3J0IGZyb20gdGhlIERTTy4KPj4gICAqLwo+PiBWRVJTSU9OCj4+IHsKPj4gCVZE U09fVkVSU0lPTl9TVFJJTkcgewo+PiAJZ2xvYmFsOgo+PiAJCV9fa2VybmVsX2dldF9zeXNjYWxs X21hcDsKPj4gCQlfX2tlcm5lbF9nZXR0aW1lb2ZkYXk7Cj4+IAkJX19rZXJuZWxfY2xvY2tfZ2V0 dGltZTsKPj4gCQlfX2tlcm5lbF9jbG9ja19nZXRyZXM7Cj4+IAkJX19rZXJuZWxfZ2V0X3RiZnJl cTsKPj4gCQlfX2tlcm5lbF9zeW5jX2RpY2FjaGU7Cj4+IAkJX19rZXJuZWxfc2lndHJhbXBfcnQ2 NDsKPj4gCQlfX2tlcm5lbF9nZXRjcHU7Cj4+IAkJX19rZXJuZWxfdGltZTsKPj4gCj4+IGh0dHBz Oi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3RvcnZhbGRzL2xpbnV4 LmdpdC90cmVlL2FyY2gvcG93ZXJwYy9rZXJuZWwvdmRzby92ZHNvNjQubGRzLlM/aD12Ni42JiNu MTE3Cj4+IAo+Pj4gSWYgX19jX2tlcm5lbF9jbG9ja19nZXR0aW1lKCkgZXRjIGFyZSBub3QgcGFy dCBvZiB0aGUgdXNlci1mYWNpbmcKPj4+IEFCSSwgSSB0aGluayByZW5hbWluZyB0aGVtIGZvciBj b25zaXN0ZW5jeSB3aXRoIHRoZSBvdGhlcgo+Pj4gYXJjaGl0ZWN0dXJlcyB3b3VsZCBiZSBiZXN0 Lgo+PiAKPj4gVGhlIF9fYyBzeW1ib2xzIGFyZSBub3QgcGFydCBvZiB0aGUgQUJJLCBzbyB3ZSBj b3VsZCByZW5hbWUgdGhlbS4KPj4gCj4+IEF0IHRoZSBtb21lbnQgdGhvdWdoIHRoZXkgZG9uJ3Qg aGF2ZSB0aGUgc2FtZSBwcm90b3R5cGUgYXMgdGhlIGdlbmVyaWMKPj4gdmVyc2lvbnMsIGJlY2F1 c2Ugd2UgZmluZCB0aGUgVkRTTyBkYXRhIGluIGFzbSBhbmQgcGFzcyBpdCB0byB0aGUgQwo+PiBm dW5jdGlvbnMsIGVnOgo+PiAKPj4gaW50IF9fY19rZXJuZWxfZ2V0dGltZW9mZGF5KHN0cnVjdCBf X2tlcm5lbF9vbGRfdGltZXZhbCAqdHYsIHN0cnVjdCB0aW1lem9uZSAqdHosCj4+IAkJCSAgICBj b25zdCBzdHJ1Y3QgdmRzb19kYXRhICp2ZCk7Cj4+IAo+PiBJIHRoaW5rIHdlIGNhbiByZXdvcmsg dGhhdCB0aG91Z2gsIGJ5IGltcGxlbWVudGluZwo+PiBfX2FyY2hfZ2V0X3Zkc29fZGF0YSgpIGFu ZCBnZXR0aW5nIHRoZSB2ZHNvX2RhdGEgaW4gQy4gVGhlbiB3ZSdkIGJlIGFibGUKPj4gdG8gc2hh cmUgdGhlIHByb3RvdHlwZXMuCj4KPiBJIHRoaW5rIGl0IHdvdWxkIG5vdCBhIGJlZW4gZ29vZCBp ZGVhLCBpdCB3b3VsZCBiZSBsZXNzIHBlcmZvcm1hbnQsIGZvciAKPiBleHBsYW5hdGlvbiBzZWUg Y29tbWl0IAo+IGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0 L3RvcnZhbGRzL2xpbnV4LmdpdC9jb21taXQvP2lkPWU4NzZmMGI2OWRjOTkzZTg2Y2E3Nzk1ZTYz ZTk4Mzg1YWE5YTdlZjMKCkFoIHRoYW5rcy4gSSB3YXMgd29uZGVyaW5nIHdoeSB5b3UgaGFkIGRv bmUgaXQgaW4gYXNtLgoKSXQncyBhIHBpdHkgYnV0IHlvdSdyZSByaWdodCB0aGF0J3MgcHJvYmFi bHkgYSBtZWFzdXJhYmxlIHBlcmZvcm1hbmNlCmhpdCBmb3Igc29tZSBvZiB0aG9zZSBjYWxscy4K CmNoZWVycwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C30D9C4332F for ; Thu, 9 Nov 2023 12:23:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=onqGpSs44UfQbVdMmMxgQnxrs9PfDTxmPX83ApqZUEM=; b=cM1TcqZ3SIaaeN xhY8+jRrPgRx1g5tdvK7clItu6IqSQ/XnpVMZQ/a0VK23IjDVVwoJkifJS+oEYiOiYZOHPALcpZSG eQYG6lwyassfwimUFqyv2pPfO7lBywkhoIa4vT2R7UveoqlUEj6y0Mgkoo6l8ELqTKNg0uATmRJ52 jkS5VxZWzBgc3Jfd2potpVfq1TSS8aoF1QJn7ymuJwV8ykTQFORHtrEB30e6/VCEIk2c7gZ1jVJdh wo2y/PBtA8SgUFyWA68ilkdqefDZI9BH4qUln9/xiMKf4kImKUE3ALOrA5FEMYN/eK+wPP8RUR0ko 2CwIJaE/HrgkFm5allrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r144R-006J5Q-2r; Thu, 09 Nov 2023 12:23:39 +0000 Received: from gandalf.ozlabs.org ([150.107.74.76]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r144M-006J33-0z; Thu, 09 Nov 2023 12:23:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1699532610; bh=R2IIgl4ZRFgwipCQ4ZBWquxZCbtnLxeQT8yMzVcSClk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=JOE+Y96nQb0g0fD7YjgIsTtXOrsQ0zdJ9Xit6bae239vdgrtE8Xe20tGEjOEwp6b5 bBGasTtN2qhciM6Vxj5gO1APMLHXfhhNabxTTxDpDoDz6AXcIv0hdu9+rRXuZNmSj3 PriUuPEOny5OCaNxYhuQeMYyhW0D7Uuip11fA5kii4KmxM9zaRV2MnEviCDpMHy6zq fUfZ9elCA6bj44/a3P1CQqNaCruTVzrNA2B2UxDQEd/EBpaSM5DHluHgXy74J1JLYp rlgnpTfcT5fdD0htnPYkbVFENF7DqxPzxI5N3NUPYBgm/lUlPDoiySV3dJVovZ01Br M0UtCQNJ+RaEQ== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4SR1MD6jtmz4wd2; Thu, 9 Nov 2023 23:23:20 +1100 (AEDT) From: Michael Ellerman To: Christophe Leroy , Arnd Bergmann , Arnd Bergmann , Andrew Morton , "linux-kernel@vger.kernel.org" , Masahiro Yamada , "linux-kbuild@vger.kernel.org" Cc: Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Steven Rostedt , Masami Hiramatsu , Mark Rutland , guoren , Peter Zijlstra , Ard Biesheuvel , Huacai Chen , Greg Ungerer , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Nicholas Piggin , Geoff Levand , Palmer Dabbelt , Heiko Carstens , John Paul Adrian Glaubitz , "David S . Miller" , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , "x86@kernel.org" , Helge Deller , Sudip Mukherjee , Greg Kroah-Hartman , Timur Tabi , Kent Overstreet , David Woodhouse , "Naveen N. Rao" , Anil S Keshavamurthy , Kees Cook , Vincenzo Frascino , Juri Lelli , Vincent Guittot , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Alexander Viro , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , "linux-alpha@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linux-trace-kernel@vger.kernel.org" , "linux-csky@vger.kernel.org" , "loongarch@lists.linux.dev" , "linux-m68k@lists.linux-m68k.org" , "linux-mips@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "linux-sh@vger.kernel.org" , "sparclinux@vger.kernel.org" , Netdev , "linux-parisc@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-bcachefs@vger.kernel.org" , "linux-mtd@lists.infradead.org" Subject: Re: [PATCH 15/22] arch: vdso: consolidate gettime prototypes In-Reply-To: <886df4e4-9fc2-ca52-e7e9-53688e6e821a@csgroup.eu> References: <20231108125843.3806765-1-arnd@kernel.org> <20231108125843.3806765-16-arnd@kernel.org> <87o7g3qlf5.fsf@mail.lhotse> <886df4e4-9fc2-ca52-e7e9-53688e6e821a@csgroup.eu> Date: Thu, 09 Nov 2023 23:23:20 +1100 Message-ID: <87il6bqfnr.fsf@mail.lhotse> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231109_042334_629165_AB6EA76B X-CRM114-Status: GOOD ( 17.21 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Q2hyaXN0b3BoZSBMZXJveSA8Y2hyaXN0b3BoZS5sZXJveUBjc2dyb3VwLmV1PiB3cml0ZXM6Cj4g TGUgMDkvMTEvMjAyMyDDoCAxMToxOCwgTWljaGFlbCBFbGxlcm1hbiBhIMOpY3JpdMKgOgo+PiAi QXJuZCBCZXJnbWFubiIgPGFybmRAYXJuZGIuZGU+IHdyaXRlczoKPj4+IE9uIFdlZCwgTm92IDgs IDIwMjMsIGF0IDE5OjMxLCBDaHJpc3RvcGhlIExlcm95IHdyb3RlOgo+Pj4+IExlIDA4LzExLzIw MjMgw6AgMTM6NTgsIEFybmQgQmVyZ21hbm4gYSDDqWNyaXTCoDoKPj4+Cj4+Pj4gcG93ZXJwYyBo YXMgZnVuY3Rpb25zIGRvaW5nIG1vcmUgb3IgbGVzcyB0aGUgc2FtZSwgdGhleSBhcmUgY2FsbGVk Cj4+Pj4gX19jX2tlcm5lbF9jbG9ja19nZXR0aW1lKCkgYW5kIGFsaWtlIHdpdGggdGhlaXIgcHJv dG90eXBlcyBzaXRpbmcgaW4KPj4+PiBhcmNoL3Bvd2VycGMvaW5jbHVkZS9hc20vdmRzby9nZXR0 aW1lb2ZkYXkuaAo+Pj4+Cj4+Pj4gU2hvdWxkIHRob3NlIHByb3RvdHlwZXMgYmUgbW92ZWQgdG8g aW5jbHVkZS92ZHNvL2dldHRpbWUuaCB0b28gYW5kCj4+Pj4gZXZlbnR1YWxseSByZW5hbWVkLCBv ciBhcmUgdGhleSBjb25zaWRlcmVkIHRvbyBwb3dlcnBjIHNwZWNpZmljID8KPj4+Cj4+PiBJIGRv bid0IGFjdHVhbGx5IGtub3csIG15IGluaXRpYWwgaW50ZXJwcmV0YXRpb24gd2FzIHRoYXQKPj4+ IHRoZXNlIGZ1bmN0aW9uIG5hbWVzIGFyZSBwYXJ0IG9mIHRoZSB1c2VyIEFCSSBmb3IgdGhlIHZk c28sCj4+PiBidXQgSSBuZXZlciBsb29rZWQgY2xvc2VseSBlbm91Z2ggYXQgaG93IHZkc28gd29y a3MgdG8KPj4+IGJlIHN1cmUgd2hhdCB0aGUgYWN0dWFsIEFCSSBpcy4KPj4gCj4+IEFGQUlLIHRo ZSBBQkkgaXMganVzdCB0aGUgc3ltYm9scyB3ZSBleHBvcnQsIGFzIGRlZmluZWQgaW4gdGhlIGxp bmtlcgo+PiBzY3JpcHQ6Cj4+IAo+PiAvKgo+PiAgICogVGhpcyBjb250cm9scyB3aGF0IHN5bWJv bHMgd2UgZXhwb3J0IGZyb20gdGhlIERTTy4KPj4gICAqLwo+PiBWRVJTSU9OCj4+IHsKPj4gCVZE U09fVkVSU0lPTl9TVFJJTkcgewo+PiAJZ2xvYmFsOgo+PiAJCV9fa2VybmVsX2dldF9zeXNjYWxs X21hcDsKPj4gCQlfX2tlcm5lbF9nZXR0aW1lb2ZkYXk7Cj4+IAkJX19rZXJuZWxfY2xvY2tfZ2V0 dGltZTsKPj4gCQlfX2tlcm5lbF9jbG9ja19nZXRyZXM7Cj4+IAkJX19rZXJuZWxfZ2V0X3RiZnJl cTsKPj4gCQlfX2tlcm5lbF9zeW5jX2RpY2FjaGU7Cj4+IAkJX19rZXJuZWxfc2lndHJhbXBfcnQ2 NDsKPj4gCQlfX2tlcm5lbF9nZXRjcHU7Cj4+IAkJX19rZXJuZWxfdGltZTsKPj4gCj4+IGh0dHBz Oi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3RvcnZhbGRzL2xpbnV4 LmdpdC90cmVlL2FyY2gvcG93ZXJwYy9rZXJuZWwvdmRzby92ZHNvNjQubGRzLlM/aD12Ni42JiNu MTE3Cj4+IAo+Pj4gSWYgX19jX2tlcm5lbF9jbG9ja19nZXR0aW1lKCkgZXRjIGFyZSBub3QgcGFy dCBvZiB0aGUgdXNlci1mYWNpbmcKPj4+IEFCSSwgSSB0aGluayByZW5hbWluZyB0aGVtIGZvciBj b25zaXN0ZW5jeSB3aXRoIHRoZSBvdGhlcgo+Pj4gYXJjaGl0ZWN0dXJlcyB3b3VsZCBiZSBiZXN0 Lgo+PiAKPj4gVGhlIF9fYyBzeW1ib2xzIGFyZSBub3QgcGFydCBvZiB0aGUgQUJJLCBzbyB3ZSBj b3VsZCByZW5hbWUgdGhlbS4KPj4gCj4+IEF0IHRoZSBtb21lbnQgdGhvdWdoIHRoZXkgZG9uJ3Qg aGF2ZSB0aGUgc2FtZSBwcm90b3R5cGUgYXMgdGhlIGdlbmVyaWMKPj4gdmVyc2lvbnMsIGJlY2F1 c2Ugd2UgZmluZCB0aGUgVkRTTyBkYXRhIGluIGFzbSBhbmQgcGFzcyBpdCB0byB0aGUgQwo+PiBm dW5jdGlvbnMsIGVnOgo+PiAKPj4gaW50IF9fY19rZXJuZWxfZ2V0dGltZW9mZGF5KHN0cnVjdCBf X2tlcm5lbF9vbGRfdGltZXZhbCAqdHYsIHN0cnVjdCB0aW1lem9uZSAqdHosCj4+IAkJCSAgICBj b25zdCBzdHJ1Y3QgdmRzb19kYXRhICp2ZCk7Cj4+IAo+PiBJIHRoaW5rIHdlIGNhbiByZXdvcmsg dGhhdCB0aG91Z2gsIGJ5IGltcGxlbWVudGluZwo+PiBfX2FyY2hfZ2V0X3Zkc29fZGF0YSgpIGFu ZCBnZXR0aW5nIHRoZSB2ZHNvX2RhdGEgaW4gQy4gVGhlbiB3ZSdkIGJlIGFibGUKPj4gdG8gc2hh cmUgdGhlIHByb3RvdHlwZXMuCj4KPiBJIHRoaW5rIGl0IHdvdWxkIG5vdCBhIGJlZW4gZ29vZCBp ZGVhLCBpdCB3b3VsZCBiZSBsZXNzIHBlcmZvcm1hbnQsIGZvciAKPiBleHBsYW5hdGlvbiBzZWUg Y29tbWl0IAo+IGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0 L3RvcnZhbGRzL2xpbnV4LmdpdC9jb21taXQvP2lkPWU4NzZmMGI2OWRjOTkzZTg2Y2E3Nzk1ZTYz ZTk4Mzg1YWE5YTdlZjMKCkFoIHRoYW5rcy4gSSB3YXMgd29uZGVyaW5nIHdoeSB5b3UgaGFkIGRv bmUgaXQgaW4gYXNtLgoKSXQncyBhIHBpdHkgYnV0IHlvdSdyZSByaWdodCB0aGF0J3MgcHJvYmFi bHkgYSBtZWFzdXJhYmxlIHBlcmZvcm1hbmNlCmhpdCBmb3Igc29tZSBvZiB0aG9zZSBjYWxscy4K CmNoZWVycwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D688EC4167D for ; Thu, 9 Nov 2023 12:23:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OKMDbRhjoJSRfBwJCnMfrG/+gEvzTo9nNKuC0WApZHA=; b=GCggqZOVZax0CY Y6eq+mLtwtcx1LLmUOQ6UMrMrT5zxe6LrpErDYW6sODqFqPmoLqzTLbGdO2AUpALcuOBEnq6BDWx5 FplsTaP28x5MuITkxRnRwBML54x0CobJii9n+JKCcjOlLCbZcn9zvObERvVf+bC4wxFQHMrnnpvTn 7nf+a8/J5h+BLikYD5XDwFi9Krbf7CDRZvcj8oKw1sgo9fekMEXLvP+8lO7e9m+kvNs3FkgM7vcsP +ybs2vA8yNmVRwQ++tzvGgkgYmyDSptZv5WmURrJtXtfcyLSFc9Pa4L6r+46Xkqas8H4H6gMy1Joc Im+XjdjQrbzMZ2qhIxAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r144S-006J5V-1S; Thu, 09 Nov 2023 12:23:40 +0000 Received: from gandalf.ozlabs.org ([150.107.74.76]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r144M-006J33-0z; Thu, 09 Nov 2023 12:23:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1699532610; bh=R2IIgl4ZRFgwipCQ4ZBWquxZCbtnLxeQT8yMzVcSClk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=JOE+Y96nQb0g0fD7YjgIsTtXOrsQ0zdJ9Xit6bae239vdgrtE8Xe20tGEjOEwp6b5 bBGasTtN2qhciM6Vxj5gO1APMLHXfhhNabxTTxDpDoDz6AXcIv0hdu9+rRXuZNmSj3 PriUuPEOny5OCaNxYhuQeMYyhW0D7Uuip11fA5kii4KmxM9zaRV2MnEviCDpMHy6zq fUfZ9elCA6bj44/a3P1CQqNaCruTVzrNA2B2UxDQEd/EBpaSM5DHluHgXy74J1JLYp rlgnpTfcT5fdD0htnPYkbVFENF7DqxPzxI5N3NUPYBgm/lUlPDoiySV3dJVovZ01Br M0UtCQNJ+RaEQ== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4SR1MD6jtmz4wd2; Thu, 9 Nov 2023 23:23:20 +1100 (AEDT) From: Michael Ellerman To: Christophe Leroy , Arnd Bergmann , Arnd Bergmann , Andrew Morton , "linux-kernel@vger.kernel.org" , Masahiro Yamada , "linux-kbuild@vger.kernel.org" Cc: Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Steven Rostedt , Masami Hiramatsu , Mark Rutland , guoren , Peter Zijlstra , Ard Biesheuvel , Huacai Chen , Greg Ungerer , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Nicholas Piggin , Geoff Levand , Palmer Dabbelt , Heiko Carstens , John Paul Adrian Glaubitz , "David S . Miller" , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , "x86@kernel.org" , Helge Deller , Sudip Mukherjee , Greg Kroah-Hartman , Timur Tabi , Kent Overstreet , David Woodhouse , "Naveen N. Rao" , Anil S Keshavamurthy , Kees Cook , Vincenzo Frascino , Juri Lelli , Vincent Guittot , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Alexander Viro , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , "linux-alpha@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linux-trace-kernel@vger.kernel.org" , "linux-csky@vger.kernel.org" , "loongarch@lists.linux.dev" , "linux-m68k@lists.linux-m68k.org" , "linux-mips@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "linux-sh@vger.kernel.org" , "sparclinux@vger.kernel.org" , Netdev , "linux-parisc@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-bcachefs@vger.kernel.org" , "linux-mtd@lists.infradead.org" Subject: Re: [PATCH 15/22] arch: vdso: consolidate gettime prototypes In-Reply-To: <886df4e4-9fc2-ca52-e7e9-53688e6e821a@csgroup.eu> References: <20231108125843.3806765-1-arnd@kernel.org> <20231108125843.3806765-16-arnd@kernel.org> <87o7g3qlf5.fsf@mail.lhotse> <886df4e4-9fc2-ca52-e7e9-53688e6e821a@csgroup.eu> Date: Thu, 09 Nov 2023 23:23:20 +1100 Message-ID: <87il6bqfnr.fsf@mail.lhotse> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231109_042334_629165_AB6EA76B X-CRM114-Status: GOOD ( 17.21 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org Q2hyaXN0b3BoZSBMZXJveSA8Y2hyaXN0b3BoZS5sZXJveUBjc2dyb3VwLmV1PiB3cml0ZXM6Cj4g TGUgMDkvMTEvMjAyMyDDoCAxMToxOCwgTWljaGFlbCBFbGxlcm1hbiBhIMOpY3JpdMKgOgo+PiAi QXJuZCBCZXJnbWFubiIgPGFybmRAYXJuZGIuZGU+IHdyaXRlczoKPj4+IE9uIFdlZCwgTm92IDgs IDIwMjMsIGF0IDE5OjMxLCBDaHJpc3RvcGhlIExlcm95IHdyb3RlOgo+Pj4+IExlIDA4LzExLzIw MjMgw6AgMTM6NTgsIEFybmQgQmVyZ21hbm4gYSDDqWNyaXTCoDoKPj4+Cj4+Pj4gcG93ZXJwYyBo YXMgZnVuY3Rpb25zIGRvaW5nIG1vcmUgb3IgbGVzcyB0aGUgc2FtZSwgdGhleSBhcmUgY2FsbGVk Cj4+Pj4gX19jX2tlcm5lbF9jbG9ja19nZXR0aW1lKCkgYW5kIGFsaWtlIHdpdGggdGhlaXIgcHJv dG90eXBlcyBzaXRpbmcgaW4KPj4+PiBhcmNoL3Bvd2VycGMvaW5jbHVkZS9hc20vdmRzby9nZXR0 aW1lb2ZkYXkuaAo+Pj4+Cj4+Pj4gU2hvdWxkIHRob3NlIHByb3RvdHlwZXMgYmUgbW92ZWQgdG8g aW5jbHVkZS92ZHNvL2dldHRpbWUuaCB0b28gYW5kCj4+Pj4gZXZlbnR1YWxseSByZW5hbWVkLCBv ciBhcmUgdGhleSBjb25zaWRlcmVkIHRvbyBwb3dlcnBjIHNwZWNpZmljID8KPj4+Cj4+PiBJIGRv bid0IGFjdHVhbGx5IGtub3csIG15IGluaXRpYWwgaW50ZXJwcmV0YXRpb24gd2FzIHRoYXQKPj4+ IHRoZXNlIGZ1bmN0aW9uIG5hbWVzIGFyZSBwYXJ0IG9mIHRoZSB1c2VyIEFCSSBmb3IgdGhlIHZk c28sCj4+PiBidXQgSSBuZXZlciBsb29rZWQgY2xvc2VseSBlbm91Z2ggYXQgaG93IHZkc28gd29y a3MgdG8KPj4+IGJlIHN1cmUgd2hhdCB0aGUgYWN0dWFsIEFCSSBpcy4KPj4gCj4+IEFGQUlLIHRo ZSBBQkkgaXMganVzdCB0aGUgc3ltYm9scyB3ZSBleHBvcnQsIGFzIGRlZmluZWQgaW4gdGhlIGxp bmtlcgo+PiBzY3JpcHQ6Cj4+IAo+PiAvKgo+PiAgICogVGhpcyBjb250cm9scyB3aGF0IHN5bWJv bHMgd2UgZXhwb3J0IGZyb20gdGhlIERTTy4KPj4gICAqLwo+PiBWRVJTSU9OCj4+IHsKPj4gCVZE U09fVkVSU0lPTl9TVFJJTkcgewo+PiAJZ2xvYmFsOgo+PiAJCV9fa2VybmVsX2dldF9zeXNjYWxs X21hcDsKPj4gCQlfX2tlcm5lbF9nZXR0aW1lb2ZkYXk7Cj4+IAkJX19rZXJuZWxfY2xvY2tfZ2V0 dGltZTsKPj4gCQlfX2tlcm5lbF9jbG9ja19nZXRyZXM7Cj4+IAkJX19rZXJuZWxfZ2V0X3RiZnJl cTsKPj4gCQlfX2tlcm5lbF9zeW5jX2RpY2FjaGU7Cj4+IAkJX19rZXJuZWxfc2lndHJhbXBfcnQ2 NDsKPj4gCQlfX2tlcm5lbF9nZXRjcHU7Cj4+IAkJX19rZXJuZWxfdGltZTsKPj4gCj4+IGh0dHBz Oi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3RvcnZhbGRzL2xpbnV4 LmdpdC90cmVlL2FyY2gvcG93ZXJwYy9rZXJuZWwvdmRzby92ZHNvNjQubGRzLlM/aD12Ni42JiNu MTE3Cj4+IAo+Pj4gSWYgX19jX2tlcm5lbF9jbG9ja19nZXR0aW1lKCkgZXRjIGFyZSBub3QgcGFy dCBvZiB0aGUgdXNlci1mYWNpbmcKPj4+IEFCSSwgSSB0aGluayByZW5hbWluZyB0aGVtIGZvciBj b25zaXN0ZW5jeSB3aXRoIHRoZSBvdGhlcgo+Pj4gYXJjaGl0ZWN0dXJlcyB3b3VsZCBiZSBiZXN0 Lgo+PiAKPj4gVGhlIF9fYyBzeW1ib2xzIGFyZSBub3QgcGFydCBvZiB0aGUgQUJJLCBzbyB3ZSBj b3VsZCByZW5hbWUgdGhlbS4KPj4gCj4+IEF0IHRoZSBtb21lbnQgdGhvdWdoIHRoZXkgZG9uJ3Qg aGF2ZSB0aGUgc2FtZSBwcm90b3R5cGUgYXMgdGhlIGdlbmVyaWMKPj4gdmVyc2lvbnMsIGJlY2F1 c2Ugd2UgZmluZCB0aGUgVkRTTyBkYXRhIGluIGFzbSBhbmQgcGFzcyBpdCB0byB0aGUgQwo+PiBm dW5jdGlvbnMsIGVnOgo+PiAKPj4gaW50IF9fY19rZXJuZWxfZ2V0dGltZW9mZGF5KHN0cnVjdCBf X2tlcm5lbF9vbGRfdGltZXZhbCAqdHYsIHN0cnVjdCB0aW1lem9uZSAqdHosCj4+IAkJCSAgICBj b25zdCBzdHJ1Y3QgdmRzb19kYXRhICp2ZCk7Cj4+IAo+PiBJIHRoaW5rIHdlIGNhbiByZXdvcmsg dGhhdCB0aG91Z2gsIGJ5IGltcGxlbWVudGluZwo+PiBfX2FyY2hfZ2V0X3Zkc29fZGF0YSgpIGFu ZCBnZXR0aW5nIHRoZSB2ZHNvX2RhdGEgaW4gQy4gVGhlbiB3ZSdkIGJlIGFibGUKPj4gdG8gc2hh cmUgdGhlIHByb3RvdHlwZXMuCj4KPiBJIHRoaW5rIGl0IHdvdWxkIG5vdCBhIGJlZW4gZ29vZCBp ZGVhLCBpdCB3b3VsZCBiZSBsZXNzIHBlcmZvcm1hbnQsIGZvciAKPiBleHBsYW5hdGlvbiBzZWUg Y29tbWl0IAo+IGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0 L3RvcnZhbGRzL2xpbnV4LmdpdC9jb21taXQvP2lkPWU4NzZmMGI2OWRjOTkzZTg2Y2E3Nzk1ZTYz ZTk4Mzg1YWE5YTdlZjMKCkFoIHRoYW5rcy4gSSB3YXMgd29uZGVyaW5nIHdoeSB5b3UgaGFkIGRv bmUgaXQgaW4gYXNtLgoKSXQncyBhIHBpdHkgYnV0IHlvdSdyZSByaWdodCB0aGF0J3MgcHJvYmFi bHkgYSBtZWFzdXJhYmxlIHBlcmZvcm1hbmNlCmhpdCBmb3Igc29tZSBvZiB0aG9zZSBjYWxscy4K CmNoZWVycwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtc25wcy1hcmMgbWFpbGluZyBsaXN0CmxpbnV4LXNucHMtYXJjQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1z bnBzLWFyYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 909FFC4332F for ; Thu, 9 Nov 2023 22:26:24 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=JOE+Y96n; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4SRGl31YNNz3cS5 for ; Fri, 10 Nov 2023 09:26:23 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=JOE+Y96n; dkim-atps=neutral Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4SR1MQ3jNDz2xps for ; Thu, 9 Nov 2023 23:23:30 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1699532610; bh=R2IIgl4ZRFgwipCQ4ZBWquxZCbtnLxeQT8yMzVcSClk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=JOE+Y96nQb0g0fD7YjgIsTtXOrsQ0zdJ9Xit6bae239vdgrtE8Xe20tGEjOEwp6b5 bBGasTtN2qhciM6Vxj5gO1APMLHXfhhNabxTTxDpDoDz6AXcIv0hdu9+rRXuZNmSj3 PriUuPEOny5OCaNxYhuQeMYyhW0D7Uuip11fA5kii4KmxM9zaRV2MnEviCDpMHy6zq fUfZ9elCA6bj44/a3P1CQqNaCruTVzrNA2B2UxDQEd/EBpaSM5DHluHgXy74J1JLYp rlgnpTfcT5fdD0htnPYkbVFENF7DqxPzxI5N3NUPYBgm/lUlPDoiySV3dJVovZ01Br M0UtCQNJ+RaEQ== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4SR1MD6jtmz4wd2; Thu, 9 Nov 2023 23:23:20 +1100 (AEDT) From: Michael Ellerman To: Christophe Leroy , Arnd Bergmann , Arnd Bergmann , Andrew Morton , "linux-kernel@vger.kernel.org" , Masahiro Yamada , "linux-kbuild@vger.kernel.org" Subject: Re: [PATCH 15/22] arch: vdso: consolidate gettime prototypes In-Reply-To: <886df4e4-9fc2-ca52-e7e9-53688e6e821a@csgroup.eu> References: <20231108125843.3806765-1-arnd@kernel.org> <20231108125843.3806765-16-arnd@kernel.org> <87o7g3qlf5.fsf@mail.lhotse> <886df4e4-9fc2-ca52-e7e9-53688e6e821a@csgroup.eu> Date: Thu, 09 Nov 2023 23:23:20 +1100 Message-ID: <87il6bqfnr.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Fri, 10 Nov 2023 09:25:33 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Juri Lelli , "linux-fbdev@vger.kernel.org" , "x86@kernel.org" , "loongarch@lists.linux.dev" , "linux-sh@vger.kernel.org" , Peter Zijlstra , Catalin Marinas , "dri-devel@lists.freedesktop.org" , Netdev , guoren , "linux-csky@vger.kernel.org" , "sparclinux@vger.kernel.org" , "linux-riscv@lists.infradead.org" , Vincenzo Frascino , Will Deacon , Greg Ungerer , Nicolas Schier , "linux-s390@vger.kernel.org" , Vincent Guittot , Helge Deller , Huacai Chen , Russell King , Anil S Keshavamurthy , Ard Biesheuvel , "linux-bcachefs@vger.kernel.org" , Ingo Molnar , Vineet Gupta , "Naveen N. Rao" , Matt Turner , "linux-snps-arc@lists.infradead.org" , "linux-trace-kernel@vger.kernel.org" , Kees Cook , Heiko Carstens , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , "linuxppc-dev@lists.ozlabs.org" , Nicholas Piggin , Nathan Chancellor , "linux-m68k@lists.linux-m68k.org" , Steven Rostedt , Andy Lutomirski , John Paul Adrian Glaubitz , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" , Michal Simek , Thomas Bogendoerfer , "linux-parisc@vger.kernel.org" , Timur Tabi , Geoff Levand , Greg Kroah-Hartman , Kent Overstreet , Nick Desaulniers , "linux-mips@vger.kernel.org" , Sudip Mukherjee , Dinh Nguyen , "linux-usb@vger.kernel.org" , Palmer Dabbelt , Masami Hiramatsu , "linux-alpha@vger.kernel.org" , "linux-mtd@lists.infradead.org" , David Woodhouse , "David S . Miller" , Alexander Viro Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Christophe Leroy writes: > Le 09/11/2023 =C3=A0 11:18, Michael Ellerman a =C3=A9crit=C2=A0: >> "Arnd Bergmann" writes: >>> On Wed, Nov 8, 2023, at 19:31, Christophe Leroy wrote: >>>> Le 08/11/2023 =C3=A0 13:58, Arnd Bergmann a =C3=A9crit=C2=A0: >>> >>>> powerpc has functions doing more or less the same, they are called >>>> __c_kernel_clock_gettime() and alike with their prototypes siting in >>>> arch/powerpc/include/asm/vdso/gettimeofday.h >>>> >>>> Should those prototypes be moved to include/vdso/gettime.h too and >>>> eventually renamed, or are they considered too powerpc specific ? >>> >>> I don't actually know, my initial interpretation was that >>> these function names are part of the user ABI for the vdso, >>> but I never looked closely enough at how vdso works to >>> be sure what the actual ABI is. >>=20 >> AFAIK the ABI is just the symbols we export, as defined in the linker >> script: >>=20 >> /* >> * This controls what symbols we export from the DSO. >> */ >> VERSION >> { >> VDSO_VERSION_STRING { >> global: >> __kernel_get_syscall_map; >> __kernel_gettimeofday; >> __kernel_clock_gettime; >> __kernel_clock_getres; >> __kernel_get_tbfreq; >> __kernel_sync_dicache; >> __kernel_sigtramp_rt64; >> __kernel_getcpu; >> __kernel_time; >>=20 >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/= arch/powerpc/kernel/vdso/vdso64.lds.S?h=3Dv6.6&#n117 >>=20 >>> If __c_kernel_clock_gettime() etc are not part of the user-facing >>> ABI, I think renaming them for consistency with the other >>> architectures would be best. >>=20 >> The __c symbols are not part of the ABI, so we could rename them. >>=20 >> At the moment though they don't have the same prototype as the generic >> versions, because we find the VDSO data in asm and pass it to the C >> functions, eg: >>=20 >> int __c_kernel_gettimeofday(struct __kernel_old_timeval *tv, struct time= zone *tz, >> const struct vdso_data *vd); >>=20 >> I think we can rework that though, by implementing >> __arch_get_vdso_data() and getting the vdso_data in C. Then we'd be able >> to share the prototypes. > > I think it would not a been good idea, it would be less performant, for=20 > explanation see commit=20 > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit= /?id=3De876f0b69dc993e86ca7795e63e98385aa9a7ef3 Ah thanks. I was wondering why you had done it in asm. It's a pity but you're right that's probably a measurable performance hit for some of those calls. cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95EB7C4332F for ; Thu, 9 Nov 2023 12:23:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 98BB210E0EB; Thu, 9 Nov 2023 12:23:42 +0000 (UTC) Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2AF9110E0EB for ; Thu, 9 Nov 2023 12:23:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1699532610; bh=R2IIgl4ZRFgwipCQ4ZBWquxZCbtnLxeQT8yMzVcSClk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=JOE+Y96nQb0g0fD7YjgIsTtXOrsQ0zdJ9Xit6bae239vdgrtE8Xe20tGEjOEwp6b5 bBGasTtN2qhciM6Vxj5gO1APMLHXfhhNabxTTxDpDoDz6AXcIv0hdu9+rRXuZNmSj3 PriUuPEOny5OCaNxYhuQeMYyhW0D7Uuip11fA5kii4KmxM9zaRV2MnEviCDpMHy6zq fUfZ9elCA6bj44/a3P1CQqNaCruTVzrNA2B2UxDQEd/EBpaSM5DHluHgXy74J1JLYp rlgnpTfcT5fdD0htnPYkbVFENF7DqxPzxI5N3NUPYBgm/lUlPDoiySV3dJVovZ01Br M0UtCQNJ+RaEQ== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4SR1MD6jtmz4wd2; Thu, 9 Nov 2023 23:23:20 +1100 (AEDT) From: Michael Ellerman To: Christophe Leroy , Arnd Bergmann , Arnd Bergmann , Andrew Morton , "linux-kernel@vger.kernel.org" , Masahiro Yamada , "linux-kbuild@vger.kernel.org" Subject: Re: [PATCH 15/22] arch: vdso: consolidate gettime prototypes In-Reply-To: <886df4e4-9fc2-ca52-e7e9-53688e6e821a@csgroup.eu> References: <20231108125843.3806765-1-arnd@kernel.org> <20231108125843.3806765-16-arnd@kernel.org> <87o7g3qlf5.fsf@mail.lhotse> <886df4e4-9fc2-ca52-e7e9-53688e6e821a@csgroup.eu> Date: Thu, 09 Nov 2023 23:23:20 +1100 Message-ID: <87il6bqfnr.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Juri Lelli , "linux-fbdev@vger.kernel.org" , "x86@kernel.org" , "loongarch@lists.linux.dev" , "linux-sh@vger.kernel.org" , Peter Zijlstra , Catalin Marinas , "dri-devel@lists.freedesktop.org" , Netdev , guoren , "linux-csky@vger.kernel.org" , "sparclinux@vger.kernel.org" , "linux-riscv@lists.infradead.org" , Vincenzo Frascino , Will Deacon , Greg Ungerer , Nicolas Schier , "linux-s390@vger.kernel.org" , Vincent Guittot , Helge Deller , Huacai Chen , Russell King , Anil S Keshavamurthy , Ard Biesheuvel , "linux-bcachefs@vger.kernel.org" , Ingo Molnar , Vineet Gupta , "Naveen N. Rao" , Matt Turner , "linux-snps-arc@lists.infradead.org" , "linux-trace-kernel@vger.kernel.org" , Kees Cook , Heiko Carstens , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , "linuxppc-dev@lists.ozlabs.org" , Nicholas Piggin , Nathan Chancellor , "linux-m68k@lists.linux-m68k.org" , Steven Rostedt , Andy Lutomirski , John Paul Adrian Glaubitz , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" , Michal Simek , Thomas Bogendoerfer , "linux-parisc@vger.kernel.org" , Timur Tabi , Geoff Levand , Greg Kroah-Hartman , Kent Overstreet , Nick Desaulniers , "linux-mips@vger.kernel.org" , Sudip Mukherjee , Dinh Nguyen , "linux-usb@vger.kernel.org" , Palmer Dabbelt , Masami Hiramatsu , "linux-alpha@vger.kernel.org" , "linux-mtd@lists.infradead.org" , David Woodhouse , "David S . Miller" , Alexander Viro Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Christophe Leroy writes: > Le 09/11/2023 =C3=A0 11:18, Michael Ellerman a =C3=A9crit=C2=A0: >> "Arnd Bergmann" writes: >>> On Wed, Nov 8, 2023, at 19:31, Christophe Leroy wrote: >>>> Le 08/11/2023 =C3=A0 13:58, Arnd Bergmann a =C3=A9crit=C2=A0: >>> >>>> powerpc has functions doing more or less the same, they are called >>>> __c_kernel_clock_gettime() and alike with their prototypes siting in >>>> arch/powerpc/include/asm/vdso/gettimeofday.h >>>> >>>> Should those prototypes be moved to include/vdso/gettime.h too and >>>> eventually renamed, or are they considered too powerpc specific ? >>> >>> I don't actually know, my initial interpretation was that >>> these function names are part of the user ABI for the vdso, >>> but I never looked closely enough at how vdso works to >>> be sure what the actual ABI is. >>=20 >> AFAIK the ABI is just the symbols we export, as defined in the linker >> script: >>=20 >> /* >> * This controls what symbols we export from the DSO. >> */ >> VERSION >> { >> VDSO_VERSION_STRING { >> global: >> __kernel_get_syscall_map; >> __kernel_gettimeofday; >> __kernel_clock_gettime; >> __kernel_clock_getres; >> __kernel_get_tbfreq; >> __kernel_sync_dicache; >> __kernel_sigtramp_rt64; >> __kernel_getcpu; >> __kernel_time; >>=20 >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/= arch/powerpc/kernel/vdso/vdso64.lds.S?h=3Dv6.6&#n117 >>=20 >>> If __c_kernel_clock_gettime() etc are not part of the user-facing >>> ABI, I think renaming them for consistency with the other >>> architectures would be best. >>=20 >> The __c symbols are not part of the ABI, so we could rename them. >>=20 >> At the moment though they don't have the same prototype as the generic >> versions, because we find the VDSO data in asm and pass it to the C >> functions, eg: >>=20 >> int __c_kernel_gettimeofday(struct __kernel_old_timeval *tv, struct time= zone *tz, >> const struct vdso_data *vd); >>=20 >> I think we can rework that though, by implementing >> __arch_get_vdso_data() and getting the vdso_data in C. Then we'd be able >> to share the prototypes. > > I think it would not a been good idea, it would be less performant, for=20 > explanation see commit=20 > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit= /?id=3De876f0b69dc993e86ca7795e63e98385aa9a7ef3 Ah thanks. I was wondering why you had done it in asm. It's a pity but you're right that's probably a measurable performance hit for some of those calls. cheers