From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC09DE7E62E for ; Tue, 26 Sep 2023 12:46:38 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ql7SC-00007r-V1; Tue, 26 Sep 2023 08:46:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ql7Rm-0008TO-KC for qemu-devel@nongnu.org; Tue, 26 Sep 2023 08:45:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ql7Rk-0001Iw-Qf for qemu-devel@nongnu.org; Tue, 26 Sep 2023 08:45:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695732348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=102Adaa5ytwMpqUCVndWbDEJYME+NThJ8Ir1KnNyN2M=; b=goYFX4DdjXeru6JXCi/fvq8Fl1VcWc3LylcDS7/xQ33M4K5fjMOGYbeCaeKJtNbDpHjJmP nN1bfnPVa15aP1cgecH0FfsnWJCounTBAwmVMTLSCdB/FYcLQLlYAqJOhTS8Uj7pRJE68N s0OX/YBmDXHOYBL5KXIBy1rlAlK+mbY= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-592-pxM8KgsiNoqFkPVKPG4S-w-1; Tue, 26 Sep 2023 08:45:46 -0400 X-MC-Unique: pxM8KgsiNoqFkPVKPG4S-w-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CEF711C0782D for ; Tue, 26 Sep 2023 12:45:45 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AD6B12026D4B for ; Tue, 26 Sep 2023 12:45:45 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id A0C4A21E6900; Tue, 26 Sep 2023 14:45:44 +0200 (CEST) From: Markus Armbruster To: Thomas Huth Cc: Paolo Bonzini , qemu-devel@nongnu.org Subject: Re: [PATCH] m48t59-test: remove shadowed variables and cleanup References: <20230925144744.527958-3-pbonzini@redhat.com> <18979284-cb15-4122-bcde-6aecb9a2134a@redhat.com> Date: Tue, 26 Sep 2023 14:45:44 +0200 In-Reply-To: <18979284-cb15-4122-bcde-6aecb9a2134a@redhat.com> (Thomas Huth's message of "Mon, 25 Sep 2023 17:09:13 +0200") Message-ID: <87il7xrtl3.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 22 X-Spam_score: 2.2 X-Spam_bar: ++ X-Spam_report: (2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, TVD_SUBJ_WIPE_DEBT=1.004 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Thomas Huth writes: > On 25/09/2023 16.47, Paolo Bonzini wrote: >> Rename the variable "s" and, while at it, avoid the chance of an overflow in the >> computation of ABS(t - s). >> Signed-off-by: Paolo Bonzini >> --- >> tests/qtest/m48t59-test.c | 17 ++++++++++------- >> 1 file changed, 10 insertions(+), 7 deletions(-) > > I've got a patch for this in my pull request from today already: > > https://lore.kernel.org/qemu-devel/20230925090100.45632-4-thuth@redhat.com Commit 926bef1d82bb9eb7a752aa128d9e70b808906243. Paolo's patch still applies, and "avoid the chance of an overflow in the computation of ABS(t - s)" makes me think we still want it. The commit message needs a tweak, though, since the patch no longer removes shadowed variables.