From: Kalle Valo <kvalo@kernel.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Polaris Pi <pinkperfect2021@gmail.com>,
matthewmwang@chromium.org, kuba@kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v7] wifi: mwifiex: Fix OOB and integer underflow when rx packets
Date: Thu, 27 Jul 2023 09:10:20 +0300 [thread overview]
Message-ID: <87ila528c3.fsf@kernel.org> (raw)
In-Reply-To: <ZMGO3r44oOtMck7S@google.com> (Brian Norris's message of "Wed, 26 Jul 2023 14:23:42 -0700")
Brian Norris <briannorris@chromium.org> writes:
> On Sun, Jul 23, 2023 at 07:07:41AM +0000, Polaris Pi wrote:
>> Make sure mwifiex_process_mgmt_packet,
>> mwifiex_process_sta_rx_packet and mwifiex_process_uap_rx_packet,
>> mwifiex_uap_queue_bridged_pkt and mwifiex_process_rx_packet
>> not out-of-bounds access the skb->data buffer.
>>
>> Fixes: 2dbaf751b1de ("mwifiex: report received management frames to cfg80211")
>> Signed-off-by: Polaris Pi <pinkperfect2021@gmail.com>
>> ---
>> V5: Follow chromeos comments: preserve the original flow of mwifiex_process_uap_rx_packet
>> V6: Simplify check in mwifiex_process_uap_rx_packet
>> V7: Fix drop packets issue when auotest V6, now pass manual and auto tests
>
> "auto tests" isn't clear to anyone not familiar with Chromium stuff.
> It'd be courteous to at least make an attempt to describe what this
> means (even just, "ChromeOS WiFi test suite" or something). For the
> record, I believe that's approximately this?
>
> https://chromium.googlesource.com/chromiumos/third_party/autotest/+/HEAD/docs/wificell.md
>
> Anyway, I think the patch contents look good:
>
> Reviewed-by: Brian Norris <briannorris@chromium.org>
I'm nitpicking but now that you (Brian) are a maintainer I would prefer
that you use Acked-by instead of Reviewed-by. Patchwork shows the
statistics (A/R/T in the web ui) and then it's easy for me to see that
the patch is ready to be applied. This is for the future, no need to
change anything here.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-07-27 6:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-23 7:07 [PATCH v7] wifi: mwifiex: Fix OOB and integer underflow when rx packets Polaris Pi
2023-07-26 12:05 ` Matthew Wang
2023-07-26 21:23 ` Brian Norris
2023-07-27 6:10 ` Kalle Valo [this message]
2023-07-27 16:13 ` Brian Norris
2023-08-01 14:47 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ila528c3.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=briannorris@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=matthewmwang@chromium.org \
--cc=pinkperfect2021@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.