From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, git@xen0n.name, gaosong@loongson.cn,
philmd@linaro.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org,
qemu-arm@nongnu.org
Subject: Re: [PATCH v5 27/30] tcg/ppc: Remove unused constraint J
Date: Wed, 10 May 2023 14:53:30 +0100 [thread overview]
Message-ID: <87ild05m29.fsf@linaro.org> (raw)
In-Reply-To: <20230506072235.597467-28-richard.henderson@linaro.org>
Richard Henderson <richard.henderson@linaro.org> writes:
> Never used since its introduction.
>
> Fixes: 3d582c6179c ("tcg-ppc64: Rearrange integer constant constraints")
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/ppc/tcg-target-con-str.h | 1 -
> tcg/ppc/tcg-target.c.inc | 3 ---
> 2 files changed, 4 deletions(-)
>
> diff --git a/tcg/ppc/tcg-target-con-str.h b/tcg/ppc/tcg-target-con-str.h
> index 9dcbc3df50..094613cbcb 100644
> --- a/tcg/ppc/tcg-target-con-str.h
> +++ b/tcg/ppc/tcg-target-con-str.h
> @@ -16,7 +16,6 @@ REGS('v', ALL_VECTOR_REGS)
> * CONST(letter, TCG_CT_CONST_* bit set)
> */
> CONST('I', TCG_CT_CONST_S16)
> -CONST('J', TCG_CT_CONST_U16)
> CONST('M', TCG_CT_CONST_MONE)
> CONST('T', TCG_CT_CONST_S32)
> CONST('U', TCG_CT_CONST_U32)
> diff --git a/tcg/ppc/tcg-target.c.inc b/tcg/ppc/tcg-target.c.inc
> index 5a4ec0470a..0a14c3e997 100644
> --- a/tcg/ppc/tcg-target.c.inc
> +++ b/tcg/ppc/tcg-target.c.inc
> @@ -83,7 +83,6 @@
> #define SZR (TCG_TARGET_REG_BITS / 8)
>
> #define TCG_CT_CONST_S16 0x100
> -#define TCG_CT_CONST_U16 0x200
Arguably you could tidy up the bit masks to make it easier to add a
constraint later. But anyway:
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2023-05-10 13:54 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-06 7:22 [PATCH v5 00/30] tcg: Simplify calls to load/store helpers Richard Henderson
2023-05-06 7:22 ` [PATCH v5 01/30] tcg/i386: Introduce prepare_host_addr Richard Henderson
2023-05-10 8:38 ` Alex Bennée
2023-05-06 7:22 ` [PATCH v5 02/30] tcg/i386: Use indexed addressing for softmmu fast path Richard Henderson
2023-05-10 8:44 ` Alex Bennée
2023-05-06 7:22 ` [PATCH v5 03/30] tcg/aarch64: Introduce prepare_host_addr Richard Henderson
2023-05-10 8:52 ` Alex Bennée
2023-05-06 7:22 ` [PATCH v5 04/30] tcg/arm: " Richard Henderson
2023-05-10 8:59 ` Alex Bennée
2023-05-06 7:22 ` [PATCH v5 05/30] tcg/loongarch64: " Richard Henderson
2023-05-10 9:05 ` Alex Bennée
2023-05-06 7:22 ` [PATCH v5 06/30] tcg/mips: " Richard Henderson
2023-05-10 9:09 ` Alex Bennée
2023-05-06 7:22 ` [PATCH v5 07/30] tcg/ppc: " Richard Henderson
2023-05-10 9:10 ` Alex Bennée
2023-05-06 7:22 ` [PATCH v5 08/30] tcg/riscv: " Richard Henderson
2023-05-10 9:11 ` Alex Bennée
2023-05-10 9:26 ` Alex Bennée
2023-05-06 7:22 ` [PATCH v5 09/30] tcg/s390x: " Richard Henderson
2023-05-10 9:27 ` Alex Bennée
2023-05-06 7:22 ` [PATCH v5 10/30] tcg: Add routines for calling slow-path helpers Richard Henderson
2023-05-10 12:27 ` Alex Bennée
2023-05-06 7:22 ` [PATCH v5 11/30] tcg/i386: Convert tcg_out_qemu_ld_slow_path Richard Henderson
2023-05-10 13:12 ` Alex Bennée
2023-05-06 7:22 ` [PATCH v5 12/30] tcg/i386: Convert tcg_out_qemu_st_slow_path Richard Henderson
2023-05-10 13:13 ` Alex Bennée
2023-05-06 7:22 ` [PATCH v5 13/30] tcg/aarch64: Convert tcg_out_qemu_{ld,st}_slow_path Richard Henderson
2023-05-10 13:14 ` Alex Bennée
2023-05-06 7:22 ` [PATCH v5 14/30] tcg/arm: " Richard Henderson
2023-05-10 13:17 ` Alex Bennée
2023-05-06 7:22 ` [PATCH v5 15/30] tcg/loongarch64: Convert tcg_out_qemu_{ld, st}_slow_path Richard Henderson
2023-05-10 13:17 ` Alex Bennée
2023-05-06 7:22 ` [PATCH v5 16/30] tcg/mips: Convert tcg_out_qemu_{ld,st}_slow_path Richard Henderson
2023-05-10 13:39 ` [PATCH v5 16/30] tcg/mips: Convert tcg_out_qemu_{ld, st}_slow_path Alex Bennée
2023-05-10 13:39 ` [PATCH v5 16/30] tcg/mips: Convert tcg_out_qemu_{ld,st}_slow_path Alex Bennée
2023-05-06 7:22 ` [PATCH v5 17/30] tcg/ppc: " Richard Henderson
2023-05-10 13:40 ` Alex Bennée
2023-05-06 7:22 ` [PATCH v5 18/30] tcg/riscv: " Richard Henderson
2023-05-10 13:40 ` [PATCH v5 18/30] tcg/riscv: Convert tcg_out_qemu_{ld, st}_slow_path Alex Bennée
2023-05-10 13:40 ` [PATCH v5 18/30] tcg/riscv: Convert tcg_out_qemu_{ld,st}_slow_path Alex Bennée
2023-05-06 7:22 ` [PATCH v5 19/30] tcg/s390x: " Richard Henderson
2023-05-10 13:41 ` [PATCH v5 19/30] tcg/s390x: Convert tcg_out_qemu_{ld, st}_slow_path Alex Bennée
2023-05-10 13:41 ` [PATCH v5 19/30] tcg/s390x: Convert tcg_out_qemu_{ld,st}_slow_path Alex Bennée
2023-05-06 7:22 ` [PATCH v5 20/30] tcg/loongarch64: Simplify constraints on qemu_ld/st Richard Henderson
2023-05-10 13:43 ` Alex Bennée
2023-05-06 7:22 ` [PATCH v5 21/30] tcg/mips: Remove MO_BSWAP handling Richard Henderson
2023-05-10 13:49 ` Alex Bennée
2023-05-06 7:22 ` [PATCH v5 22/30] tcg/mips: Reorg tlb load within prepare_host_addr Richard Henderson
2023-05-10 13:49 ` Alex Bennée
2023-05-06 7:22 ` [PATCH v5 23/30] tcg/mips: Simplify constraints on qemu_ld/st Richard Henderson
2023-05-10 13:50 ` Alex Bennée
2023-05-06 7:22 ` [PATCH v5 24/30] tcg/ppc: Reorg tcg_out_tlb_read Richard Henderson
2023-05-10 13:51 ` Alex Bennée
2023-05-06 7:22 ` [PATCH v5 25/30] tcg/ppc: Adjust constraints on qemu_ld/st Richard Henderson
2023-05-10 13:51 ` Alex Bennée
2023-05-06 7:22 ` [PATCH v5 26/30] tcg/ppc: Remove unused constraints A, B, C, D Richard Henderson
2023-05-10 13:52 ` Alex Bennée
2023-05-06 7:22 ` [PATCH v5 27/30] tcg/ppc: Remove unused constraint J Richard Henderson
2023-05-10 13:53 ` Alex Bennée [this message]
2023-05-06 7:22 ` [PATCH v5 28/30] tcg/riscv: Simplify constraints on qemu_ld/st Richard Henderson
2023-05-10 13:57 ` Alex Bennée
2023-05-06 7:22 ` [PATCH v5 29/30] tcg/s390x: Use ALGFR in constructing softmmu host address Richard Henderson
2023-05-10 13:59 ` Alex Bennée
2023-05-06 7:22 ` [PATCH v5 30/30] tcg/s390x: Simplify constraints on qemu_ld/st Richard Henderson
2023-05-10 14:02 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ild05m29.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=gaosong@loongson.cn \
--cc=git@xen0n.name \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.