Re: [PATCH trace-cmd v2 0/3] trace-cmd filtering

[Gabriel Krisman Bertazi <krisman@suse.de>]

Gabriel Krisman Bertazi <krisman@suse.de> writes:

> Hi Steve,

I wanted to ping you regarding this patchset.  Do you intend to take
this as-is?

Thanks!

>
> This implements my fix to restore single input filtering behavior
> (bz217038) and adds support for global filters, as you requested.
>
> On another topic, a current behavior that seems weird in my opinion is
> that the following negates the second filter as well.
>
>   "trace-cmd -i trace.dat.1 -v -F tp1 -i trace.dat.2 -F tp2"
>
> I'd prefer that -v would apply only to the following -F. It'd allow me
> to do:
>
>   "trace-cmd -v -F 'mm_page_alloc' -i trace.dat.1 -i trace.dat.2 ... \
>              -i trace.dat.10 -F 'mm_page_alloc:order==1'"
>
> It obviously breaks the interface, so I didn't implement it here.  Would
> like to hear your input, though.  We could have a new syntax:
>
>   "trace-cmd ! -F tp1 -F tp2 ! -F tp3"
>
> Thanks,
>
> Gabriel Krisman Bertazi (3):
>   trace-cmd report: Ensure filter is applied to single input file
>   trace-cmd-report: Support global filters
>   documentation: trace-cmd-report: Document filter scope
>
>  .../trace-cmd/trace-cmd-report.1.txt          |  8 +++-
>  tracecmd/trace-read.c                         | 45 ++++++++++++-------
>  2 files changed, 34 insertions(+), 19 deletions(-)

-- 
Gabriel Krisman Bertazi