From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 407D4C678D4 for ; Mon, 6 Mar 2023 12:40:14 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZA88-0006bl-IA; Mon, 06 Mar 2023 07:39:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZA87-0006bd-NR for qemu-devel@nongnu.org; Mon, 06 Mar 2023 07:39:51 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZA85-00051B-Rb for qemu-devel@nongnu.org; Mon, 06 Mar 2023 07:39:51 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 02174223DB; Mon, 6 Mar 2023 12:39:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678106386; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hcnHdHMW7gGUqvBJQB1yYJVViNvQSxDBgt8bxteD4sI=; b=Gdh6fOB1vgbGqN0N78OtBuQk/7dMnqMyrXL9Ue6jchPiMEaHv50WNaLMn61hPqgFa1SjI9 /36+sWb/VkDxxL66SwddG78MNjLPLq9q+ket7EXF8cXBpvSzycvrVGg+HvE73Uegyugo5V 0/lN57nB+ZWrY0E5cBtSVKOvrOt3ZZg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678106386; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hcnHdHMW7gGUqvBJQB1yYJVViNvQSxDBgt8bxteD4sI=; b=mbphcret8cNlwJ7jO7fsW206/+yJTg7w6++8KhRGuc0/VFcJJB1biNhuVhZcFblYIXUbHA 0oUM9gA1QIVBtIDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8294F13A66; Mon, 6 Mar 2023 12:39:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /CvOEhHfBWRARAAAMHmgww (envelope-from ); Mon, 06 Mar 2023 12:39:45 +0000 From: Fabiano Rosas To: Alex =?utf-8?Q?Benn=C3=A9e?= Cc: Matheus Tavares Bernardino , qemu-devel@nongnu.org, philmd@linaro.org, tsimpson@quicinc.com Subject: Re: hexagon: check-tcg rebuilding up to date image In-Reply-To: <87jzzw3c6r.fsf@linaro.org> References: <3ccca5373de05be28b861c0e9e780c709703f0f7.1677862556.git.quic_mathbern@quicinc.com> <87mt4twl2l.fsf@suse.de> <87jzzw3c6r.fsf@linaro.org> Date: Mon, 06 Mar 2023 09:39:43 -0300 Message-ID: <87ilfevysw.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=195.135.220.28; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Alex Benn=C3=A9e writes: > Fabiano Rosas writes: > >> Matheus Tavares Bernardino writes: >> >>> Hi, >>> >>> We noticed that local `make check-tcg` is rebuilding the docker image >>> for qemu-hexagon at every run, whereas previously it would say "Image is >>> up to date" and move on. >>> >>> This was changed at 0b1a649047 (tests/docker: use direct RUNC call to >>> build containers, 2023-02-28), where we started to no longer use >>> docker.py and its image_matches_dockerfile() to skip image builds. >>> >>> Is this new behavior by design? Or perhaps do we have some local >>> docker misconfiguration that is not correctly using caches? >> >> Hi, >> >> We started relying on docker for the cache. Are you using docker or >> podman? There should be a RUNC variable in config-host.mak that you can >> check. >> >> And for the record, which version of either podman or docker? >> >> >> Alex,=20 >> >> I think we might need to add DOCKER_BUILDKIT=3D1 $(RUNC) ... to properly >> make use of caching with docker. As for podman, I'm seeing conflicting >> information on the web as to whether it even supports caching. > > As opposed to --build-arg BUILDKIT_INLINE_CACHE=3D1 or both? Both. As I understand it, DOCKER_BUILDKIT=3D1 enables buildkit and BUILDKIT_INLINE_CACHE=3D1 embeds metadata in the image so that when you push/pull the metadata goes along (as opposed to having the cache as a separate artifact from the image).