From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C85AC678D4 for ; Thu, 2 Mar 2023 15:44:15 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXl5T-0000dr-Tm; Thu, 02 Mar 2023 10:43:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXl5R-0000de-NF for qemu-devel@nongnu.org; Thu, 02 Mar 2023 10:43:17 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXl5Q-0006Sp-2G for qemu-devel@nongnu.org; Thu, 02 Mar 2023 10:43:17 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5997421F67; Thu, 2 Mar 2023 15:43:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1677771794; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eKJPQmbT79gx8JJovpCdgvlLmLpp+fVxp0XmRYB4YGo=; b=MkSudaiSuRsoB/bw8CVgRpfosWJ7PWpHL4Cshnr08Awa006OOPAZR8eciYAL/6Sdq7ylzz YAzA8WnzwkfnbDhjqKRoE363I0LQfbZBYpdNReFFZEppc5pPw2WotYb+zjZ270wKMqvWbm 1p+OOYP6jsIH2BoXhnMQLCbOIZPQiC8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1677771794; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eKJPQmbT79gx8JJovpCdgvlLmLpp+fVxp0XmRYB4YGo=; b=/2Mep+VWRpwI9t6Noc+uN52riSTCXr/48kz8MAYKeECspxVf4mZ7v58p55lZyEkWp3OPPn BTBo0e3MTbVarhCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CEE2413A63; Thu, 2 Mar 2023 15:43:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id CeZcJRHEAGToEQAAMHmgww (envelope-from ); Thu, 02 Mar 2023 15:43:13 +0000 From: Fabiano Rosas To: Igor Mammedov Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, ani@anisinha.ca, berrange@redhat.com, thuth@redhat.com Subject: Re: [PATCH 14/33] tests: acpi: update expected blobs In-Reply-To: <20230302155719.357c92fa@imammedo.users.ipa.redhat.com> References: <20230224153812.4176226-1-imammedo@redhat.com> <20230224153812.4176226-15-imammedo@redhat.com> <20230301192428-mutt-send-email-mst@kernel.org> <20230302130251.4ef53268@imammedo.users.ipa.redhat.com> <87a60vwbwj.fsf@suse.de> <20230302155719.357c92fa@imammedo.users.ipa.redhat.com> Date: Thu, 02 Mar 2023 12:43:11 -0300 Message-ID: <87ilfj2m7k.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=195.135.220.28; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Igor Mammedov writes: > On Thu, 02 Mar 2023 09:55:24 -0300 > Fabiano Rosas wrote: > >> Igor Mammedov writes: >> >> > On Wed, 1 Mar 2023 19:27:33 -0500 >> > "Michael S. Tsirkin" wrote: >> > >> >> On Fri, Feb 24, 2023 at 04:37:53PM +0100, Igor Mammedov wrote: >> >> > only following context change: >> >> > - Local1 = Zero >> >> > If ((Arg0 != ToUUID ("e5c937d0-3553-4d7a-9117-ea4d19c3434d") /* Device Labeling Interface */)) >> >> > { >> >> > Return (Local0) >> >> > ... >> >> > Return (Local0) >> >> > } >> >> > >> >> > + Local1 = Zero >> >> > Local2 = AIDX (DerefOf (Arg4 [Zero]), DerefOf (Arg4 [One] >> >> > >> >> > Signed-off-by: Igor Mammedov >> >> >> >> Nope: >> >> >> >> diff -ru -N -IDisassembly -IChecksum '-I* Length ' old/asl/tests/data/acpi/q35/DSDT.viot.dsl new/asl/tests/data/acpi/q35/DSDT.viot.dsl >> >> :--- old/asl/tests/data/acpi/q35/DSDT.viot.dsl 2023-03-01 19:22:57.636454958 -0500 >> >> :+++ new/asl/tests/data/acpi/q35/DSDT.viot.dsl 2023-03-01 19:22:58.451460462 -0500 >> >> :@@ -148,7 +148,6 @@ >> >> { >> >> 0x00 // . >> >> } >> >> - Local1 = Zero >> >> If ((Arg0 != ToUUID ("e5c937d0-3553-4d7a-9117-ea4d19c3434d") /* Device Labeling Interface */)) >> >> { >> >> Return (Local0) >> >> :@@ -159,12 +158,14 @@ >> >> Return (Local0) >> >> } >> >> >> >> + Local1 = Zero >> >> Local2 = AIDX (DerefOf (Arg4 [Zero]), DerefOf (Arg4 [One] >> >> )) >> >> If (!((Local2 == Zero) | (Local2 == 0xFFFFFFFF))) >> >> { >> >> Local1 |= One >> >> Local1 |= (One << 0x07) >> >> + Local1 |= (One << 0x05) >> >> } >> >> >> >> Local0 [Zero] = Local1 >> >> >> >> >> >> and the funny thing is, the second change is in the expected >> >> file but not in the code so this patch causes the test to fail. >> > >> > above diff is remnants of some old version of the patch before >> > patches were reshuffled. >> > >> > for some reason q35/viot test gets skipped => no table rebuild => stale DSDT.viot table >> > >> > reverting recently merged commit c471eb4f40, I can get q35/viot test back: >> > >> > commit c471eb4f40445908c1be7bb11a37ac676a0edae7 >> > Author: Fabiano Rosas >> > Date: Wed Feb 8 16:46:57 2023 -0300 >> > >> > tests/qtest: Check for devices in bios-tables-test >> > >> > so checks aren't working as expected on my host for some reason >> > >> >> Was this a legitimate skip or do we have a bug in the way we check for >> devices? I.e. did you have CONFIG_VIRTIO_IOMMU in the build? > > config should be there since with your patch reverted viot test runs and passes just fine > so I'd assume it is a bug somewhere in check code > Probably easier to just revert the patch then. We have stopped building bios-tables-test.c when CONFIG_PARALLEL is not present, so the build --without-default-devices is already covered. We would only need those checks if PCI_DEVICES=n or one of the individual CONFIGs, which we have discussed previously that is not worth the effort to keep track of.