All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: qemu-devel@nongnu.org,  John Snow <jsnow@redhat.com>,
	 Halil Pasic <pasic@linux.ibm.com>,
	 Christian Borntraeger <borntraeger@linux.ibm.com>,
	Fam Zheng <fam@euphon.net>,
	 Alex Williamson <alex.williamson@redhat.com>,
	 qemu-s390x@nongnu.org,  Thomas Huth <thuth@redhat.com>,
	 Eric Farman <farman@linux.ibm.com>,
	 Stefan Hajnoczi <stefanha@redhat.com>,
	 Eric Blake <eblake@redhat.com>,
	 Richard Henderson <richard.henderson@linaro.org>,
	 qemu-block@nongnu.org,
	 "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	 Ilya Leoshkevich <iii@linux.ibm.com>,
	David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH v2 3/3] migration: Rename res_{postcopy,precopy}_only
Date: Wed, 15 Feb 2023 19:15:01 +0100	[thread overview]
Message-ID: <87ilg2ztga.fsf@secure.mitica> (raw)
In-Reply-To: <6b46bb8a-cbdd-b2d9-e542-a28d598d0140@yandex-team.ru> (Vladimir Sementsov-Ogievskiy's message of "Wed, 15 Feb 2023 20:53:29 +0300")

Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> wrote:
> On 15.02.23 20:03, Juan Quintela wrote:
>> Once that res_compatible is removed, they don't make sense anymore.
>> We remove the _only preffix.  And to make things clearer we rename
>> them to must_precopy and can_postcopy.
>> Signed-off-by: Juan Quintela<quintela@redhat.com>
>
> Ideally headers of trace events (trace_vfio_state_pending, trace_migrate_pending_estimate, trace_migrate_pending_exact)
> should be changed correspondingly.

They already use abrevs:

migrate_pending_estimate(uint64_t size, uint64_t pre, uint64_t post) "estimate pending size %" PRIu64 " (pre = %" PRIu64 " post=%" PRIu64 ")"

So I don't feel like doing bigger lines.

> with or without:
>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>

Thanks.



      reply	other threads:[~2023-02-15 18:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-15 17:03 [PATCH v2 0/3] Remove res_compatible parameter Juan Quintela
2023-02-15 17:03 ` [PATCH v2 1/3] migration: In case of postcopy, the memory ends in res_postcopy_only Juan Quintela
2023-02-15 17:34   ` Vladimir Sementsov-Ogievskiy
2023-02-15 17:03 ` [PATCH v2 2/3] migration: Remove unused res_compatible Juan Quintela
2023-02-15 17:03 ` [PATCH v2 3/3] migration: Rename res_{postcopy,precopy}_only Juan Quintela
2023-02-15 17:53   ` Vladimir Sementsov-Ogievskiy
2023-02-15 18:15     ` Juan Quintela [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ilg2ztga.fsf@secure.mitica \
    --to=quintela@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=fam@euphon.net \
    --cc=farman@linux.ibm.com \
    --cc=iii@linux.ibm.com \
    --cc=jsnow@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    --cc=vsementsov@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.