From: Juan Quintela <quintela@redhat.com>
To: Zhenzhong Duan <zhenzhong.duan@intel.com>
Cc: qemu-devel@nongnu.org, dgilbert@redhat.com, peterx@redhat.com,
zhengchuan@huawei.com, huangy81@chinatelecom.cn
Subject: Re: [PATCH] migration/dirtyrate: Show sample pages only in page-sampling mode
Date: Thu, 02 Feb 2023 16:25:59 +0100 [thread overview]
Message-ID: <87ilgknl6g.fsf@secure.mitica> (raw)
In-Reply-To: <20221129040404.4151126-1-zhenzhong.duan@intel.com> (Zhenzhong Duan's message of "Tue, 29 Nov 2022 12:04:04 +0800")
Zhenzhong Duan <zhenzhong.duan@intel.com> wrote:
> The value of "Sample Pages" is confusing in mode other than page-sampling.
> See below:
>
> (qemu) calc_dirty_rate -b 10 520
> (qemu) info dirty_rate
> Status: measuring
> Start Time: 11646834 (ms)
> Sample Pages: 520 (per GB)
> Period: 10 (sec)
> Mode: dirty-bitmap
> Dirty rate: (not ready)
>
> (qemu) info dirty_rate
> Status: measured
> Start Time: 11646834 (ms)
> Sample Pages: 0 (per GB)
> Period: 10 (sec)
> Mode: dirty-bitmap
> Dirty rate: 2 (MB/s)
>
> While it's totally useless in dirty-ring and dirty-bitmap mode, fix to
> show it only in page-sampling mode.
>
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
queued.
prev parent reply other threads:[~2023-02-02 15:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 4:04 [PATCH] migration/dirtyrate: Show sample pages only in page-sampling mode Zhenzhong Duan
2022-11-29 15:23 ` Peter Xu
2023-02-02 15:25 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilgknl6g.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=huangy81@chinatelecom.cn \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhengchuan@huawei.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.