From: Kalle Valo <kvalo@kernel.org>
To: Shayne Chen <shayne.chen@mediatek.com>
Cc: Felix Fietkau <nbd@nbd.name>,
linux-wireless <linux-wireless@vger.kernel.org>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Ryder Lee <ryder.lee@mediatek.com>,
Evelyn Tsai <evelyn.tsai@mediatek.com>,
Bo Jiao <Bo.Jiao@mediatek.com>,
linux-mediatek <linux-mediatek@lists.infradead.org>,
Peter Chiu <chui-hao.chiu@mediatek.com>,
Howard Hsu <howard-yh.hsu@mediatek.com>,
MeiChia Chiu <meichia.chiu@mediatek.com>,
StanleyYP Wang <StanleyYP.Wang@mediatek.com>,
Money Wang <Money.Wang@mediatek.com>
Subject: Re: [PATCH v2 9/9] wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices
Date: Mon, 21 Nov 2022 17:07:40 +0200 [thread overview]
Message-ID: <87ilj8pcqr.fsf@kernel.org> (raw)
In-Reply-To: <20221110093525.29649-10-shayne.chen@mediatek.com> (Shayne Chen's message of "Thu, 10 Nov 2022 17:35:25 +0800")
Shayne Chen <shayne.chen@mediatek.com> writes:
> Add MediaTek new mac80211 driver mt7996 for Wi-Fi 7 (802.11be) devices.
> The driver first supports Filogic 680 PCI device, which is a Wi-Fi 7
> chipset supporting concurrent tri-band operation at 6 GHz, 5 GHz, and
> 2.4 GHz with 4x4 antennas on each band.
>
> Currently, mt7996 only supports tri-band HE or older mode.
> EHT mode and more variants of Filogic 680 support will be introduced
> in further patches.
>
> Reviewed-by: Ryder Lee <ryder.lee@mediatek.com>
> Co-developed-by: Peter Chiu <chui-hao.chiu@mediatek.com>
> Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com>
> Co-developed-by: Bo Jiao <Bo.Jiao@mediatek.com>
> Signed-off-by: Bo Jiao <Bo.Jiao@mediatek.com>
> Co-developed-by: Howard Hsu <howard-yh.hsu@mediatek.com>
> Signed-off-by: Howard Hsu <howard-yh.hsu@mediatek.com>
> Co-developed-by: MeiChia Chiu <meichia.chiu@mediatek.com>
> Signed-off-by: MeiChia Chiu <meichia.chiu@mediatek.com>
> Co-developed-by: StanleyYP Wang <StanleyYP.Wang@mediatek.com>
> Signed-off-by: StanleyYP Wang <StanleyYP.Wang@mediatek.com>
> Co-developed-by: Money Wang <Money.Wang@mediatek.com>
> Signed-off-by: Money Wang <Money.Wang@mediatek.com>
> Co-developed-by: Evelyn Tsai <evelyn.tsai@mediatek.com>
> Signed-off-by: Evelyn Tsai <evelyn.tsai@mediatek.com>
> Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
> ---
> drivers/net/wireless/mediatek/mt76/Kconfig | 1 +
> drivers/net/wireless/mediatek/mt76/Makefile | 1 +
> .../net/wireless/mediatek/mt76/mt7996/Kconfig | 12 +
> .../wireless/mediatek/mt76/mt7996/Makefile | 6 +
> .../wireless/mediatek/mt76/mt7996/debugfs.c | 851 ++++
> .../net/wireless/mediatek/mt76/mt7996/dma.c | 360 ++
> .../wireless/mediatek/mt76/mt7996/eeprom.c | 229 ++
> .../wireless/mediatek/mt76/mt7996/eeprom.h | 75 +
> .../net/wireless/mediatek/mt76/mt7996/init.c | 816 ++++
> .../net/wireless/mediatek/mt76/mt7996/mac.c | 2468 ++++++++++++
> .../net/wireless/mediatek/mt76/mt7996/mac.h | 398 ++
> .../net/wireless/mediatek/mt76/mt7996/main.c | 1325 +++++++
> .../net/wireless/mediatek/mt76/mt7996/mcu.c | 3428 +++++++++++++++++
> .../net/wireless/mediatek/mt76/mt7996/mcu.h | 662 ++++
> .../net/wireless/mediatek/mt76/mt7996/mmio.c | 385 ++
> .../wireless/mediatek/mt76/mt7996/mt7996.h | 516 +++
> .../net/wireless/mediatek/mt76/mt7996/pci.c | 222 ++
> .../net/wireless/mediatek/mt76/mt7996/regs.h | 533 +++
> 18 files changed, 12288 insertions(+)
This patch is too big, please split it. One patch per file is a good
rule of thumb.
I did see some suspicious static variables in pci.c, but otherwise I
basically skipped everything.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-11-21 15:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 9:35 [PATCH v2 0/9] Add driver for MediaTek Wi-Fi 7 devices Shayne Chen
2022-11-10 9:35 ` [PATCH v2 1/9] wifi: mt76: connac: rework macros for unified command Shayne Chen
2022-11-10 9:35 ` [PATCH v2 2/9] wifi: mt76: connac: update struct sta_rec_phy Shayne Chen
2022-11-10 9:35 ` [PATCH v2 3/9] wifi: mt76: connac: rework fields for larger bandwidth support in sta_rec_bf Shayne Chen
2022-11-10 9:35 ` [PATCH v2 4/9] wifi: mt76: connac: add more unified command IDs Shayne Chen
2022-11-10 9:35 ` [PATCH v2 5/9] wifi: mt76: connac: introduce unified event table Shayne Chen
2022-11-10 9:35 ` [PATCH v2 6/9] wifi: mt76: connac: add more bss info command tags Shayne Chen
2022-11-10 9:35 ` [PATCH v2 7/9] wifi: mt76: connac: add more starec " Shayne Chen
2022-11-10 9:35 ` [PATCH v2 8/9] wifi: mt76: connac: introduce helper for mt7996 chipset Shayne Chen
2022-11-10 9:35 ` [PATCH v2 9/9] wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices Shayne Chen
2022-11-21 15:07 ` Kalle Valo [this message]
2022-11-21 19:45 ` Ryder Lee
2022-11-23 7:36 ` Kalle Valo
2022-11-22 9:04 ` Shayne Chen (陳軒丞)
2022-11-22 9:04 ` shayne.chen
2022-11-23 7:37 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilj8pcqr.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=Bo.Jiao@mediatek.com \
--cc=Money.Wang@mediatek.com \
--cc=StanleyYP.Wang@mediatek.com \
--cc=chui-hao.chiu@mediatek.com \
--cc=evelyn.tsai@mediatek.com \
--cc=howard-yh.hsu@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=meichia.chiu@mediatek.com \
--cc=nbd@nbd.name \
--cc=ryder.lee@mediatek.com \
--cc=shayne.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.