From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFBE2C4332F for ; Wed, 19 Oct 2022 13:32:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230490AbiJSNcn (ORCPT ); Wed, 19 Oct 2022 09:32:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231197AbiJSNc3 (ORCPT ); Wed, 19 Oct 2022 09:32:29 -0400 X-Greylist: delayed 3278 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 19 Oct 2022 06:20:13 PDT Received: from mail.tkos.co.il (guitar.tkos.co.il [84.110.109.230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F30BC169CE9; Wed, 19 Oct 2022 06:20:11 -0700 (PDT) Received: from tarshish (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.tkos.co.il (Postfix) with ESMTPS id 2C3DF4405F3; Wed, 19 Oct 2022 14:33:29 +0300 (IDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tkos.co.il; s=default; t=1666179209; bh=ooaBlWbe5BcZsvcnQ+dv/mblh3tcKd5KddrxqCXz3KU=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=JZ9JJhnUc4iGBEbErU9+6FWc8In32oTPsUWUiL6K8VCaeboHtYJCVy/zFeGe0dZKo xtOBZACMqlXoeSc7aofFlgrePrxrjQSDup04FdpPxx5wuc8rPfSS0RqbhLpDYCOu+7 IR6QfRm6Ttq+cfXPiAK+yHjw4WH9QmSDqFEQOvDrpbwEm3LD/3EZVPNVNfS6GqELqp FzqaTS+q1q8GaMGD77v5jN0yq/N9Ln76ffcSHSAYiwZZEkDdVovZ4RS4Oh79/V8ouZ urJDMHZeRR59SBMN2/tI4Iw8veCDtljJqT9xE/3CAxssMIQE7PtTcXhUUJT1DSzd8l hNFpkzPfswIKg== References: <20221019091151.6692-1-ilpo.jarvinen@linux.intel.com> <20221019091151.6692-15-ilpo.jarvinen@linux.intel.com> User-agent: mu4e 1.8.10; emacs 27.1 From: Baruch Siach To: Ilpo =?utf-8?Q?J=C3=A4rvinen?= Cc: linux-serial@vger.kernel.org, Greg KH , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andy Shevchenko Subject: Re: [PATCH 14/44] serial: digicolor: Use uart_xmit_advance() Date: Wed, 19 Oct 2022 14:30:51 +0300 In-reply-to: <20221019091151.6692-15-ilpo.jarvinen@linux.intel.com> Message-ID: <87ilkgdp17.fsf@tarshish> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Hi Ilpo, On Wed, Oct 19 2022, Ilpo J=C3=A4rvinen wrote: > Take advantage of the new uart_xmit_advance() helper. > > Signed-off-by: Ilpo J=C3=A4rvinen Acked-by: Baruch Siach Thanks, baruch > --- > drivers/tty/serial/digicolor-usart.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/digicolor-usart.c b/drivers/tty/serial/di= gicolor-usart.c > index 0c0a62346f23..ed197705f7ee 100644 > --- a/drivers/tty/serial/digicolor-usart.c > +++ b/drivers/tty/serial/digicolor-usart.c > @@ -202,8 +202,7 @@ static void digicolor_uart_tx(struct uart_port *port) >=20=20 > while (!uart_circ_empty(xmit)) { > writeb(xmit->buf[xmit->tail], port->membase + UA_EMI_REC); > - xmit->tail =3D (xmit->tail + 1) & (UART_XMIT_SIZE - 1); > - port->icount.tx++; > + uart_xmit_advance(port, 1); >=20=20 > if (digicolor_uart_tx_full(port)) > break; --=20 ~. .~ Tk Open Systems =3D}------------------------------------------------ooO--U--Ooo------------= {=3D - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40850C433FE for ; Wed, 19 Oct 2022 11:37:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r3wsw+PxrKu5RUmN+T4SGZz35y3rnTCX//v9pfYb+Lw=; b=jIsiRun7XoFmaY 6R9/Gp2XrPJ0RF0JoTDY0L1RkweGQNFlwAlLL20Kkj3axxHHEPdZ7Enf+81se55xJGadAYW3H0jxL s+RluOVAkMwxifVOo27opQAcVn5lS16srIpfAhEw3YUkE6EYsaDzxJjBbywjOSNqYk0uxgpXCyjds yZ+Kg4C+4o/FcDvzlZOuSHCQL3Qxe5vdsXUJsbgZ+Dt4AMIfvtpbzZ7KTka8Lahr07z3VFjVNkPhX owv94nIBvIpbFLpcZf1sTe7R9HzzR62W3v79faCiK0i10lBqCky8yfMpmtqmnofiPH3kjXd0ImbZ6 Eut4AgG7KLHvZvAweC9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ol7MP-000v11-Ib; Wed, 19 Oct 2022 11:35:45 +0000 Received: from hours.tkos.co.il ([84.110.109.230] helo=mail.tkos.co.il) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ol7MM-000uzs-8A for linux-arm-kernel@lists.infradead.org; Wed, 19 Oct 2022 11:35:44 +0000 Received: from tarshish (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.tkos.co.il (Postfix) with ESMTPS id 2C3DF4405F3; Wed, 19 Oct 2022 14:33:29 +0300 (IDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tkos.co.il; s=default; t=1666179209; bh=ooaBlWbe5BcZsvcnQ+dv/mblh3tcKd5KddrxqCXz3KU=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=JZ9JJhnUc4iGBEbErU9+6FWc8In32oTPsUWUiL6K8VCaeboHtYJCVy/zFeGe0dZKo xtOBZACMqlXoeSc7aofFlgrePrxrjQSDup04FdpPxx5wuc8rPfSS0RqbhLpDYCOu+7 IR6QfRm6Ttq+cfXPiAK+yHjw4WH9QmSDqFEQOvDrpbwEm3LD/3EZVPNVNfS6GqELqp FzqaTS+q1q8GaMGD77v5jN0yq/N9Ln76ffcSHSAYiwZZEkDdVovZ4RS4Oh79/V8ouZ urJDMHZeRR59SBMN2/tI4Iw8veCDtljJqT9xE/3CAxssMIQE7PtTcXhUUJT1DSzd8l hNFpkzPfswIKg== References: <20221019091151.6692-1-ilpo.jarvinen@linux.intel.com> <20221019091151.6692-15-ilpo.jarvinen@linux.intel.com> User-agent: mu4e 1.8.10; emacs 27.1 From: Baruch Siach To: Ilpo =?utf-8?Q?J=C3=A4rvinen?= Cc: linux-serial@vger.kernel.org, Greg KH , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andy Shevchenko Subject: Re: [PATCH 14/44] serial: digicolor: Use uart_xmit_advance() Date: Wed, 19 Oct 2022 14:30:51 +0300 In-reply-to: <20221019091151.6692-15-ilpo.jarvinen@linux.intel.com> Message-ID: <87ilkgdp17.fsf@tarshish> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221019_043542_813101_0A5EB102 X-CRM114-Status: GOOD ( 13.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgSWxwbywKCk9uIFdlZCwgT2N0IDE5IDIwMjIsIElscG8gSsOkcnZpbmVuIHdyb3RlOgo+IFRh a2UgYWR2YW50YWdlIG9mIHRoZSBuZXcgdWFydF94bWl0X2FkdmFuY2UoKSBoZWxwZXIuCj4KPiBT aWduZWQtb2ZmLWJ5OiBJbHBvIErDpHJ2aW5lbiA8aWxwby5qYXJ2aW5lbkBsaW51eC5pbnRlbC5j b20+CgpBY2tlZC1ieTogQmFydWNoIFNpYWNoIDxiYXJ1Y2hAdGtvcy5jby5pbD4KClRoYW5rcywK YmFydWNoCgo+IC0tLQo+ICBkcml2ZXJzL3R0eS9zZXJpYWwvZGlnaWNvbG9yLXVzYXJ0LmMgfCAz ICstLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDIgZGVsZXRpb25zKC0pCj4K PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy90dHkvc2VyaWFsL2RpZ2ljb2xvci11c2FydC5jIGIvZHJp dmVycy90dHkvc2VyaWFsL2RpZ2ljb2xvci11c2FydC5jCj4gaW5kZXggMGMwYTYyMzQ2ZjIzLi5l ZDE5NzcwNWY3ZWUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy90dHkvc2VyaWFsL2RpZ2ljb2xvci11 c2FydC5jCj4gKysrIGIvZHJpdmVycy90dHkvc2VyaWFsL2RpZ2ljb2xvci11c2FydC5jCj4gQEAg LTIwMiw4ICsyMDIsNyBAQCBzdGF0aWMgdm9pZCBkaWdpY29sb3JfdWFydF90eChzdHJ1Y3QgdWFy dF9wb3J0ICpwb3J0KQo+ICAKPiAgCXdoaWxlICghdWFydF9jaXJjX2VtcHR5KHhtaXQpKSB7Cj4g IAkJd3JpdGViKHhtaXQtPmJ1Zlt4bWl0LT50YWlsXSwgcG9ydC0+bWVtYmFzZSArIFVBX0VNSV9S RUMpOwo+IC0JCXhtaXQtPnRhaWwgPSAoeG1pdC0+dGFpbCArIDEpICYgKFVBUlRfWE1JVF9TSVpF IC0gMSk7Cj4gLQkJcG9ydC0+aWNvdW50LnR4Kys7Cj4gKwkJdWFydF94bWl0X2FkdmFuY2UocG9y dCwgMSk7Cj4gIAo+ICAJCWlmIChkaWdpY29sb3JfdWFydF90eF9mdWxsKHBvcnQpKQo+ICAJCQli cmVhazsKCi0tIAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIH4uIC5+ICAgVGsgT3BlbiBTeXN0ZW1zCj19LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tb29PLS1VLS1Pb28tLS0tLS0tLS0tLS17PQogICAtIGJh cnVjaEB0a29zLmNvLmlsIC0gdGVsOiArOTcyLjUyLjM2OC40NjU2LCBodHRwOi8vd3d3LnRrb3Mu Y28uaWwgLQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtYXJtLWtlcm5lbAo=