From: "Alex Bennée" <alex.bennee@linaro.org>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, fam@euphon.net, berrange@redhat.com,
f4bug@amsat.org, aurelien@aurel32.net, pbonzini@redhat.com,
stefanha@redhat.com, crosa@redhat.com,
Wainer dos Santos Moschetta <wainersm@redhat.com>,
Beraldo Leal <bleal@redhat.com>
Subject: Re: [PATCH v1 11/25] tests/docker: remove amd64 qemu/debian10 dependency
Date: Fri, 26 Aug 2022 22:47:06 +0100 [thread overview]
Message-ID: <87ilmeptga.fsf@linaro.org> (raw)
In-Reply-To: <1c34e1b4-118a-29f1-d3c3-b62343d136f3@redhat.com>
Thomas Huth <thuth@redhat.com> writes:
> On 26/08/2022 19.21, Alex Bennée wrote:
>> We missed removing this dependency when we flattened the build.
>> Fixes 9e19fd7d4a (tests/docker: update debian-amd64 with lcitool)
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>> tests/docker/Makefile.include | 1 -
>> 1 file changed, 1 deletion(-)
>> diff --git a/tests/docker/Makefile.include
>> b/tests/docker/Makefile.include
>> index 5c9398bbc9..c3375f89c5 100644
>> --- a/tests/docker/Makefile.include
>> +++ b/tests/docker/Makefile.include
>> @@ -73,7 +73,6 @@ docker-binfmt-image-debian-%: $(DOCKER_FILES_DIR)/debian-bootstrap.docker
>> # we don't run tests on intermediate images (used as base by another image)
>> DOCKER_PARTIAL_IMAGES := debian10 debian11
>> ifeq ($(HOST_ARCH),x86_64)
>> -docker-image-debian-amd64: docker-image-debian10
>> DOCKER_PARTIAL_IMAGES += debian-amd64-cross
>> else
>> docker-image-debian-amd64-cross: docker-image-debian10
>
> What about the "DOCKER_PARTIAL_IMAGES += debian-amd64" that comes
> later in this file? Do we still need that line?
Yes because this stops us using the image on non-x86 hosts. It's poorly
named but I don't want to further complicate the Makefile while trying
to simplify it ;-)
>
> Thomas
--
Alex Bennée
next prev parent reply other threads:[~2022-08-26 21:49 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 17:21 [PATCH v1 for 7.2 00/25] testing updates and mips deprecation Alex Bennée
2022-08-26 17:21 ` [PATCH v1 01/25] tests/avocado: split the AST2x00Machine classes Alex Bennée
2022-08-26 19:27 ` Thomas Huth
2022-08-26 17:21 ` [PATCH v1 02/25] tests/avocado: reduce the default timeout to 120s Alex Bennée
2022-08-26 19:44 ` Thomas Huth
2022-08-31 18:18 ` Alex Bennée
2022-08-26 17:21 ` [PATCH v1 03/25] tests/docker: update and flatten debian-alpha-cross Alex Bennée
2022-08-26 20:00 ` Thomas Huth
2022-08-26 17:21 ` [PATCH v1 04/25] tests/docker: update and flatten debian-hppa-cross Alex Bennée
2022-08-26 20:01 ` Thomas Huth
2022-08-26 17:21 ` [PATCH v1 05/25] tests/docker: update and flatten debian-m68k-cross Alex Bennée
2022-08-26 20:02 ` Thomas Huth
2022-08-26 17:21 ` [PATCH v1 06/25] tests/docker: update and flatten debian-mips64-cross Alex Bennée
2022-08-26 20:06 ` Thomas Huth
2022-08-26 17:21 ` [PATCH v1 07/25] tests/docker: update and flatten debian-sh4-cross Alex Bennée
2022-08-26 20:06 ` Thomas Huth
2022-08-26 17:21 ` [PATCH v1 08/25] tests/docker: update and flatten debian-sparc64-cross Alex Bennée
2022-08-26 20:10 ` Thomas Huth
2022-08-26 17:21 ` [PATCH v1 09/25] tests/docker: flatten debian-powerpc-test-cross Alex Bennée
2022-08-26 20:14 ` Thomas Huth
2022-08-26 17:21 ` [PATCH v1 10/25] tests/docker: remove tricore qemu/debian10 dependency Alex Bennée
2022-08-26 20:17 ` Thomas Huth
2022-08-26 17:21 ` [PATCH v1 11/25] tests/docker: remove amd64 " Alex Bennée
2022-08-26 20:26 ` Thomas Huth
2022-08-26 21:47 ` Alex Bennée [this message]
2022-08-27 4:59 ` Thomas Huth
2022-08-26 17:21 ` [PATCH v1 12/25] tests/vm: Remove obsolete Fedora VM test Alex Bennée
2022-08-29 23:13 ` Philippe Mathieu-Daudé via
2022-08-26 17:21 ` [PATCH v1 13/25] gitlab-ci/custom-runners: Disable -static-pie for ubuntu-20.04-aarch64 Alex Bennée
2022-08-29 23:16 ` Philippe Mathieu-Daudé via
2022-08-29 23:41 ` Richard Henderson
2022-08-26 17:21 ` [PATCH v1 14/25] gitlab-ci: update aarch32/aarch64 custom runner jobs Alex Bennée
2022-08-26 20:27 ` Thomas Huth
2022-08-26 17:21 ` [PATCH v1 15/25] Deprecate 32 bit big-endian MIPS Alex Bennée
2022-08-26 20:39 ` Thomas Huth
2022-09-01 9:57 ` Alex Bennée
2022-08-29 23:38 ` Philippe Mathieu-Daudé via
2022-08-30 0:46 ` Huacai Chen
2022-08-26 17:21 ` [PATCH v1 16/25] tests/docker: flatten debian-riscv64-test-cross Alex Bennée
2022-08-26 20:49 ` Thomas Huth
2022-08-26 17:21 ` [PATCH v1 17/25] tests/docker: update and flatten debian-all-test-cross Alex Bennée
2022-08-26 18:34 ` Thomas Huth
2022-08-26 17:21 ` [PATCH v1 18/25] tests/lcitool: bump to latest version Alex Bennée
2022-08-26 18:37 ` Thomas Huth
2022-08-26 17:21 ` [PATCH v1 19/25] tests/docker: update and flatten debian-amd64-cross Alex Bennée
2022-08-27 5:38 ` Thomas Huth
2022-08-26 17:21 ` [PATCH v1 20/25] tests/docker: update and flatten debian-loongarch-cross Alex Bennée
2022-08-27 5:41 ` Thomas Huth
2022-08-26 17:21 ` [PATCH v1 21/25] tests/docker: update and flatten debian-hexagon-cross Alex Bennée
2022-08-27 5:45 ` Thomas Huth
2022-08-26 17:21 ` [PATCH v1 22/25] tests/docker: update and flatten debian-toolchain Alex Bennée
2022-08-27 5:49 ` Thomas Huth
2022-08-27 9:32 ` Alex Bennée
2022-08-26 17:21 ` [PATCH v1 23/25] tests/docker: remove FROM qemu/ support from docker.py Alex Bennée
2022-08-27 5:50 ` Thomas Huth
2022-08-26 17:21 ` [PATCH v1 24/25] tests/docker: remove the Debian base images Alex Bennée
2022-08-27 5:53 ` Thomas Huth
2022-08-26 17:21 ` [PATCH v1 25/25] gitlab-ci: Only use one process in Windows jobs for compilation Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilmeptga.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.